From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tamas K Lengyel <tamas.lengyel@zentific.com>
Subject: Re: [RFC PATCH V3 12/12] xen/vm_event: Check for
 VM_EVENT_FLAG_DUMMY only in Debug builds
Date: Fri, 6 Feb 2015 14:22:00 +0100
Message-ID: <CAErYnsjZQ5DBP_HcVitqzKCtQQ_xTF1N0-oK3MN_Ekfg6KLRcg@mail.gmail.com>
References: <1422567998-29995-1-git-send-email-tamas.lengyel@zentific.com>
	<1422567998-29995-13-git-send-email-tamas.lengyel@zentific.com>
	<54D1F940020000780005CB4A@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54D1F940020000780005CB4A@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, "Tian, Kevin" <kevin.tian@intel.com>, "wei.liu2@citrix.com" <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, "Dong,
	Eddie" <eddie.dong@intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Steven Maresca <steve@zentific.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Jun Nakajima <jun.nakajima@intel.com>, "rshriram@cs.ubc.ca" <rshriram@cs.ubc.ca>, Keir Fraser <keir@xen.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, "yanghy@cn.fujitsu.com" <yanghy@cn.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, Feb 4, 2015 at 10:49 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 29.01.15 at 22:46, <tamas.lengyel@zentific.com> wrote:
>> The flag is only used for debugging purposes, thus it should be only checked
>> for in debug builds of Xen.
>
> So this should be where the respective conditional I just complained
> about should get added.
>
>
>> --- a/xen/common/mem_access.c
>> +++ b/xen/common/mem_access.c
>> @@ -30,6 +30,37 @@
>>  #include <asm/p2m.h>
>>  #include <xsm/xsm.h>
>>
>> +void mem_access_resume(struct domain *d)
>> +{
>
> Why is this being re-added, and how do things build with the other
> (inline) mem_access_resume() added in an earlier patch?
>
> Jan

Yes, this patch got a bit mixed up with the previous one.

To answer your question nevertheless, mem_access_resume is redefined
to be only doing mem_access related work. Previously it was
responsible to pulling all the responses off the ring, even if these
were not mem_access related. Now the monitor is pulling the responses
off the ring, and issues mem_access_resume if the response is to a
mem_access request.

Tamas