Re: [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures

From: Tamas K Lengyel <tamas.lengyel@zentific.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, "Tian, Kevin" <kevin.tian@intel.com>,
	wei.liu2@citrix.com, Ian Campbell <Ian.Campbell@citrix.com>,
	Razvan Cojocaru <rcojocaru@bitdefender.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	"Dong, Eddie" <eddie.dong@intel.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
	Steven Maresca <steve@zentific.com>,
	Andres Lagar-Cavilla <andres@lagarcavilla.org>,
	Jun Nakajima <jun.nakajima@intel.com>,
	rshriram@cs.ubc.ca, Keir Fraser <keir@xen.org>,
	Daniel De Graaf <dgdegra@tycho.nsa.gov>,
	yanghy@cn.fujitsu.com
Subject: Re: [RFC PATCH V3 01/12] xen/mem_event: Cleanup of mem_event structures
Date: Thu, 5 Feb 2015 13:12:24 +0100	[thread overview]
Message-ID: <CAErYnsjpgApTeAzQmGETA=k67RX3Dk_RZX6r5u1e7OLFzmfj=w@mail.gmail.com> (raw)
In-Reply-To: <54D0A03C020000780005C426@mail.emea.novell.com>

On Tue, Feb 3, 2015 at 10:17 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 02.02.15 at 18:19, <Ian.Campbell@citrix.com> wrote:
>> On Thu, 2015-01-29 at 22:46 +0100, Tamas K Lengyel wrote:
>>> +    union {
>>> +        struct mem_event_paging_data                mem_paging;
>>> +        struct mem_event_sharing_data               mem_sharing;
>>> +        struct mem_event_mem_access_data            mem_access;
>>> +        struct mem_event_mov_to_cr_data             mov_to_cr;
>>> +        struct mem_event_mov_to_msr_data            mov_to_msr;
>>> +        struct mem_event_software_breakpoint_data   software_breakpoint;
>>> +        struct mem_event_singlestep_data            singlestep;
>>> +    } data;
>>
>> We typically call these unions "u" but that's up to the hypervisor guys
>> really.
>
> And yes, I agree we should be consistent with things like this.
>
> Jan

Ack.