From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tamas K Lengyel <tamas.lengyel@zentific.com>
Subject: Re: [RFC PATCH V3 11/12] xen/vm_event: Decouple
	vm_event and mem_access.
Date: Fri, 6 Feb 2015 17:12:30 +0100
Message-ID: <CAErYnsjwN7K0uFug3eXn+erAoVabTuo1v=NdDReUvqKmzME8Xw@mail.gmail.com>
References: <1422567998-29995-1-git-send-email-tamas.lengyel@zentific.com>
	<1422567998-29995-12-git-send-email-tamas.lengyel@zentific.com>
	<54D1F8A6020000780005CB47@mail.emea.novell.com>
	<CAErYnsjvY5cX1V5szh6NxhmGaKR9cq_ChKKD-UyptppWzGgnhg@mail.gmail.com>
	<54D4DBC2020000780005DC21@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54D4DBC2020000780005DC21@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, "wei.liu2@citrix.com" <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Razvan Cojocaru <rcojocaru@bitdefender.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, Ian Jackson <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Steven Maresca <steve@zentific.com>, Andres Lagar-Cavilla <andres@lagarcavilla.org>, Jun Nakajima <jun.nakajima@intel.com>, "rshriram@cs.ubc.ca" <rshriram@cs.ubc.ca>, Keir Fraser <keir@xen.org>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, "yanghy@cn.fujitsu.com" <yanghy@cn.fujitsu.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, Feb 6, 2015 at 3:20 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>>> On 06.02.15 at 14:10, <tamas.lengyel@zentific.com> wrote:
>> On Wed, Feb 4, 2015 at 10:47 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>> On 29.01.15 at 22:46, <tamas.lengyel@zentific.com> wrote:
>>>> --- a/xen/common/Makefile
>>>> +++ b/xen/common/Makefile
>>>> @@ -52,9 +52,10 @@ obj-y += tmem_xen.o
>>>>  obj-y += radix-tree.o
>>>>  obj-y += rbtree.o
>>>>  obj-y += lzo.o
>>>> +obj-y += vm_event.o
>>>> +obj-y += monitor.o
>>>
>>> Please make the (not) sorting situation worse than it already is - the
>>> original intention was for entries to be alphabetically sorted here.
>>
>> I'm just going to sort the list in this patch to have everything in
>> alphabetic order.
>
> In a prereq patch then you (hopefully) mean?

Does reordering the already out-of-whack list worth its own patch? I
just reordered it as part of this patch that adds to it.

>
>>>> +#include <public/memory.h>
>>>
>>> This can't be enough (nor can I see why it's needed here), or else ...
>>>
>>>> +/* Resumes the running of the VCPU, restarting the last instruction */
>>>> +void monitor_resume(struct domain *d);
>>>
>>> ... struct domain may end up being a forward reference (with scope
>>> restricted to monitor_resume()).
>>
>> I'll revisit the headers needed for this one but it did build fine.
>
> Sure - presumably because the including sites included what is needed
> up front.

Probably. Looking at this header all it would need is xen/sched.h for
the definition of struct domain.

> Jan

Thanks,
Tamas