From: McClintock Matthew-B29882 <B29882@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] powerpc/mpc85xx/p1_p2_rdb: add all LAWs during SPL
Date: Thu, 9 Aug 2012 02:28:50 +0000 [thread overview]
Message-ID: <CAEsOVNdBhYGGoTdF1Wj2UpLsY_pVxrA+11D_Nq_5P1sMzs1reA@mail.gmail.com> (raw)
In-Reply-To: <CAEsOVNcZK=pv4=+uUm-g1MbiOg2bHSBKEHYGt1hw6VEbxuwHww@mail.gmail.com>
On Wed, Aug 8, 2012 at 9:27 PM, Matthew McClintock <msm@freescale.com> wrote:
> On Wed, Aug 8, 2012 at 8:06 PM, Scott Wood <scottwood@freescale.com> wrote:
>> LAW init is skipped in the SPL payload because it's assumed that the SPL
>> has taken care of it -- so make sure the SPL loads all the LAWs as is
>> done on other boards.
>
> It might be good to try this on a few different compilers to see if
> they are all under the size requirement. I've made this smaller from
> other work so it could still be OK.
Err, I spoke too soon... this might not be upstreamed though.
-M
>
> -M
>
>>
>> This bug was introduced by:
>>
>> commit 4589728e214958a4e6e011a081a68d360c49d7a5
>> Author: Kumar Gala <galak@kernel.crashing.org>
>> Date: Fri Nov 11 08:14:53 2011 -0600
>>
>> powerpc/85xx: Fix builds of P1020/P2020RDB-PC_36BIT_NAND
>>
>> Size grew a bit so nand-spl didn't fit in 4k, reduce done by removing
>> LAW entries not needed during SPL phase.
>>
>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>> ---
>> board/freescale/p1_p2_rdb_pc/law.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/board/freescale/p1_p2_rdb_pc/law.c b/board/freescale/p1_p2_rdb_pc/law.c
>> index 7968919..0da8300 100644
>> --- a/board/freescale/p1_p2_rdb_pc/law.c
>> +++ b/board/freescale/p1_p2_rdb_pc/law.c
>> @@ -25,13 +25,11 @@
>> #include <asm/mmu.h>
>>
>> struct law_entry law_table[] = {
>> -#ifndef CONFIG_NAND_SPL
>> SET_LAW(CONFIG_SYS_CPLD_BASE_PHYS, LAW_SIZE_1M, LAW_TRGT_IF_LBC),
>> SET_LAW(CONFIG_SYS_PMC_BASE_PHYS, LAW_SIZE_64K, LAW_TRGT_IF_LBC),
>> #ifdef CONFIG_VSC7385_ENET
>> SET_LAW(CONFIG_SYS_VSC7385_BASE_PHYS, LAW_SIZE_1M, LAW_TRGT_IF_LBC),
>> #endif
>> -#endif
>> SET_LAW(CONFIG_SYS_FLASH_BASE_PHYS, LAW_SIZE_64M, LAW_TRGT_IF_LBC),
>> #ifdef CONFIG_SYS_NAND_BASE_PHYS
>> SET_LAW(CONFIG_SYS_NAND_BASE_PHYS, LAW_SIZE_1M, LAW_TRGT_IF_LBC),
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
next prev parent reply other threads:[~2012-08-09 2:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 1:03 [U-Boot] [PATCH 1/2] nand/fsl_elbc: shrink SPL a bit by converting out_be32() to __raw_writel() Scott Wood
2012-08-09 1:06 ` [U-Boot] [PATCH 2/2] powerpc/mpc85xx/p1_p2_rdb: add all LAWs during SPL Scott Wood
2012-08-09 2:28 ` McClintock Matthew-B29882
2012-08-09 2:28 ` McClintock Matthew-B29882 [this message]
2012-08-09 16:52 ` Scott Wood
2012-08-10 6:54 ` Huang Changming-R66093
2012-08-10 16:05 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEsOVNdBhYGGoTdF1Wj2UpLsY_pVxrA+11D_Nq_5P1sMzs1reA@mail.gmail.com \
--to=b29882@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.