From: McClintock Matthew-B29882 <B29882@freescale.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: McClintock Matthew-B29882 <B29882@freescale.com>
Subject: Re: [PATCH] linux-dtb.inc: update dtb name to keep it same in D and DEPLOYDIR
Date: Mon, 16 Jul 2012 22:23:54 +0000 [thread overview]
Message-ID: <CAEsOVNdfx2LW5Z-j+CmYk5yo0gd5AhqZ0QNZzbbOLDWiNYkbBA@mail.gmail.com> (raw)
In-Reply-To: <AF604684617F454390621992F367F169011A0067@039-SN2MPN1-021.039d.mgd.msft.net>
On Sun, Jul 15, 2012 at 6:07 AM, Liu Ting-B28495 <B28495@freescale.com> wrote:
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Richard Purdie
> Sent: Thursday, July 12, 2012 7:04 PM
> To: Patches and discussions about the oe-core layer
> Cc: McClintock Matthew-B29882
> Subject: Re: [OE-core] [PATCH] linux-dtb.inc: update dtb name to keep it same in D and DEPLOYDIR
>
> On Thu, 2012-07-12 at 04:17 -0500, b28495@freescale.com wrote:
>> From: Ting Liu <b28495@freescale.com>
>>
>> Device tree binary is named as "devicetree-*" in ${D},
>> "${KERNEL_IMAGETYPE}-*" in ${DEPLOYDIR}. Keep them the same.
>>
>> Signed-off-by: Ting Liu <b28495@freescale.com>
>> ---
>> meta/recipes-kernel/linux/linux-dtb.inc | 9 ++++++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/recipes-kernel/linux/linux-dtb.inc
>> b/meta/recipes-kernel/linux/linux-dtb.inc
>> index 8aa1458..3dd4d41 100644
>> --- a/meta/recipes-kernel/linux/linux-dtb.inc
>> +++ b/meta/recipes-kernel/linux/linux-dtb.inc
>> @@ -1,5 +1,5 @@
>> # Support for device tree generation
>> -FILES_kernel-devicetree = "/boot/devicetree*"
>> +FILES_kernel-devicetree = "/boot/*.dtb"
>> KERNEL_DEVICETREE_FLAGS = "-R 8 -p 0x3000"
>>
>> python __anonymous () {
>> @@ -10,7 +10,7 @@ python __anonymous () {
>> depends = d.getVar("DEPENDS", True)
>> d.setVar("DEPENDS", "%s dtc-native" % depends)
>> packages = d.getVar("PACKAGES", True)
>> - d.setVar("PACKAGES", "%s kernel-devicetree" % packages)
>> + d.setVar("PACKAGES", "kernel-devicetree %s" % packages)
>> }
>
> Why did you need to change PACKAGES? There is no mention of this in the patch description.
>
> Cheers,
>
> Richard
>
> [Liu Ting-B28495] Sorry for missing that. Because device tree binary is renamed with prefix "${KERNEL_IMAGETYPE}, it will be packaged to kernel-image if not modifying the variable PACKAGES.
Ok, so you reordered the packages so your device tree package get's to
grab the file first. Did you consider making the other package less
greedy and excluding these dtb files?
Why is any of this in an anonymous python function? Should it just be
DEPENDS_append
PACKAGES_append
?
-M
next prev parent reply other threads:[~2012-07-16 22:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 9:17 [PATCH] kernel.bbclass: update image name to keep it same in D and DEPLOYDIR b28495
2012-07-12 9:17 ` [PATCH] linux-dtb.inc: update dtb " b28495
2012-07-12 11:03 ` Richard Purdie
2012-07-15 11:07 ` Liu Ting-B28495
2012-07-16 22:23 ` McClintock Matthew-B29882 [this message]
2012-07-12 11:02 ` [PATCH] kernel.bbclass: update image " Richard Purdie
2012-07-15 11:18 ` Liu Ting-B28495
2012-07-15 16:02 ` Khem Raj
2012-07-17 8:30 ` Liu Ting-B28495
2012-07-16 22:20 ` McClintock Matthew-B29882
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEsOVNdfx2LW5Z-j+CmYk5yo0gd5AhqZ0QNZzbbOLDWiNYkbBA@mail.gmail.com \
--to=b29882@freescale.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.