From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89D61C4338F for ; Sat, 24 Jul 2021 18:04:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70F0E60E8B for ; Sat, 24 Jul 2021 18:04:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229905AbhGXRXw (ORCPT ); Sat, 24 Jul 2021 13:23:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbhGXRXv (ORCPT ); Sat, 24 Jul 2021 13:23:51 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC02FC061575 for ; Sat, 24 Jul 2021 11:04:21 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id a19so4018945qtx.1 for ; Sat, 24 Jul 2021 11:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ySjT+9vhA6LvbQeBz3snrx5GQAIqPB2FJPEofd/VFlc=; b=CpeZupTFKNWztEfPSidkKyHokcBAMt2Wi3fxZGNLVd9kQwfMEr8hmCzrpiZN8OajUR 1+Xgsg4E676KQ74nsIIUiTPr4+Zw4V/ZN5RKuKdZ6K8oXET13wSGXe+qjA54BIHiMkKm sHm8dYljb49cClUOdGMEM0pvJj4lj4UDwxdJinCyQHxn9TCwvT70YBBHtQPFkZbobDu9 WF6iQDBjKpudNhx11mX6Mo0MhxNMN6RVUnju9CLdigEgMEXAXweTi0zWlz3/Ykl66JXW N+vs6XUlGIKVitlY1Q7e8wm2R9Y2VsNVnlQKT0a5UqVO6HFYANzF8JobRi+jguYBiwJO y3BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ySjT+9vhA6LvbQeBz3snrx5GQAIqPB2FJPEofd/VFlc=; b=nupNke781RkPugWg6HI+TYZWK0jSg0DSBYT4T5seODdidxEjm/rMyZ6lhEBWTOiXSD sAuDH6jw+rSLyhMV92g/XpR2r04jiqUkJxIZWx4l7AgG879SjSyqpuSzYnXJ+zsH2qe7 WVKmmqu+7S7Lgk67uHwh+mteW8wStxfOXrgR01CmUcUupIRW8PPxCdmzn5y3QyjNyXiW iaeyx/XFU8AX725Ol2E0idVXJ9B4JP3xcUJ26JEYf1iLdeN7xl5KT/IhBRczDWP4gHqN NdhJP7eCvPavSZatKh4rk2xLAZTMsKXa7SvWWqKwQxI2wiXyIweNeOwMIfSFAEb+19pB zxzA== X-Gm-Message-State: AOAM530Lky9rr4aJAdOeuY+wG59AoOLV+cHBf9G9PznsiuSgIoshOIBb iUWHE0oU+pL6oBkFl/yhTgKqEVaaYuwWEvfsoS4= X-Google-Smtp-Source: ABdhPJxMOQJzEBbdDPWv1NzazwoX7K1S3r0NWDDWZvXR+QrtOrw9xPXY6S+kNGfbhguYEAiamAOcEG/7A5ZLh49DO54= X-Received: by 2002:ac8:1483:: with SMTP id l3mr8917231qtj.142.1627149861044; Sat, 24 Jul 2021 11:04:21 -0700 (PDT) MIME-Version: 1.0 References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> In-Reply-To: From: Geraldo Nascimento Date: Sat, 24 Jul 2021 15:04:13 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: Takashi Iwai Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai wrote: > > This looks like a regression introduced by the recent commit > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock > selector"), which is a fix for certain devices. Too bad that the > behavior really depends on the device... Dr. Iwai, perhaps we could restrict the generalized fix for the Behringer UFX1604 / UFX1204 with some simple logic to devices that only have *one* clock source. In that case the clock selector must be set to the only clock source. This way we keep the generalization without breaking devices with more than one clock source. Just an idea. Thank you, Geraldo Nascimento From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 462CAC4338F for ; Sat, 24 Jul 2021 18:06:51 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B49E560E95 for ; Sat, 24 Jul 2021 18:06:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B49E560E95 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5E917175B; Sat, 24 Jul 2021 20:05:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5E917175B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627150007; bh=0ZovEVRRhsY88un6PBbZ2vZomv0g2lTMvNOXou7CPKw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=nCWhDeDF/sHTzUtNY+toAswvwzf2jqhdoQXwTc88UHG1s8WsZWU4GvYIOqpznl98O M2uFiIDM19s/9dgCaUAS917GQO7/oBv9fC/01ORXiR36orcExqW0qnfuteDh+Q2xhv aIwY9P3w2gRW/pOGnC1xhZdWHSZCFsXrna5QkV1E= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CE9D0F80218; Sat, 24 Jul 2021 20:05:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CF26BF80227; Sat, 24 Jul 2021 20:05:50 +0200 (CEST) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3A172F800F0 for ; Sat, 24 Jul 2021 20:04:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3A172F800F0 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CpeZupTF" Received: by mail-qt1-x82d.google.com with SMTP id m11so3975004qtx.7 for ; Sat, 24 Jul 2021 11:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ySjT+9vhA6LvbQeBz3snrx5GQAIqPB2FJPEofd/VFlc=; b=CpeZupTFKNWztEfPSidkKyHokcBAMt2Wi3fxZGNLVd9kQwfMEr8hmCzrpiZN8OajUR 1+Xgsg4E676KQ74nsIIUiTPr4+Zw4V/ZN5RKuKdZ6K8oXET13wSGXe+qjA54BIHiMkKm sHm8dYljb49cClUOdGMEM0pvJj4lj4UDwxdJinCyQHxn9TCwvT70YBBHtQPFkZbobDu9 WF6iQDBjKpudNhx11mX6Mo0MhxNMN6RVUnju9CLdigEgMEXAXweTi0zWlz3/Ykl66JXW N+vs6XUlGIKVitlY1Q7e8wm2R9Y2VsNVnlQKT0a5UqVO6HFYANzF8JobRi+jguYBiwJO y3BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ySjT+9vhA6LvbQeBz3snrx5GQAIqPB2FJPEofd/VFlc=; b=QWPkCIAuxDtlz6N+0HDtcHA4xOAgHhyQyhDkISdpxADtEL2SfMNXk0xnyfmwuUpEaX ndiGQYhgUh953wSJ3IO9xA7EN5ViVK2uVFosAfT9eTghZcPrvtflwez39DjVjldkoliZ vB7ysFVYGmTpqo+FX+8AZ8sVggXYQA1/N/6m/lO3j8yD3E2Bxk4tsciaiDoqMgTTawfx 1dk6MW5kov8HjO8Qf+x+T9tdQqQgSTwe8BpyxMHTK1rJ+B//UWW3PISzIiVJLEmLbiFu Mwl8mDpqDXalszwGgqVK0iKZE+FTg4Nj7NLkgaCQyhT+wsrjJ8jcoBTLAzUqIpWwNb0T b3nA== X-Gm-Message-State: AOAM533dsxXvgF+W3TERfOWTV04xCel6lC8EOX0gb8wz684Loqkc1rU6 CnkkIBFOw4/y2W3+MNstfyyhAhUeKepdC71lm/8= X-Google-Smtp-Source: ABdhPJxMOQJzEBbdDPWv1NzazwoX7K1S3r0NWDDWZvXR+QrtOrw9xPXY6S+kNGfbhguYEAiamAOcEG/7A5ZLh49DO54= X-Received: by 2002:ac8:1483:: with SMTP id l3mr8917231qtj.142.1627149861044; Sat, 24 Jul 2021 11:04:21 -0700 (PDT) MIME-Version: 1.0 References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> In-Reply-To: From: Geraldo Nascimento Date: Sat, 24 Jul 2021 15:04:13 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: Takashi Iwai Content-Type: text/plain; charset="UTF-8" Cc: alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, linux-kernel@vger.kernel.org, tiwai@suse.com, chihhao.chen@mediatek.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai wrote: > > This looks like a regression introduced by the recent commit > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock > selector"), which is a fix for certain devices. Too bad that the > behavior really depends on the device... Dr. Iwai, perhaps we could restrict the generalized fix for the Behringer UFX1604 / UFX1204 with some simple logic to devices that only have *one* clock source. In that case the clock selector must be set to the only clock source. This way we keep the generalization without breaking devices with more than one clock source. Just an idea. Thank you, Geraldo Nascimento From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AB4BC4338F for ; Sat, 24 Jul 2021 18:04:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A3E260E8B for ; Sat, 24 Jul 2021 18:04:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4A3E260E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6ysi7Ej4U0PYkM3GCzsjzxrSJuXHifhHnAbpFLv4bS8=; b=c9nbcnGUzKsfEE zJRc8S3PGRKv2zW9h/koTs2Z5FLEWbu2kTNTIGFH40Ttg/3LqyZGZ0F9Ku1uGcB0ba4ks0WU8nZBD i2GyDJ9UjZycFULS21zc4agfIZyK40J6B+fO8XWXItLID07KQNepdLnNSq3QYW1pOnIg47YignPNv zlf1dl4XClN45BXGy7/gQ5Q/VL8tLJ4/By9FJ9OYcPfC4bvX6UgeyBNPy4zxpqC1c1GoeKzYQjfgW N/oSviqvO8MMWwAhpAp8JjIeIx0LFsiUcLlcy/mg7RNkSz1Ip/IBb+JOA2pVBktSxUoPtCzLuvdM2 N6ACqQ4kBudUWeDyWf/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7M0h-007bbq-N3; Sat, 24 Jul 2021 18:04:27 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7M0f-007bad-CT; Sat, 24 Jul 2021 18:04:26 +0000 Received: by mail-qt1-x82b.google.com with SMTP id a19so4018964qtx.1; Sat, 24 Jul 2021 11:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ySjT+9vhA6LvbQeBz3snrx5GQAIqPB2FJPEofd/VFlc=; b=CpeZupTFKNWztEfPSidkKyHokcBAMt2Wi3fxZGNLVd9kQwfMEr8hmCzrpiZN8OajUR 1+Xgsg4E676KQ74nsIIUiTPr4+Zw4V/ZN5RKuKdZ6K8oXET13wSGXe+qjA54BIHiMkKm sHm8dYljb49cClUOdGMEM0pvJj4lj4UDwxdJinCyQHxn9TCwvT70YBBHtQPFkZbobDu9 WF6iQDBjKpudNhx11mX6Mo0MhxNMN6RVUnju9CLdigEgMEXAXweTi0zWlz3/Ykl66JXW N+vs6XUlGIKVitlY1Q7e8wm2R9Y2VsNVnlQKT0a5UqVO6HFYANzF8JobRi+jguYBiwJO y3BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ySjT+9vhA6LvbQeBz3snrx5GQAIqPB2FJPEofd/VFlc=; b=Kng4cJ9ZOjprO/1g+hnneEBfZAoRP5KA/+mexVjX6dbyTqSh+4FuwKMFQFqsaXhQv1 9EGk7oaWf/zuzL0E1ZqF+C37m7n31DjFgniA+f/6A7eRKW2HQmAg1twHp0eMEItuIPvJ iBQ14rWtsxtSrsDi/VvHHmyvJ8mNAvCkPWrByt2pVjN6ob58rVsjaGLOCinOssNl9y+U ky07S8DcLQZjooCArsnqji5Qa0ol+S66I0iMPjsVgJOLXYZfm9T+7JlSgGPuur3fWYg9 mTJV4scqrFuh5EseYEk4oT5Zn9LxZ6fMlfJkx7g96dJvsaE7MX5LA/UE2GTkhG2euEKb v/Wg== X-Gm-Message-State: AOAM533T8UMrvVWANCUq5qX9R18vyQf3jDJwzbYgzkVaeL1FPMM/WnV3 9LdcCjo+JZT0LVcmNAOknh2PBBnw4QdMSNh7CdA= X-Google-Smtp-Source: ABdhPJxMOQJzEBbdDPWv1NzazwoX7K1S3r0NWDDWZvXR+QrtOrw9xPXY6S+kNGfbhguYEAiamAOcEG/7A5ZLh49DO54= X-Received: by 2002:ac8:1483:: with SMTP id l3mr8917231qtj.142.1627149861044; Sat, 24 Jul 2021 11:04:21 -0700 (PDT) MIME-Version: 1.0 References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> In-Reply-To: From: Geraldo Nascimento Date: Sat, 24 Jul 2021 15:04:13 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: Takashi Iwai Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210724_110425_488920_CD882898 X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai wrote: > > This looks like a regression introduced by the recent commit > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock > selector"), which is a fix for certain devices. Too bad that the > behavior really depends on the device... Dr. Iwai, perhaps we could restrict the generalized fix for the Behringer UFX1604 / UFX1204 with some simple logic to devices that only have *one* clock source. In that case the clock selector must be set to the only clock source. This way we keep the generalization without breaking devices with more than one clock source. Just an idea. Thank you, Geraldo Nascimento _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888CDC4338F for ; Sat, 24 Jul 2021 18:06:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EF4E60E8B for ; Sat, 24 Jul 2021 18:06:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3EF4E60E8B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sGj5CIWRLdBYcdmQgaUOzBB/UTfHztGavqBHNQBcstg=; b=DUQdmlSEO2/P44 3ObUKmTFh/gnSz5SMsPvU50MSfE+itsKhUbdLXcR+gvPJ2d6q1Uq6ynHEuyMhQL+khQMuG4K+JYdc wQWvRROJGT9Z2OPCBQ065AKJAQ1sUTiCAU8IZG69wm39PDuEMSqyblOMtZR8MdozfcsQPdQQrpRhx dGkfeXJQBqpz/VAh8Hdcb/PLdfSXz61x1b8gpj4MOMFRVdnZgPu/fP3k3/ObeAzWD90hbcGXM2Hpt 4SbH1mrLunKVdZg+14G57vVmdXIQ+kH8NLKOR7J1Hq7Rs+b7moKprYnJtU0r2fh7XYKFaNcHazLBA 9sghhX5zzcQwSyk3x7TA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7M0n-007bc2-Qg; Sat, 24 Jul 2021 18:04:33 +0000 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7M0f-007bad-CT; Sat, 24 Jul 2021 18:04:26 +0000 Received: by mail-qt1-x82b.google.com with SMTP id a19so4018964qtx.1; Sat, 24 Jul 2021 11:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ySjT+9vhA6LvbQeBz3snrx5GQAIqPB2FJPEofd/VFlc=; b=CpeZupTFKNWztEfPSidkKyHokcBAMt2Wi3fxZGNLVd9kQwfMEr8hmCzrpiZN8OajUR 1+Xgsg4E676KQ74nsIIUiTPr4+Zw4V/ZN5RKuKdZ6K8oXET13wSGXe+qjA54BIHiMkKm sHm8dYljb49cClUOdGMEM0pvJj4lj4UDwxdJinCyQHxn9TCwvT70YBBHtQPFkZbobDu9 WF6iQDBjKpudNhx11mX6Mo0MhxNMN6RVUnju9CLdigEgMEXAXweTi0zWlz3/Ykl66JXW N+vs6XUlGIKVitlY1Q7e8wm2R9Y2VsNVnlQKT0a5UqVO6HFYANzF8JobRi+jguYBiwJO y3BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ySjT+9vhA6LvbQeBz3snrx5GQAIqPB2FJPEofd/VFlc=; b=Kng4cJ9ZOjprO/1g+hnneEBfZAoRP5KA/+mexVjX6dbyTqSh+4FuwKMFQFqsaXhQv1 9EGk7oaWf/zuzL0E1ZqF+C37m7n31DjFgniA+f/6A7eRKW2HQmAg1twHp0eMEItuIPvJ iBQ14rWtsxtSrsDi/VvHHmyvJ8mNAvCkPWrByt2pVjN6ob58rVsjaGLOCinOssNl9y+U ky07S8DcLQZjooCArsnqji5Qa0ol+S66I0iMPjsVgJOLXYZfm9T+7JlSgGPuur3fWYg9 mTJV4scqrFuh5EseYEk4oT5Zn9LxZ6fMlfJkx7g96dJvsaE7MX5LA/UE2GTkhG2euEKb v/Wg== X-Gm-Message-State: AOAM533T8UMrvVWANCUq5qX9R18vyQf3jDJwzbYgzkVaeL1FPMM/WnV3 9LdcCjo+JZT0LVcmNAOknh2PBBnw4QdMSNh7CdA= X-Google-Smtp-Source: ABdhPJxMOQJzEBbdDPWv1NzazwoX7K1S3r0NWDDWZvXR+QrtOrw9xPXY6S+kNGfbhguYEAiamAOcEG/7A5ZLh49DO54= X-Received: by 2002:ac8:1483:: with SMTP id l3mr8917231qtj.142.1627149861044; Sat, 24 Jul 2021 11:04:21 -0700 (PDT) MIME-Version: 1.0 References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> In-Reply-To: From: Geraldo Nascimento Date: Sat, 24 Jul 2021 15:04:13 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: Takashi Iwai Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210724_110425_488920_CD882898 X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 24, 2021 at 8:05 AM Takashi Iwai wrote: > > This looks like a regression introduced by the recent commit > d2e8f641257d ("ALSA: usb-audio: Explicitly set up the clock > selector"), which is a fix for certain devices. Too bad that the > behavior really depends on the device... Dr. Iwai, perhaps we could restrict the generalized fix for the Behringer UFX1604 / UFX1204 with some simple logic to devices that only have *one* clock source. In that case the clock selector must be set to the only clock source. This way we keep the generalization without breaking devices with more than one clock source. Just an idea. Thank you, Geraldo Nascimento _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel