From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B48C4338F for ; Thu, 5 Aug 2021 18:51:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22E1B60EE5 for ; Thu, 5 Aug 2021 18:51:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241855AbhHESvZ (ORCPT ); Thu, 5 Aug 2021 14:51:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241753AbhHESvX (ORCPT ); Thu, 5 Aug 2021 14:51:23 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1FFBC061765 for ; Thu, 5 Aug 2021 11:51:07 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id c6so339237qtv.5 for ; Thu, 05 Aug 2021 11:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EZEunsTnaA1XzE54VnUD0YcTvntYvxdVoZOW+fPpXuY=; b=jwbsiwneBJFd2Ig6fWCLzTscXOQBAlvphpkOrnXo5ln4b/cl4H84JzNrDvAcVuVS04 +Uix/Q7yD7sCFQhfpMWtshsEx2thnVuroO11Ye12H7cLNnOIvo/FiPnsWG+SFQk1lwcV 3sEv24pAJMkGwqt9wGxdiFoeyMzMpupOtbBb0Qwy6pBrMiRdEymB2b2knQOYqGjPFgNr E8DdbgAlkZrQqmqjZM0uoeQipY4C5YPDXm6UBtDqPrSHvBMJ83dSMElz7Fa3vWk6st0c JwAJt9hDzH1Nn7gPakCOcQ/bsvw0Ub6O85EkbtxZ6rBTYCkWjaX1/1KiXp56WxWZO1bM bq/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EZEunsTnaA1XzE54VnUD0YcTvntYvxdVoZOW+fPpXuY=; b=bzxNmmXb+lJ3dcl5m1do1tz8H/JqC2TEp+WS66i1oVDJCZtBnecpVG6XEgX+ENMI5u pUixgyXBr9jKUV0Sc2ifKqhLZR5nlHnjbTMvUT8oJM8znbxCs9QXv8hI9EpldcBCX4nI q0++kvZ0h0Uqd5AYgcXUn/KP6pqfbQUi5JMlQnCXLi58jLkd+/KHVbxkFp7H+08a12P8 FQzWVz3zVu4LWrdFrIPCBNseQYbCdWPW/TeFb2OJ/soG+lBbzsXwBvznL4K/+tHdsAmx B8rfYMs0Hs39H4/Zmnt/JOs8RPomdHBaRXCUlkFeXlkiuCC1mO0E7OF8Fox5bF0faFz7 IKDw== X-Gm-Message-State: AOAM533fb5mH5ub6Myc94tlsdT4ePSZH44tL3S76ArhSwtZehKzza2bh Kpw0/OqXKKgucEBOXNMl3oLwA58p3UG6BJ2FxfU= X-Google-Smtp-Source: ABdhPJw01R3FsLE2EQNT7CIn9yocm0qu86fk/7OLpG7DKbhG2q6MJn/s0acJtp4DeG5ZfTa6LLUEBQbe0kohY2aFTRY= X-Received: by 2002:ac8:5b83:: with SMTP id a3mr5789733qta.210.1628189467046; Thu, 05 Aug 2021 11:51:07 -0700 (PDT) MIME-Version: 1.0 References: <20210805075401.21170-1-chihhao.chen@mediatek.com> In-Reply-To: <20210805075401.21170-1-chihhao.chen@mediatek.com> From: Geraldo Nascimento Date: Thu, 5 Aug 2021 15:50:58 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: chihhao chen Cc: alsa-devel@alsa-project.org, damien@zamaudio.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, tiwai@suse.com, Takashi Iwai , wsd_upstream@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 5, 2021 at 7:54 AM wrote: > > From: chihhao chen > > Hi Geraldo Nascimento, Hi Chihhao Chen! > > For echo test, it means we use this earphone to receive and play sounds at the same time. > We found in this case serious noise problem happens. > That's what I understood initially, and only a little later I became afraid echo test was the name of the debugging technique you used :) Thanks for the clarification. > Log as follows with your patch > <6>[ 175.960387][T401365] __uac_clock_find_source: Clock Selector 0xc has pin 2 selected > <6>[ 175.966980][T401365] __uac_clock_find_source: Clock Selector 0xb has pin 2 selected > <6>[ 176.026251][T400354] __uac_clock_find_source: Clock Selector 0xc has pin 1 selected > <6>[ 176.032406][T400354] __uac_clock_find_source: Clock Selector 0xb has pin 1 selected > > There is no noise and I think this should be a firmware bug. >From the log I'm afraid my worst assumptions were right. Regardless of which Clock Selector we want to set, the firmware will always set them both. We should contact Samsung now that we have at least a sketch of a bug report... Thanks, Geraldo Nascimento > > Thanks > Chihhao > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC56FC4338F for ; Thu, 5 Aug 2021 18:52:14 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C05A60F01 for ; Thu, 5 Aug 2021 18:52:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5C05A60F01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 13754172D; Thu, 5 Aug 2021 20:51:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 13754172D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1628189531; bh=S4uvklBWpWSw1uINJ3MgwtjKZVhhe7gXqWRSCnLmQ9A=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=rC1QXTzxOfFmTPyJGJowaTtP6Om4yJlXMer2scVg2JhzuARMk0mfmwd1P19doborO fXhoRBBXjTUZeo1UkgVc5JW+syidmFwj8a3PCKczDNNTzbYmOyRI/w2uFij5scc36r uCjk0VYxT75Mkao5hAGH4CkRmY1XS9Uc/d+umIj4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A075AF8016D; Thu, 5 Aug 2021 20:51:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 56524F8027C; Thu, 5 Aug 2021 20:51:19 +0200 (CEST) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 022D6F8010A for ; Thu, 5 Aug 2021 20:51:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 022D6F8010A Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jwbsiwne" Received: by mail-qt1-x833.google.com with SMTP id h27so4600201qtu.9 for ; Thu, 05 Aug 2021 11:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EZEunsTnaA1XzE54VnUD0YcTvntYvxdVoZOW+fPpXuY=; b=jwbsiwneBJFd2Ig6fWCLzTscXOQBAlvphpkOrnXo5ln4b/cl4H84JzNrDvAcVuVS04 +Uix/Q7yD7sCFQhfpMWtshsEx2thnVuroO11Ye12H7cLNnOIvo/FiPnsWG+SFQk1lwcV 3sEv24pAJMkGwqt9wGxdiFoeyMzMpupOtbBb0Qwy6pBrMiRdEymB2b2knQOYqGjPFgNr E8DdbgAlkZrQqmqjZM0uoeQipY4C5YPDXm6UBtDqPrSHvBMJ83dSMElz7Fa3vWk6st0c JwAJt9hDzH1Nn7gPakCOcQ/bsvw0Ub6O85EkbtxZ6rBTYCkWjaX1/1KiXp56WxWZO1bM bq/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EZEunsTnaA1XzE54VnUD0YcTvntYvxdVoZOW+fPpXuY=; b=HMmuKc0/B3PBD257xrZqxB8dxb8RvInbEulRv4P3QONxBlrHEIE1gVdpCzE2VN0pz2 MQzswI6a9mUvchkY/RXNvqGghmnrbIIjVkwDT7G+yNSN3FPbL9hbidXOAqvwJkI0AI0T G5hw7qdc2sgbjqKq6hnGbT+J7EMDqJwaB+InKQrhKAn6Xl61qrP5YoREf7MAiVKvxY3Y slcpnF7LJbi3TGz+4sgZlr2Sz8+gWsK6kBt3TzSUq62mtwL7AyjIbT6WB/8mzPBX0qkJ AnRCYgjCSt+hZXnu7bMffm33Hep24y80jt8qyblp4EzZu/etqZfbnk8DLoxeWA40ujnk jGfQ== X-Gm-Message-State: AOAM533HxfhnJV6DSRxsJzpnOfpbaV4WhgM3K2A63Nj/39QWrQwEUUCQ 0dsVtni4qvPkLjvf6jd5sitC5YrFjlqHxKqVQs4= X-Google-Smtp-Source: ABdhPJw01R3FsLE2EQNT7CIn9yocm0qu86fk/7OLpG7DKbhG2q6MJn/s0acJtp4DeG5ZfTa6LLUEBQbe0kohY2aFTRY= X-Received: by 2002:ac8:5b83:: with SMTP id a3mr5789733qta.210.1628189467046; Thu, 05 Aug 2021 11:51:07 -0700 (PDT) MIME-Version: 1.0 References: <20210805075401.21170-1-chihhao.chen@mediatek.com> In-Reply-To: <20210805075401.21170-1-chihhao.chen@mediatek.com> From: Geraldo Nascimento Date: Thu, 5 Aug 2021 15:50:58 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: chihhao chen Content-Type: text/plain; charset="UTF-8" Cc: alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, Takashi Iwai , damien@zamaudio.com, linux-kernel@vger.kernel.org, tiwai@suse.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Aug 5, 2021 at 7:54 AM wrote: > > From: chihhao chen > > Hi Geraldo Nascimento, Hi Chihhao Chen! > > For echo test, it means we use this earphone to receive and play sounds at the same time. > We found in this case serious noise problem happens. > That's what I understood initially, and only a little later I became afraid echo test was the name of the debugging technique you used :) Thanks for the clarification. > Log as follows with your patch > <6>[ 175.960387][T401365] __uac_clock_find_source: Clock Selector 0xc has pin 2 selected > <6>[ 175.966980][T401365] __uac_clock_find_source: Clock Selector 0xb has pin 2 selected > <6>[ 176.026251][T400354] __uac_clock_find_source: Clock Selector 0xc has pin 1 selected > <6>[ 176.032406][T400354] __uac_clock_find_source: Clock Selector 0xb has pin 1 selected > > There is no noise and I think this should be a firmware bug. >From the log I'm afraid my worst assumptions were right. Regardless of which Clock Selector we want to set, the firmware will always set them both. We should contact Samsung now that we have at least a sketch of a bug report... Thanks, Geraldo Nascimento > > Thanks > Chihhao > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B436DC4338F for ; Thu, 5 Aug 2021 18:51:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CFF160F01 for ; Thu, 5 Aug 2021 18:51:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7CFF160F01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9poeIAJYRxSv6YH9RGB/y+MlA1+AV4TyZ9T2GnlX0eE=; b=4ntKOxq+GTXaLf j2lfrfuI3u5ggnATjZ9sUpsFAU+ZhIsEvr3QChfd6D5q5nRRAgRIk4LqV4+pYt9g5+H99xeqfSjCG n4+rsaZNCNZfMQKKjth/Tjckm/Qz56tg9dHOfWTbrWf4S2iAHGsG68rWUBDn/qM87rkp8P8HoFFpI RyiQOt6Arsu5K7IuOU0/8ZS6Uh/Ll6wYIMWIY9XcaPhBESqS0GphRKknksx4qRdQUkdLMhllRjVFc 9v/Oytl71jkHNAHXTKysFSK2NZbnNlsoXWvbwKYYYbUbGZdGHeRi2iGJcOVsdUX1a/ff/S1V1NIKr snKtCvf5ZGoH3slTEu0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBiSe-00AYjM-Tu; Thu, 05 Aug 2021 18:51:20 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBiSS-00AYiD-US; Thu, 05 Aug 2021 18:51:10 +0000 Received: by mail-qt1-x835.google.com with SMTP id d2so4622474qto.6; Thu, 05 Aug 2021 11:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EZEunsTnaA1XzE54VnUD0YcTvntYvxdVoZOW+fPpXuY=; b=jwbsiwneBJFd2Ig6fWCLzTscXOQBAlvphpkOrnXo5ln4b/cl4H84JzNrDvAcVuVS04 +Uix/Q7yD7sCFQhfpMWtshsEx2thnVuroO11Ye12H7cLNnOIvo/FiPnsWG+SFQk1lwcV 3sEv24pAJMkGwqt9wGxdiFoeyMzMpupOtbBb0Qwy6pBrMiRdEymB2b2knQOYqGjPFgNr E8DdbgAlkZrQqmqjZM0uoeQipY4C5YPDXm6UBtDqPrSHvBMJ83dSMElz7Fa3vWk6st0c JwAJt9hDzH1Nn7gPakCOcQ/bsvw0Ub6O85EkbtxZ6rBTYCkWjaX1/1KiXp56WxWZO1bM bq/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EZEunsTnaA1XzE54VnUD0YcTvntYvxdVoZOW+fPpXuY=; b=piPRD2s2QfA5J5YZH9f95BLUzhVwceDnMe5jz8r5Y5Zd69uINlm5WuZIuoaYme38e0 pcXc2MEvADK6s4Jv/Z8dm7J1VsE2RLyrMFBQQKgUc/DaCj7V8CdFt2Vh8MRKsqwJko2O EwWBv8mEHrw/7ASwcgWQtML9jOblyZY8MHWyPlTp8y+FA/fkcLJJmQcXui/8JUvhDoLJ OWeeEmK9VaD0wkEg5M5jWH2yOVBSOdP9S+UdCcVyHDWM+wMfkFPJ4SEC4wcNBhqSCpwK DUGdt04W0CyVpnulef2oZq76JCRd4Y4G8aI3qs3HsZYUOOmN8Z9JWTe+3Qjnc41XKPed UG7g== X-Gm-Message-State: AOAM530A0V7L+8e5+0C152Yp0MT0RLu23i97Tcn95/Ld8E0PC/6gGN+H T1QmKnDYeZcZhXHj3FrdLIp3VA1p+/5LW0QibxU= X-Google-Smtp-Source: ABdhPJw01R3FsLE2EQNT7CIn9yocm0qu86fk/7OLpG7DKbhG2q6MJn/s0acJtp4DeG5ZfTa6LLUEBQbe0kohY2aFTRY= X-Received: by 2002:ac8:5b83:: with SMTP id a3mr5789733qta.210.1628189467046; Thu, 05 Aug 2021 11:51:07 -0700 (PDT) MIME-Version: 1.0 References: <20210805075401.21170-1-chihhao.chen@mediatek.com> In-Reply-To: <20210805075401.21170-1-chihhao.chen@mediatek.com> From: Geraldo Nascimento Date: Thu, 5 Aug 2021 15:50:58 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: chihhao chen Cc: alsa-devel@alsa-project.org, damien@zamaudio.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, tiwai@suse.com, Takashi Iwai , wsd_upstream@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_115109_036151_290947D8 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Aug 5, 2021 at 7:54 AM wrote: > > From: chihhao chen > > Hi Geraldo Nascimento, Hi Chihhao Chen! > > For echo test, it means we use this earphone to receive and play sounds at the same time. > We found in this case serious noise problem happens. > That's what I understood initially, and only a little later I became afraid echo test was the name of the debugging technique you used :) Thanks for the clarification. > Log as follows with your patch > <6>[ 175.960387][T401365] __uac_clock_find_source: Clock Selector 0xc has pin 2 selected > <6>[ 175.966980][T401365] __uac_clock_find_source: Clock Selector 0xb has pin 2 selected > <6>[ 176.026251][T400354] __uac_clock_find_source: Clock Selector 0xc has pin 1 selected > <6>[ 176.032406][T400354] __uac_clock_find_source: Clock Selector 0xb has pin 1 selected > > There is no noise and I think this should be a firmware bug. >From the log I'm afraid my worst assumptions were right. Regardless of which Clock Selector we want to set, the firmware will always set them both. We should contact Samsung now that we have at least a sketch of a bug report... Thanks, Geraldo Nascimento > > Thanks > Chihhao > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AA9C4338F for ; Thu, 5 Aug 2021 18:52:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69AFA60F3A for ; Thu, 5 Aug 2021 18:52:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 69AFA60F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7hTEX/rJ1YfTCPCNee8+B4YxhaxTS/1Hqq3elr5/Lbg=; b=JYgfuLTYsSPFDi IEwRlpBB7rOajFUSY1WyDJA7uy+X5q3Njh3H7krqFNnhR4dfOriQTeygXfTpKhGOJ8xpAxRud68PF wbWpXkkwVGH1ED1uwviRysu1v41qeZ2OSE7HZimooceD8NDGpeTEVwpk97+Vj8LkuSLejga1pl9NX mj0GS5DfG1LrndL5nXCJpaFgMXoOA9NOl/+VzFXaePZXnXIUMuz/8a2mSn66vSzpvrpR89jRKYx+9 8IxO3YzzmIaSn8EKGF66vv+/MHbbDe4EQ6BaqC+E9HZ+ACg3fNfKXoPFHGd7OA3IS6GVgFrwr/tem fD0T4jML0CnferF7gwPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBiSV-00AYia-Rd; Thu, 05 Aug 2021 18:51:12 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBiSS-00AYiD-US; Thu, 05 Aug 2021 18:51:10 +0000 Received: by mail-qt1-x835.google.com with SMTP id d2so4622474qto.6; Thu, 05 Aug 2021 11:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EZEunsTnaA1XzE54VnUD0YcTvntYvxdVoZOW+fPpXuY=; b=jwbsiwneBJFd2Ig6fWCLzTscXOQBAlvphpkOrnXo5ln4b/cl4H84JzNrDvAcVuVS04 +Uix/Q7yD7sCFQhfpMWtshsEx2thnVuroO11Ye12H7cLNnOIvo/FiPnsWG+SFQk1lwcV 3sEv24pAJMkGwqt9wGxdiFoeyMzMpupOtbBb0Qwy6pBrMiRdEymB2b2knQOYqGjPFgNr E8DdbgAlkZrQqmqjZM0uoeQipY4C5YPDXm6UBtDqPrSHvBMJ83dSMElz7Fa3vWk6st0c JwAJt9hDzH1Nn7gPakCOcQ/bsvw0Ub6O85EkbtxZ6rBTYCkWjaX1/1KiXp56WxWZO1bM bq/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EZEunsTnaA1XzE54VnUD0YcTvntYvxdVoZOW+fPpXuY=; b=piPRD2s2QfA5J5YZH9f95BLUzhVwceDnMe5jz8r5Y5Zd69uINlm5WuZIuoaYme38e0 pcXc2MEvADK6s4Jv/Z8dm7J1VsE2RLyrMFBQQKgUc/DaCj7V8CdFt2Vh8MRKsqwJko2O EwWBv8mEHrw/7ASwcgWQtML9jOblyZY8MHWyPlTp8y+FA/fkcLJJmQcXui/8JUvhDoLJ OWeeEmK9VaD0wkEg5M5jWH2yOVBSOdP9S+UdCcVyHDWM+wMfkFPJ4SEC4wcNBhqSCpwK DUGdt04W0CyVpnulef2oZq76JCRd4Y4G8aI3qs3HsZYUOOmN8Z9JWTe+3Qjnc41XKPed UG7g== X-Gm-Message-State: AOAM530A0V7L+8e5+0C152Yp0MT0RLu23i97Tcn95/Ld8E0PC/6gGN+H T1QmKnDYeZcZhXHj3FrdLIp3VA1p+/5LW0QibxU= X-Google-Smtp-Source: ABdhPJw01R3FsLE2EQNT7CIn9yocm0qu86fk/7OLpG7DKbhG2q6MJn/s0acJtp4DeG5ZfTa6LLUEBQbe0kohY2aFTRY= X-Received: by 2002:ac8:5b83:: with SMTP id a3mr5789733qta.210.1628189467046; Thu, 05 Aug 2021 11:51:07 -0700 (PDT) MIME-Version: 1.0 References: <20210805075401.21170-1-chihhao.chen@mediatek.com> In-Reply-To: <20210805075401.21170-1-chihhao.chen@mediatek.com> From: Geraldo Nascimento Date: Thu, 5 Aug 2021 15:50:58 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: chihhao chen Cc: alsa-devel@alsa-project.org, damien@zamaudio.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, tiwai@suse.com, Takashi Iwai , wsd_upstream@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210805_115109_036151_290947D8 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 5, 2021 at 7:54 AM wrote: > > From: chihhao chen > > Hi Geraldo Nascimento, Hi Chihhao Chen! > > For echo test, it means we use this earphone to receive and play sounds at the same time. > We found in this case serious noise problem happens. > That's what I understood initially, and only a little later I became afraid echo test was the name of the debugging technique you used :) Thanks for the clarification. > Log as follows with your patch > <6>[ 175.960387][T401365] __uac_clock_find_source: Clock Selector 0xc has pin 2 selected > <6>[ 175.966980][T401365] __uac_clock_find_source: Clock Selector 0xb has pin 2 selected > <6>[ 176.026251][T400354] __uac_clock_find_source: Clock Selector 0xc has pin 1 selected > <6>[ 176.032406][T400354] __uac_clock_find_source: Clock Selector 0xb has pin 1 selected > > There is no noise and I think this should be a firmware bug. >From the log I'm afraid my worst assumptions were right. Regardless of which Clock Selector we want to set, the firmware will always set them both. We should contact Samsung now that we have at least a sketch of a bug report... Thanks, Geraldo Nascimento > > Thanks > Chihhao > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel