From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A7DC4320A for ; Sat, 24 Jul 2021 18:21:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 554B760E92 for ; Sat, 24 Jul 2021 18:21:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbhGXRkZ (ORCPT ); Sat, 24 Jul 2021 13:40:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbhGXRkY (ORCPT ); Sat, 24 Jul 2021 13:40:24 -0400 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CC01C061575 for ; Sat, 24 Jul 2021 11:20:56 -0700 (PDT) Received: by mail-qv1-xf35.google.com with SMTP id cv7so2987355qvb.12 for ; Sat, 24 Jul 2021 11:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeMJR/oOT6vnUfEf1QGuRaqBtn1buVaEAa8SwfA3FM8=; b=ZgQiFzz0yfKej069imP4GcuB6HeHasV7gVLeT/CfcWN/DTJJg/Spjk6rqSuFDFhlT1 oVmOW7zBobMisHPGm2lJ6U2deTrWP2dVpcAnkBwrEckp1xEgEVLqrGzio/uH9L0FtJ5x YwuITmQmANyJv6cVc1xXEw2bnfEQi9ni8vCVJEQierUO67Va65eBkypz5yIlWnx/sRnj Rn1vhvhajRBLIKYV1ZblyUfw7X488U151n4vUehE3r4BY6PlShmmVWoqx8oKVthyfLw6 T5LvrGgwzMWi8l148NpGRoEnKkQskY2AUFedNhoTmCnP1WvfH1mAVmzhtgS6HRfQ60yb t50Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeMJR/oOT6vnUfEf1QGuRaqBtn1buVaEAa8SwfA3FM8=; b=QItpq/zKriiRu9VaVJT9hrVvuxEjt7RkBn69ZA3aOyGXrBpksTYlCTmPr+sY6efoKs zsazrE85TG5t8mRHmBQMkcopIYoSRFChn2uVzTLg15llBUEGqGAc+pT1CEoN6nSRH+ok BjSyMfonV1MSDK4zRpEbNxEG4Gcwn5+CTNds4qYVLNgmgjjniV0oYNs+kzzVvHrfQNkE l8rylH43hfA8g/eBHKjobI/nSbiO3S2de++K7R/Ig/0Bxd6ao6ISzf0qHL9IhIlr77KE UDUBFqwITFbQz51kd9g21LfXeCsIBo9lWr4xUVO2upIcaQWKKZB8PwScuqAzaZVKKX1U ASWg== X-Gm-Message-State: AOAM530IMz/KRKa7kfaCjzPYBeqcmfVET1eC7JLzqPvaRGj+b56Lq1h4 VsGLhbVS4duiKTbkuCcuwDn29c3MZ3fS9oDxc2M= X-Google-Smtp-Source: ABdhPJwue+Tzkl6UbAMvQoa11TWdFyaB3DBO04u2KVlOxPM50w9P2ankRPrOl20M6vwOqwo8EisbJUGjr8bJVz62/Qo= X-Received: by 2002:a0c:d68f:: with SMTP id k15mr10642939qvi.14.1627150855374; Sat, 24 Jul 2021 11:20:55 -0700 (PDT) MIME-Version: 1.0 References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> In-Reply-To: From: Geraldo Nascimento Date: Sat, 24 Jul 2021 15:20:47 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: Takashi Iwai Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Dr. Iwai, perhaps we could restrict the generalized fix for the > Behringer UFX1604 / UFX1204 with some simple logic to devices that > only have *one* clock source. Okay, rereading the original commit log from Cihhao Chen I gather Samsung USBC Headset (AKG) with VID/PID (0x04e8/0xa051) actually has two clock selectors and only one clock source. Correct me if I'm wrong. This is complicated by the fact I haven't been able to find a lsusb -v of Samsung USBC Headset (AKG) with VID/PID (0x04e8/0xa051) Even so, my proposition still stands: devices with only one clock source and only one clock selector should be able to handle us selecting the clock selector to the only clock source. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF34AC4338F for ; Sat, 24 Jul 2021 18:21:57 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 680D860EB0 for ; Sat, 24 Jul 2021 18:21:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 680D860EB0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5739D175D; Sat, 24 Jul 2021 20:21:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5739D175D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1627150914; bh=KeMJR/oOT6vnUfEf1QGuRaqBtn1buVaEAa8SwfA3FM8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GbJpiHagv/CeErxnKkl0RBrKip7NWi0DHxl/sbNMxNgrr0EvQuPqYMD5hwsGoaOq4 QbSh+ltynaUcvcNOt2hk+RnjPlsCWsucxa7K07y+AhK+LazFFgufQDOhC5a5htXMPU oIpuDcMeGzxnbIEL+6p/SZtF29mUsDNrnBc/36FA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EC769F80218; Sat, 24 Jul 2021 20:21:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3C65DF80227; Sat, 24 Jul 2021 20:21:02 +0200 (CEST) Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 57B98F80086 for ; Sat, 24 Jul 2021 20:20:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 57B98F80086 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZgQiFzz0" Received: by mail-qv1-xf36.google.com with SMTP id db14so2260469qvb.10 for ; Sat, 24 Jul 2021 11:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeMJR/oOT6vnUfEf1QGuRaqBtn1buVaEAa8SwfA3FM8=; b=ZgQiFzz0yfKej069imP4GcuB6HeHasV7gVLeT/CfcWN/DTJJg/Spjk6rqSuFDFhlT1 oVmOW7zBobMisHPGm2lJ6U2deTrWP2dVpcAnkBwrEckp1xEgEVLqrGzio/uH9L0FtJ5x YwuITmQmANyJv6cVc1xXEw2bnfEQi9ni8vCVJEQierUO67Va65eBkypz5yIlWnx/sRnj Rn1vhvhajRBLIKYV1ZblyUfw7X488U151n4vUehE3r4BY6PlShmmVWoqx8oKVthyfLw6 T5LvrGgwzMWi8l148NpGRoEnKkQskY2AUFedNhoTmCnP1WvfH1mAVmzhtgS6HRfQ60yb t50Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeMJR/oOT6vnUfEf1QGuRaqBtn1buVaEAa8SwfA3FM8=; b=LWO9PcK1ixha0Rd1FzDtSF0J3aFtPEN6fH00ADTJHgm2kWaGV16YCzNRVA5iBCCMbM tJBSbHsajQvKdnOMPtzF2Az41MP2dNkEKUTOq19SBP2R6Dlr1Wy9IUTRfPaJZuR4+oHR 7vhQzoi/Ci/wa5Q897XlmTjBriI/maggk115xw6cce00E56yAgF1M84OwivF6jiC0r4e iiU1y0irJe5rmJo67+vNzTfCofzrVVRP0bqrcJdb4AxxKN723EtUNxuIkdd3+j/UaYX/ CL+rFQGU+lgTEipjWpsfIUMszsI+9/l9v5jyiYf/90EpE7toGoJyEcYThuXMlpmlmAiO r4QA== X-Gm-Message-State: AOAM533+eSHG5YkeS+kmO5dcItQPkq2OjOhl2djL8tTOD0qe/dFyurRJ ojfxQ6RG5YYb8+ZfX1DLOVO3V/ZdU46Us+Rb9v4= X-Google-Smtp-Source: ABdhPJwue+Tzkl6UbAMvQoa11TWdFyaB3DBO04u2KVlOxPM50w9P2ankRPrOl20M6vwOqwo8EisbJUGjr8bJVz62/Qo= X-Received: by 2002:a0c:d68f:: with SMTP id k15mr10642939qvi.14.1627150855374; Sat, 24 Jul 2021 11:20:55 -0700 (PDT) MIME-Version: 1.0 References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> In-Reply-To: From: Geraldo Nascimento Date: Sat, 24 Jul 2021 15:20:47 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: Takashi Iwai Content-Type: text/plain; charset="UTF-8" Cc: alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, linux-kernel@vger.kernel.org, tiwai@suse.com, chihhao.chen@mediatek.com, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > Dr. Iwai, perhaps we could restrict the generalized fix for the > Behringer UFX1604 / UFX1204 with some simple logic to devices that > only have *one* clock source. Okay, rereading the original commit log from Cihhao Chen I gather Samsung USBC Headset (AKG) with VID/PID (0x04e8/0xa051) actually has two clock selectors and only one clock source. Correct me if I'm wrong. This is complicated by the fact I haven't been able to find a lsusb -v of Samsung USBC Headset (AKG) with VID/PID (0x04e8/0xa051) Even so, my proposition still stands: devices with only one clock source and only one clock selector should be able to handle us selecting the clock selector to the only clock source. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 402DFC4338F for ; Sat, 24 Jul 2021 18:21:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 087B060E92 for ; Sat, 24 Jul 2021 18:21:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 087B060E92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CU0UL30lRO6k9L4zqLAVBqoz06ir6OUBcbuR1zSKtV4=; b=s5qbhol2YSAVok lIOwcg5pol872z4tg1dYdhhFUijOmezXJa5qEAxw2KjxwwYkT9Vcfm3gsyI7oUy+RnnJj+DZzQFRP gqB/28OASW2Dv3EeHB0QiA5FC4qDeX7nRMVkunOyl00fel63XagQjG11KwIF7iNRo8yb9DsmfaUR2 ZR+iGlGADxdWZPPDBvseR5oddkmVLOD4y0vpafG5WcOcoHsPXaBuyn3kfX33pTjyW3Cxa5FLMr+LI 0BShka5zan/skgCLISbtCz6tVFY/KAnVeqzNb4SSLJZOHopL6VFtfBqDm1FiMi7+o29wzQaaM7IDj lMsDrPevDWTJ9vU3wzkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7MGi-007dOB-PI; Sat, 24 Jul 2021 18:21:00 +0000 Received: from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7MGf-007dNA-FH; Sat, 24 Jul 2021 18:20:58 +0000 Received: by mail-qv1-xf2f.google.com with SMTP id w6so3034176qvh.3; Sat, 24 Jul 2021 11:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeMJR/oOT6vnUfEf1QGuRaqBtn1buVaEAa8SwfA3FM8=; b=ZgQiFzz0yfKej069imP4GcuB6HeHasV7gVLeT/CfcWN/DTJJg/Spjk6rqSuFDFhlT1 oVmOW7zBobMisHPGm2lJ6U2deTrWP2dVpcAnkBwrEckp1xEgEVLqrGzio/uH9L0FtJ5x YwuITmQmANyJv6cVc1xXEw2bnfEQi9ni8vCVJEQierUO67Va65eBkypz5yIlWnx/sRnj Rn1vhvhajRBLIKYV1ZblyUfw7X488U151n4vUehE3r4BY6PlShmmVWoqx8oKVthyfLw6 T5LvrGgwzMWi8l148NpGRoEnKkQskY2AUFedNhoTmCnP1WvfH1mAVmzhtgS6HRfQ60yb t50Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeMJR/oOT6vnUfEf1QGuRaqBtn1buVaEAa8SwfA3FM8=; b=bZyLFUPQx6P1MDvlGLRqcPbURObBApHR/LMBor75oxhjaZCiwKa0iGlGmXfRWwvt/h FGF24hsBrSfNhvbicLkd1IiZf+l3Y0pXoe2eEE9ny2wHLwnWQ2rE21xunmg+Xt2ygrpR v8qdaAApuYJcUHTAoRbBWNUTgSAjECqExOiXHesIcfYwG9b9XNxhl7XEkOhiJf5kCHOQ A7352KMUlJoAAAx2a6Z6kGmA6SLnoXo+GHJgKYz9IEyCfBNyDY44v+j0CJiey1h2qiVh CIULF9l9mvwt9QSGTmbagtSQLFFZq+TawoRF4wK7USS/O1hmkyPNk+/wojpI+FmkSNAe gzDw== X-Gm-Message-State: AOAM533RSi2RKMqMJDM6vWet9HJweRVWsUKmPtA1Iq133ND7SqcAF34/ Igh9T3HNBne9tVPow8TUsczkltT85sKQWP/YhDw= X-Google-Smtp-Source: ABdhPJwue+Tzkl6UbAMvQoa11TWdFyaB3DBO04u2KVlOxPM50w9P2ankRPrOl20M6vwOqwo8EisbJUGjr8bJVz62/Qo= X-Received: by 2002:a0c:d68f:: with SMTP id k15mr10642939qvi.14.1627150855374; Sat, 24 Jul 2021 11:20:55 -0700 (PDT) MIME-Version: 1.0 References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> In-Reply-To: From: Geraldo Nascimento Date: Sat, 24 Jul 2021 15:20:47 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: Takashi Iwai Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210724_112057_572658_A9A68918 X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org > Dr. Iwai, perhaps we could restrict the generalized fix for the > Behringer UFX1604 / UFX1204 with some simple logic to devices that > only have *one* clock source. Okay, rereading the original commit log from Cihhao Chen I gather Samsung USBC Headset (AKG) with VID/PID (0x04e8/0xa051) actually has two clock selectors and only one clock source. Correct me if I'm wrong. This is complicated by the fact I haven't been able to find a lsusb -v of Samsung USBC Headset (AKG) with VID/PID (0x04e8/0xa051) Even so, my proposition still stands: devices with only one clock source and only one clock selector should be able to handle us selecting the clock selector to the only clock source. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F6A2C4338F for ; Sat, 24 Jul 2021 18:22:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC98160C51 for ; Sat, 24 Jul 2021 18:22:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DC98160C51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=37AjJCX0/MxwvUol3e5AFnYeX0C10M3TIO4LgeIxQeM=; b=AafJfwBdMzRqkx YiD5MgPiibl/Krnw07xI9GDRs6CtLh7fqYCsSsObEiqUH4GTHHoTfkx/ItJf4nKgWRchzdUqBojcB /HHt+UQbyllso3geK7QD+THZKzMDi/YE4JFkOTIeOh13+GM/t9vFOJkyiYdqjuyBJ98w/vTCpRwKw x6GSH35wMtG1frE1y8AUJ+pAVsgN8d3e5P47zKUCDwI99oGzfTz/2BIpLZD08SwpUtnBSMLdGu0bf dFW2amagScG9h+CvOkcgDT6IdpLjHSlYLMNkw7QaSdCYYyn+Qo/5+JgiC4lgLxf0gEz27B5zlGkzT jrXKAxAKJmh8TeUNYHDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7MGl-007dOV-0S; Sat, 24 Jul 2021 18:21:03 +0000 Received: from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7MGf-007dNA-FH; Sat, 24 Jul 2021 18:20:58 +0000 Received: by mail-qv1-xf2f.google.com with SMTP id w6so3034176qvh.3; Sat, 24 Jul 2021 11:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeMJR/oOT6vnUfEf1QGuRaqBtn1buVaEAa8SwfA3FM8=; b=ZgQiFzz0yfKej069imP4GcuB6HeHasV7gVLeT/CfcWN/DTJJg/Spjk6rqSuFDFhlT1 oVmOW7zBobMisHPGm2lJ6U2deTrWP2dVpcAnkBwrEckp1xEgEVLqrGzio/uH9L0FtJ5x YwuITmQmANyJv6cVc1xXEw2bnfEQi9ni8vCVJEQierUO67Va65eBkypz5yIlWnx/sRnj Rn1vhvhajRBLIKYV1ZblyUfw7X488U151n4vUehE3r4BY6PlShmmVWoqx8oKVthyfLw6 T5LvrGgwzMWi8l148NpGRoEnKkQskY2AUFedNhoTmCnP1WvfH1mAVmzhtgS6HRfQ60yb t50Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeMJR/oOT6vnUfEf1QGuRaqBtn1buVaEAa8SwfA3FM8=; b=bZyLFUPQx6P1MDvlGLRqcPbURObBApHR/LMBor75oxhjaZCiwKa0iGlGmXfRWwvt/h FGF24hsBrSfNhvbicLkd1IiZf+l3Y0pXoe2eEE9ny2wHLwnWQ2rE21xunmg+Xt2ygrpR v8qdaAApuYJcUHTAoRbBWNUTgSAjECqExOiXHesIcfYwG9b9XNxhl7XEkOhiJf5kCHOQ A7352KMUlJoAAAx2a6Z6kGmA6SLnoXo+GHJgKYz9IEyCfBNyDY44v+j0CJiey1h2qiVh CIULF9l9mvwt9QSGTmbagtSQLFFZq+TawoRF4wK7USS/O1hmkyPNk+/wojpI+FmkSNAe gzDw== X-Gm-Message-State: AOAM533RSi2RKMqMJDM6vWet9HJweRVWsUKmPtA1Iq133ND7SqcAF34/ Igh9T3HNBne9tVPow8TUsczkltT85sKQWP/YhDw= X-Google-Smtp-Source: ABdhPJwue+Tzkl6UbAMvQoa11TWdFyaB3DBO04u2KVlOxPM50w9P2ankRPrOl20M6vwOqwo8EisbJUGjr8bJVz62/Qo= X-Received: by 2002:a0c:d68f:: with SMTP id k15mr10642939qvi.14.1627150855374; Sat, 24 Jul 2021 11:20:55 -0700 (PDT) MIME-Version: 1.0 References: <1627100621-19225-1-git-send-email-chihhao.chen@mediatek.com> In-Reply-To: From: Geraldo Nascimento Date: Sat, 24 Jul 2021 15:20:47 +0000 Message-ID: Subject: Re: [PATCH] ALSA: usb-audio: fix incorrect clock source setting To: Takashi Iwai Cc: chihhao.chen@mediatek.com, alsa-devel@alsa-project.org, wsd_upstream@mediatek.com, damien@zamaudio.com, tiwai@suse.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210724_112057_572658_A9A68918 X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Dr. Iwai, perhaps we could restrict the generalized fix for the > Behringer UFX1604 / UFX1204 with some simple logic to devices that > only have *one* clock source. Okay, rereading the original commit log from Cihhao Chen I gather Samsung USBC Headset (AKG) with VID/PID (0x04e8/0xa051) actually has two clock selectors and only one clock source. Correct me if I'm wrong. This is complicated by the fact I haven't been able to find a lsusb -v of Samsung USBC Headset (AKG) with VID/PID (0x04e8/0xa051) Even so, my proposition still stands: devices with only one clock source and only one clock selector should be able to handle us selecting the clock selector to the only clock source. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel