From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A1AC433DB for ; Thu, 21 Jan 2021 06:22:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27B802064B for ; Thu, 21 Jan 2021 06:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27B802064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F9516E8D9; Thu, 21 Jan 2021 06:22:38 +0000 (UTC) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFA5E6E8D8; Thu, 21 Jan 2021 06:22:36 +0000 (UTC) Received: by mail-ej1-x62b.google.com with SMTP id kg20so530546ejc.4; Wed, 20 Jan 2021 22:22:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GW/oWN3oyD3njowlslhBX+P2nkMm3yPnHl9TOZ+Je2s=; b=vJgQFLlN27pu0HqdfQKoxyc/5F80Fo1UnauZgGw82RIjbaqcnj4fGj/XFUsgJrq9CU 1IOtdX+THR0BWsPmrTiwJxx/brIqgmWH3rQpEgOwCEDLVs7rv51XUuVkqR2HMot1sIHV /9X2SK8Js14THdDobqZjp8evE5F/5YH9O46U0saaaeLWvL1m8DsHOuxbcEhR3lCKYL92 d7HxQDVisi7Pvi6DT8nfHvMpbs8hZ+fhheK6vd76/UgNVZ3PeYstZKenscMKyIhaMlwx fv5PtFEHuqDKHSIOi5Jenvkg8Bi79oztPTcZ0usY/NWVeF1VhyFcx/uJPXQN5kCavFHo wGIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GW/oWN3oyD3njowlslhBX+P2nkMm3yPnHl9TOZ+Je2s=; b=ocWLJD2j9iXeBYt3zSyYZq71gtuIptv1SWFxvcxc8YzA3Sw0QqaJSsZ0w9QOsnVg4I cW37s7Sl6Nwa6V+fhqYjuJjqxHJNtzrVLfNby/fsOHzx0/P1nvnBGa07QWJWic/4NoaL xi/UqUwBQQxxiyGf22I9h9jrQ0OA8FjWAX3shQTm1dt4tKILUadsCiQ/PAupENmOSBsk rj+tH/iTb6DP042IIOInsEiTliajlttW+VVkZt4WQ3XHM82XeyPeNtro5NIzsYVkK0dZ IYbugS4aye3jQCqn17gz2iceI2HTI9Skl/AAy+FeAgsSxJs+z2o3BRG1lFwnLhGGZvmZ zn8g== X-Gm-Message-State: AOAM530SirErsyp9s3hGAJsLPdBBt7PmWi9qqwZWF6xrX2/hJOQuOX7F mUtfNy8QqA5sRkebiSZJgifIenetOhftC/ad0Ik= X-Google-Smtp-Source: ABdhPJy5/0LBceTsjModKTDeluMXbpU1rmpDtJXeV6VP7azlkKLQbc2DmDNuMGCZ1+yd9dpc7GGdhx+RrLj4uZWNOjw= X-Received: by 2002:a17:906:5958:: with SMTP id g24mr8032373ejr.377.1611210155701; Wed, 20 Jan 2021 22:22:35 -0800 (PST) MIME-Version: 1.0 References: <20201228185059.3949-1-mario.kleiner.de@gmail.com> In-Reply-To: From: Mario Kleiner Date: Thu, 21 Jan 2021 07:22:24 +0100 Message-ID: Subject: Re: Enable fp16 display support for DCE8+, next try. To: Alex Deucher X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Deucher, Alexander" , amd-gfx list , Maling list - DRI developers , "Kazlauskas, Nicholas" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jan 4, 2021 at 6:16 PM Alex Deucher wrote: > > On Mon, Dec 28, 2020 at 1:51 PM Mario Kleiner > wrote: > > > > Hi and happy post-christmas! > > > > I wrote a patch 1/1 that now checks plane scaling factors against > > the pixel-format specific limits in the asic specific dc_plane_cap > > structures during atomic check and other appropriate places. > > > > This should prevent things like asking for scaling on fp16 framebuffers > > if the hw can't do that. Hopefully this will now allow to safely enable > > fp16 scanout also on older asic's like DCE-11.0, DCE-10 and DCE-8. > > Patch 2/2 enables those DCE's now for fp16. > > > > I used some quickly hacked up of IGT test kms_plane_scaling, manually > > hacking the src fb size to make sure the patch correctly accepts or > > rejects atomic commits based on allowable scaling factors for rgbx/a > > 8 bit, 10, and fp16. > > > > This fp16 support has been successfully tested with a Sea Islands / > > DCE-8 laptop. I also confirmed that at least basic HDR signalling > > over HDMI works for that DCE-8 machine with a HDR monitor. For this > > i used the amdvlk driver which exposes fp16 since a while on supported > > hw. > > Patches look good to me, but I'd like to get some feedback from the > display folks as well. > > > > > There are other bugs in DC wrt. DCE-8 though, which didn't prevent > > my testing, but may be worth looking into. My DCE-8 machine scrambles > > the video output picture somewhat under Vulkan (radv and admvlk) if the > > output signal precision isn't 8 bpc, ie. on 6 bpc (eDP laptop panel) > > and 10 bpc, 12 bpc (HDMI deep color on external HDR monitor). > > > > Another fun thing is getting a black screen if DC is enabled on at least > > Linux 5.10+ (but not if i use the classic kms code in amdgpu-kms). If > > i recompile the driver with a Ubuntu kconfig for Linux 5.9, the 5.10 > > kernel works, and the only obvious DC related difference is that DC's > > new SI / DCE-6 asic support is disabled at compile time. > > Fixed here: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6bdeff12a96c9a5da95c8d11fefd145eb165e32a > Patch should be in stable for 5.10 as well. Yes, in recent 5.10 stable these fix the problem I experienced. Thanks Alex, -mario > > Alex _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B4CEC433E0 for ; Thu, 21 Jan 2021 06:22:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01D342064B for ; Thu, 21 Jan 2021 06:22:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01D342064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 65F496E8D8; Thu, 21 Jan 2021 06:22:38 +0000 (UTC) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by gabe.freedesktop.org (Postfix) with ESMTPS id EFA5E6E8D8; Thu, 21 Jan 2021 06:22:36 +0000 (UTC) Received: by mail-ej1-x62b.google.com with SMTP id kg20so530546ejc.4; Wed, 20 Jan 2021 22:22:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GW/oWN3oyD3njowlslhBX+P2nkMm3yPnHl9TOZ+Je2s=; b=vJgQFLlN27pu0HqdfQKoxyc/5F80Fo1UnauZgGw82RIjbaqcnj4fGj/XFUsgJrq9CU 1IOtdX+THR0BWsPmrTiwJxx/brIqgmWH3rQpEgOwCEDLVs7rv51XUuVkqR2HMot1sIHV /9X2SK8Js14THdDobqZjp8evE5F/5YH9O46U0saaaeLWvL1m8DsHOuxbcEhR3lCKYL92 d7HxQDVisi7Pvi6DT8nfHvMpbs8hZ+fhheK6vd76/UgNVZ3PeYstZKenscMKyIhaMlwx fv5PtFEHuqDKHSIOi5Jenvkg8Bi79oztPTcZ0usY/NWVeF1VhyFcx/uJPXQN5kCavFHo wGIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GW/oWN3oyD3njowlslhBX+P2nkMm3yPnHl9TOZ+Je2s=; b=ocWLJD2j9iXeBYt3zSyYZq71gtuIptv1SWFxvcxc8YzA3Sw0QqaJSsZ0w9QOsnVg4I cW37s7Sl6Nwa6V+fhqYjuJjqxHJNtzrVLfNby/fsOHzx0/P1nvnBGa07QWJWic/4NoaL xi/UqUwBQQxxiyGf22I9h9jrQ0OA8FjWAX3shQTm1dt4tKILUadsCiQ/PAupENmOSBsk rj+tH/iTb6DP042IIOInsEiTliajlttW+VVkZt4WQ3XHM82XeyPeNtro5NIzsYVkK0dZ IYbugS4aye3jQCqn17gz2iceI2HTI9Skl/AAy+FeAgsSxJs+z2o3BRG1lFwnLhGGZvmZ zn8g== X-Gm-Message-State: AOAM530SirErsyp9s3hGAJsLPdBBt7PmWi9qqwZWF6xrX2/hJOQuOX7F mUtfNy8QqA5sRkebiSZJgifIenetOhftC/ad0Ik= X-Google-Smtp-Source: ABdhPJy5/0LBceTsjModKTDeluMXbpU1rmpDtJXeV6VP7azlkKLQbc2DmDNuMGCZ1+yd9dpc7GGdhx+RrLj4uZWNOjw= X-Received: by 2002:a17:906:5958:: with SMTP id g24mr8032373ejr.377.1611210155701; Wed, 20 Jan 2021 22:22:35 -0800 (PST) MIME-Version: 1.0 References: <20201228185059.3949-1-mario.kleiner.de@gmail.com> In-Reply-To: From: Mario Kleiner Date: Thu, 21 Jan 2021 07:22:24 +0100 Message-ID: Subject: Re: Enable fp16 display support for DCE8+, next try. To: Alex Deucher X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Deucher, Alexander" , amd-gfx list , Maling list - DRI developers , "Kazlauskas, Nicholas" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Jan 4, 2021 at 6:16 PM Alex Deucher wrote: > > On Mon, Dec 28, 2020 at 1:51 PM Mario Kleiner > wrote: > > > > Hi and happy post-christmas! > > > > I wrote a patch 1/1 that now checks plane scaling factors against > > the pixel-format specific limits in the asic specific dc_plane_cap > > structures during atomic check and other appropriate places. > > > > This should prevent things like asking for scaling on fp16 framebuffers > > if the hw can't do that. Hopefully this will now allow to safely enable > > fp16 scanout also on older asic's like DCE-11.0, DCE-10 and DCE-8. > > Patch 2/2 enables those DCE's now for fp16. > > > > I used some quickly hacked up of IGT test kms_plane_scaling, manually > > hacking the src fb size to make sure the patch correctly accepts or > > rejects atomic commits based on allowable scaling factors for rgbx/a > > 8 bit, 10, and fp16. > > > > This fp16 support has been successfully tested with a Sea Islands / > > DCE-8 laptop. I also confirmed that at least basic HDR signalling > > over HDMI works for that DCE-8 machine with a HDR monitor. For this > > i used the amdvlk driver which exposes fp16 since a while on supported > > hw. > > Patches look good to me, but I'd like to get some feedback from the > display folks as well. > > > > > There are other bugs in DC wrt. DCE-8 though, which didn't prevent > > my testing, but may be worth looking into. My DCE-8 machine scrambles > > the video output picture somewhat under Vulkan (radv and admvlk) if the > > output signal precision isn't 8 bpc, ie. on 6 bpc (eDP laptop panel) > > and 10 bpc, 12 bpc (HDMI deep color on external HDR monitor). > > > > Another fun thing is getting a black screen if DC is enabled on at least > > Linux 5.10+ (but not if i use the classic kms code in amdgpu-kms). If > > i recompile the driver with a Ubuntu kconfig for Linux 5.9, the 5.10 > > kernel works, and the only obvious DC related difference is that DC's > > new SI / DCE-6 asic support is disabled at compile time. > > Fixed here: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6bdeff12a96c9a5da95c8d11fefd145eb165e32a > Patch should be in stable for 5.10 as well. Yes, in recent 5.10 stable these fix the problem I experienced. Thanks Alex, -mario > > Alex _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx