From: Teck Choon Giam <giamteckchoon@gmail.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
roger.pau@citrix.com, M A Young <m.a.young@durham.ac.uk>
Subject: Re: [patch] xen udev rule interfering with openvpn
Date: Thu, 19 Apr 2012 02:25:34 +0800 [thread overview]
Message-ID: <CAEwRVpP47=mKrcZ_5ATZga4wvkMaSysPh-BEfRorcxrCJ7W6pg@mail.gmail.com> (raw)
In-Reply-To: <1334658395.23948.6.camel@zakaz.uk.xensource.com>
SNAP
> +++ b/tools/libxl/libxl_dm.c Tue Apr 17 11:26:06 2012 +0100
> @@ -212,9 +212,9 @@ static char ** libxl__build_device_model
> char *ifname;
> if (!vifs[i].ifname)
> ifname = libxl__sprintf(gc,
> - "tap%d.%d", domid, vifs[i].devid);
> + "xentap%d.%d", domid, vifs[i].devid);
> else
> - ifname = vifs[i].ifname;
> + ifname = libxl__sprintf(gc, "xentap-%s", vifs[i].ifname);
To my understanding, you set ifname to prefix xentap instead of tap
for type LIBXL_NIC_TYPE_IOEMU which is for hvmdomain. So please read
my comments below related to tools/python/xen/xend/image.py
> flexarray_vappend(dm_args,
> "-net", libxl__sprintf(gc, "nic,vlan=%d,macaddr=%s,model=%s",
> vifs[i].devid, smac, vifs[i].model),
> @@ -451,10 +451,10 @@ static char ** libxl__build_device_model
> LIBXL_MAC_FMT, LIBXL_MAC_BYTES(vifs[i].mac));
> char *ifname;
> if (!vifs[i].ifname) {
> - ifname = libxl__sprintf(gc, "tap%d.%d",
> + ifname = libxl__sprintf(gc, "xentap%d.%d",
> guest_domid, vifs[i].devid);
> } else {
> - ifname = vifs[i].ifname;
> + ifname = libxl__sprintf(gc, "xentap-%s", vifs[i].ifname);
> }
> flexarray_append(dm_args, "-device");
> flexarray_append(dm_args,
> diff -r 8d92d1f34921 -r de3e65d804cc tools/python/xen/xend/image.py
> --- a/tools/python/xen/xend/image.py Mon Apr 16 17:57:00 2012 +0100
> +++ b/tools/python/xen/xend/image.py Tue Apr 17 11:26:06 2012 +0100
> @@ -921,7 +921,7 @@ class HVMImageHandler(ImageHandler):
> if vifname:
> vifname = "tap-" + vifname
The above shouldn't it be:
vifname = "xentap-" + vifname
For your libxl related is:
ifname = libxl__sprintf(gc, "xentap-%s", vifs[i].ifname);
Sorry if my thinking is wrong please correct me.
Thanks.
Kindest regards,
Giam Teck Choon
> else:
> - vifname = "tap%d.%d" % (self.vm.getDomid(), nics-1)
> + vifname = "xentap%d.%d" % (self.vm.getDomid(), nics-1)
> ret.append("-net")
> ret.append("tap,vlan=%d,ifname=%s,bridge=%s" %
> (nics, vifname, bridge))
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-04-18 18:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 19:03 [patch] xen udev rule interfering with openvpn M A Young
2012-04-17 10:26 ` Ian Campbell
2012-04-17 13:08 ` Roger Pau Monne
2012-04-18 18:25 ` Teck Choon Giam [this message]
2012-04-19 6:39 ` Ian Campbell
2012-04-20 9:03 ` Ian Campbell
2012-04-20 10:38 ` Ian Jackson
2012-04-20 10:48 ` Ian Campbell
2012-04-20 10:55 ` Ian Jackson
2012-04-20 11:00 ` Ian Campbell
2012-04-20 11:04 ` Ian Jackson
2012-04-20 13:21 ` Ian Campbell
2012-04-20 15:26 ` Teck Choon Giam
2012-04-20 15:38 ` Ian Campbell
2012-04-20 16:34 ` Teck Choon Giam
2012-04-25 9:59 ` Ian Campbell
2012-04-25 10:11 ` Ian Jackson
2012-04-25 10:14 ` Ian Campbell
2012-04-25 12:58 ` Ian Campbell
2012-04-25 13:16 ` Roger Pau Monne
2012-04-25 13:38 ` Ian Campbell
2012-05-11 14:53 ` Ian Jackson
2012-05-11 23:53 ` Teck Choon Giam
2012-05-12 7:29 ` Teck Choon Giam
2012-05-12 22:00 ` Teck Choon Giam
2012-05-12 22:30 ` Ian Campbell
2012-05-12 23:37 ` Teck Choon Giam
2012-05-13 0:39 ` Teck Choon Giam
2012-05-21 12:31 ` Ian Campbell
2012-05-21 12:51 ` Teck Choon Giam
2012-05-21 13:04 ` Ian Campbell
2012-05-21 13:16 ` Teck Choon Giam
2012-05-22 13:19 ` Ian Campbell
2012-05-23 2:22 ` Teck Choon Giam
2012-05-23 9:37 ` Ian Campbell
2012-05-23 13:04 ` Teck Choon Giam
2012-05-23 14:54 ` Teck Choon Giam
2012-05-21 12:24 ` Teck Choon Giam
2012-05-21 12:49 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEwRVpP47=mKrcZ_5ATZga4wvkMaSysPh-BEfRorcxrCJ7W6pg@mail.gmail.com' \
--to=giamteckchoon@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=m.a.young@durham.ac.uk \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.