All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Christopher Li <sparse@chrisli.org>,
	Sparse Mailing-list <linux-sparse@vger.kernel.org>
Subject: Re: extra 'make check' failures on 32bit Linux
Date: Mon, 27 Mar 2017 18:10:26 +0200	[thread overview]
Message-ID: <CAExDi1TwkQj4JcmxqLkG868H2QDEr87=xYHKH0sMY=AXjrEb4A@mail.gmail.com> (raw)
In-Reply-To: <444abf20-b5ef-664a-fed4-ebfd8969e1da@ramsayjones.plus.com>

On Mon, Mar 27, 2017 at 5:27 PM, Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:

> So, I looked in the debugger and 'bits_in_long' and 'bits_in_pointer'
> are set correctly, but __LONG_MAX__ is being printed with an LL suffix,
> so, this fixes it for me:
>
> $ git diff
> diff --git a/lib.c b/lib.c
> index 272d2c8..502c264 100644
> --- a/lib.c
> +++ b/lib.c
> @@ -834,7 +834,7 @@ static void predefined_macros(void)
>         add_pre_buffer("#define __CHECKER__ 1\n");
>
>         val = (1ULL << (bits_in_long-1)) - 1;
> -       add_pre_buffer("#weak_define __LONG_MAX__ %#llxLL\n", val);
> +       add_pre_buffer("#weak_define __LONG_MAX__ %#llxL\n", val);
>         add_pre_buffer("#weak_define __SIZEOF_POINTER__ %d\n", bits_in_pointer/8);
>  }
>
> $
>
> Not a proper fix, but ...

Well, actually it is the proper fix as __LONG_MAX__ is supposed to be
a 'long' and not a 'long long'.

> Ah, I've just noticed you have sent some patches. ;-)
>
> I will take a look and let you know.

OK, thanks.
It should be OK as I new tested it on a 32bit machine but
another environment is always good for testing.

-- Luc

  reply	other threads:[~2017-03-27 16:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-26 22:21 extra 'make check' failures on 32bit Linux Ramsay Jones
2017-03-26 23:56 ` Luc Van Oostenryck
2017-03-27  1:03 ` Luc Van Oostenryck
2017-03-27 15:27   ` Ramsay Jones
2017-03-27 16:10     ` Luc Van Oostenryck [this message]
2017-03-27 16:53       ` Ramsay Jones
2017-03-27 17:15         ` Luc Van Oostenryck
2017-03-27  7:51 ` Christopher Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAExDi1TwkQj4JcmxqLkG868H2QDEr87=xYHKH0sMY=AXjrEb4A@mail.gmail.com' \
    --to=luc.vanoostenryck@gmail.com \
    --cc=linux-sparse@vger.kernel.org \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=sparse@chrisli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.