All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Thiery <heiko.thiery@gmail.com>
To: Michael Walle <michael@walle.cc>
Cc: "Frieder Schrempf" <frieder.schrempf@kontron.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Joakim Zhang" <qiangqing.zhang@nxp.com>,
	"Shengjiu Wang" <shengjiu.wang@nxp.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Angus Ainslie (Purism)" <angus@akkea.ca>
Subject: Re: [PATCH] arm64: dts: imx8mm-kontron-n801x-som: do not allow to switch off buck2
Date: Fri, 17 Sep 2021 10:51:49 +0200	[thread overview]
Message-ID: <CAEyMn7Z9wRZWpWD3krx=3Zgc-9H0Y6eWjDpOhbO-v2yXuRcGXg@mail.gmail.com> (raw)
In-Reply-To: <3EDFF987-82C2-4B0A-9488-037D1BD4CA48@walle.cc>

HI Michael,

Am Fr., 17. Sept. 2021 um 10:21 Uhr schrieb Michael Walle <michael@walle.cc>:
>
> Am 17. September 2021 09:28:51 MESZ schrieb Heiko Thiery <heiko.thiery@gmail.com>:
> >Hi Frieder,
> >
> >Am Mi., 15. Sept. 2021 um 14:09 Uhr schrieb Frieder Schrempf
> ><frieder.schrempf@kontron.de>:
> >>
> >> On 15.09.21 14:05, Michael Walle wrote:
> >> > Am 2021-09-15 14:03, schrieb Heiko Thiery:
> >> >> The buck2 output of the PMIC is the VDD core voltage of the cpu.
> >> >> Switching off this will poweroff the CPU. Add the 'regulator-always-on'
> >> >> property to avoid this.
> >> >
> >> > Mh, have this ever worked? Is there a commit which introduced a regression?
> >>
> >> Yes, this did work before, even without 'regulator-always-on'. I
> >> currently don't understand why this is needed. The regulator is
> >> referenced in the CPU nodes as 'cpu-supply'. This should be enough to
> >> not disable it as long as the CPU is up.
> >
> >I rechecked that with 5.11, 5.10 and 5.9 and I see on all of them the
> >same issue:
> >
> >[ 31.716031] vdd-5v: disabling
> >[ 31.719032] rst-usb-eth2: disabling
> >[ 31.722553] buck2: disabling
> >
> >While on that I tried to compare with other boards and see that they
> >also have the cpu-voltage marked as "regulator-always-on". The only
> >exception in dts/freescale is in imx8mq-librem5-devkit.dts [1] that
> >has not set this property.
> >
> >I agree with you and don't understand why this is happening. Has
> >anyone else an explanation?
>
> Do you have the CPU frequency scaling driver enabled?

That was a good hint. What I now see is in my case the driver is not
loaded (I boot via network). In the default kernel config the module
is marked as 'm'. When switching to 'y' as expected it will be probed
and the the buck2 (cpu-supply) will not be deactivated after 30
seconds.

-- 
Heiko

WARNING: multiple messages have this Message-ID
From: Heiko Thiery <heiko.thiery@gmail.com>
To: Michael Walle <michael@walle.cc>
Cc: "Frieder Schrempf" <frieder.schrempf@kontron.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Joakim Zhang" <qiangqing.zhang@nxp.com>,
	"Shengjiu Wang" <shengjiu.wang@nxp.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Guido Günther" <agx@sigxcpu.org>,
	"Angus Ainslie (Purism)" <angus@akkea.ca>
Subject: Re: [PATCH] arm64: dts: imx8mm-kontron-n801x-som: do not allow to switch off buck2
Date: Fri, 17 Sep 2021 10:51:49 +0200	[thread overview]
Message-ID: <CAEyMn7Z9wRZWpWD3krx=3Zgc-9H0Y6eWjDpOhbO-v2yXuRcGXg@mail.gmail.com> (raw)
In-Reply-To: <3EDFF987-82C2-4B0A-9488-037D1BD4CA48@walle.cc>

HI Michael,

Am Fr., 17. Sept. 2021 um 10:21 Uhr schrieb Michael Walle <michael@walle.cc>:
>
> Am 17. September 2021 09:28:51 MESZ schrieb Heiko Thiery <heiko.thiery@gmail.com>:
> >Hi Frieder,
> >
> >Am Mi., 15. Sept. 2021 um 14:09 Uhr schrieb Frieder Schrempf
> ><frieder.schrempf@kontron.de>:
> >>
> >> On 15.09.21 14:05, Michael Walle wrote:
> >> > Am 2021-09-15 14:03, schrieb Heiko Thiery:
> >> >> The buck2 output of the PMIC is the VDD core voltage of the cpu.
> >> >> Switching off this will poweroff the CPU. Add the 'regulator-always-on'
> >> >> property to avoid this.
> >> >
> >> > Mh, have this ever worked? Is there a commit which introduced a regression?
> >>
> >> Yes, this did work before, even without 'regulator-always-on'. I
> >> currently don't understand why this is needed. The regulator is
> >> referenced in the CPU nodes as 'cpu-supply'. This should be enough to
> >> not disable it as long as the CPU is up.
> >
> >I rechecked that with 5.11, 5.10 and 5.9 and I see on all of them the
> >same issue:
> >
> >[ 31.716031] vdd-5v: disabling
> >[ 31.719032] rst-usb-eth2: disabling
> >[ 31.722553] buck2: disabling
> >
> >While on that I tried to compare with other boards and see that they
> >also have the cpu-voltage marked as "regulator-always-on". The only
> >exception in dts/freescale is in imx8mq-librem5-devkit.dts [1] that
> >has not set this property.
> >
> >I agree with you and don't understand why this is happening. Has
> >anyone else an explanation?
>
> Do you have the CPU frequency scaling driver enabled?

That was a good hint. What I now see is in my case the driver is not
loaded (I boot via network). In the default kernel config the module
is marked as 'm'. When switching to 'y' as expected it will be probed
and the the buck2 (cpu-supply) will not be deactivated after 30
seconds.

-- 
Heiko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-17  8:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 12:03 Heiko Thiery
2021-09-15 12:03 ` Heiko Thiery
2021-09-15 12:05 ` Michael Walle
2021-09-15 12:05   ` Michael Walle
2021-09-15 12:09   ` Frieder Schrempf
2021-09-15 12:09     ` Frieder Schrempf
2021-09-17  7:28     ` Heiko Thiery
2021-09-17  7:28       ` Heiko Thiery
2021-09-17  8:21       ` Michael Walle
2021-09-17  8:21         ` Michael Walle
2021-09-17  8:51         ` Heiko Thiery [this message]
2021-09-17  8:51           ` Heiko Thiery
2021-09-17 11:44       ` Lucas Stach
2021-09-17 11:44         ` Lucas Stach
2021-09-17 16:10         ` Heiko Thiery
2021-09-17 16:10           ` Heiko Thiery
2021-09-20  7:31           ` Frieder Schrempf
2021-09-20  7:31             ` Frieder Schrempf
2021-09-20  7:43             ` Michael Walle
2021-09-20  7:43               ` Michael Walle
2021-09-20  8:10               ` Lucas Stach
2021-09-20  8:10                 ` Lucas Stach
2021-10-04 12:39 ` Shawn Guo
2021-10-04 12:39   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEyMn7Z9wRZWpWD3krx=3Zgc-9H0Y6eWjDpOhbO-v2yXuRcGXg@mail.gmail.com' \
    --to=heiko.thiery@gmail.com \
    --cc=agx@sigxcpu.org \
    --cc=angus@akkea.ca \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=qiangqing.zhang@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@nxp.com \
    --subject='Re: [PATCH] arm64: dts: imx8mm-kontron-n801x-som: do not allow to switch off buck2' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.