From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23417C433F5 for ; Thu, 11 Nov 2021 17:25:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AB4C61268 for ; Thu, 11 Nov 2021 17:25:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8AB4C61268 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2C79B835C2; Thu, 11 Nov 2021 18:25:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RhrhTH/G"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B489482B68; Thu, 11 Nov 2021 18:25:16 +0100 (CET) Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5EE8E83A08 for ; Thu, 11 Nov 2021 18:25:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heiko.thiery@gmail.com Received: by mail-lj1-x235.google.com with SMTP id t11so13328090ljh.6 for ; Thu, 11 Nov 2021 09:25:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QYLXjB3n4nGGqFHMSGIFQYT2J26jI+MvD2AwPiWv52o=; b=RhrhTH/G3VZ4z46d1JZiH7r6xUUmhkFQFgiJv9MiDzoZDzrUDUL6Zy8UwJEKmsdzoR 3HIUtNcpjp1cEXxy19hseROq/QC07cGERHTRLtnmQ35NJJJBpFU2ez9lfaMAIcLS6MB0 nAp4EiXfbomc9xZXGLIJ0VLHW6NBMd9OTPqzTCE3fT2YcepMP5a5fo+5Omb/CWAdW69q KL3OWKOHHGvis54d7BzJ9fANGV/KBU/Xv0asIPNL605Axw1p8E4/tvoai9yNHbORvbIO csn+Y2b+mRjUI2UP8d+8LMbSYVw25THRn7EAUAT3afGLVLYOAmhCG6i54n+cljILr4SB fU4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QYLXjB3n4nGGqFHMSGIFQYT2J26jI+MvD2AwPiWv52o=; b=18tnQqiIf1hmnltlRtQyaPxTtexgAw5OXlohDoMFoip2e2oB6YaMW4sbWjDx0uXgEP E6k9V/8D1KRXO+Txh4LxIXEF2JqoNi3DVOy92dOAHtPa39mlnpsHpZ0nMNE6i0JgOl4u OMXNG9eu3unuPdh0auSYf94vHA8jLAAS+tOL0aiz828S4T2uRUSF/uav4y1N9lSN6SAh o6u/ureIuhObpnPb9BQi474gnTYel1Trnc4iZh5AcN4jnFDtCO+Zmoms7p4WXSrlitEp hxSuDVfocxgr4Xfzhe0wGhNRKRgbCLLqzggVjmf8+DQ+JsLs+sjetd8EuAaccPzaJrPx 3pcQ== X-Gm-Message-State: AOAM533wBi80Lj/QOlQycYr5GXNqk6zo+jGSIDYK/irLSLo0l8wNT1Cv 2vF5xmcigcdVi/YtJ4+E9qk3a0hhTYHr+Zti9vQYqStuDrw= X-Google-Smtp-Source: ABdhPJxIukUx2diHRMAx3DHfHRDJ7ba99C2AdZUkUodrhArcTJeI64F27kohn8O1lEP+FnxzdIYDXDwOHtoGqn3anZo= X-Received: by 2002:a2e:b88c:: with SMTP id r12mr5387260ljp.294.1636651510668; Thu, 11 Nov 2021 09:25:10 -0800 (PST) MIME-Version: 1.0 References: <20211022024220.23584-1-peng.fan@oss.nxp.com> <20211022024220.23584-2-peng.fan@oss.nxp.com> In-Reply-To: <20211022024220.23584-2-peng.fan@oss.nxp.com> From: Heiko Thiery Date: Thu, 11 Nov 2021 18:24:59 +0100 Message-ID: Subject: Re: [PATCH V3 1/5] imx: imx8mq_evk: switch to binman To: "Peng Fan (OSS)" Cc: sbabic@denx.de, festevam@gmail.com, u-boot@lists.denx.de, uboot-imx@nxp.com, Peng Fan Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Peng, Am Fr., 22. Okt. 2021 um 04:07 Uhr schrieb Peng Fan (OSS) : > > From: Peng Fan > > Switch to use binman to pack images After switching to binman you will hit the same issue I have in the u-boot CI. The mkimage step will fail because the hdmi firmware blob can not be found [1]. There is already a discuusion ongoing how to fix that [2]. [1] https://lists.denx.de/pipermail/u-boot/2021-October/464338.html [2] https://lists.denx.de/pipermail/u-boot/2021-November/466181.html > > Signed-off-by: Peng Fan > --- > arch/arm/dts/imx8mq-evk-u-boot.dtsi | 2 + > arch/arm/dts/imx8mq-u-boot.dtsi | 122 ++++++++++++++++++++++++ > arch/arm/mach-imx/imx8m/Kconfig | 1 + > board/freescale/imx8mq_evk/Kconfig | 2 +- > board/freescale/imx8mq_evk/imximage.cfg | 11 +++ > configs/imx8mq_evk_defconfig | 2 +- > 6 files changed, 138 insertions(+), 2 deletions(-) > create mode 100644 arch/arm/dts/imx8mq-u-boot.dtsi > create mode 100644 board/freescale/imx8mq_evk/imximage.cfg > > diff --git a/arch/arm/dts/imx8mq-evk-u-boot.dtsi b/arch/arm/dts/imx8mq-evk-u-boot.dtsi > index 2cfc12b7e0..6f9c81462e 100644 > --- a/arch/arm/dts/imx8mq-evk-u-boot.dtsi > +++ b/arch/arm/dts/imx8mq-evk-u-boot.dtsi > @@ -1,5 +1,7 @@ > // SPDX-License-Identifier: (GPL-2.0 OR MIT) > > +#include "imx8mq-u-boot.dtsi" > + > &usdhc1 { > mmc-hs400-1_8v; > }; > diff --git a/arch/arm/dts/imx8mq-u-boot.dtsi b/arch/arm/dts/imx8mq-u-boot.dtsi > new file mode 100644 > index 0000000000..2c10e9b645 > --- /dev/null > +++ b/arch/arm/dts/imx8mq-u-boot.dtsi > @@ -0,0 +1,122 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright 2021 NXP > + */ > + > +/ { > + binman: binman { > + multiple-images; > + }; > + > +}; > + > +&binman { > + u-boot-spl-ddr { > + filename = "u-boot-spl-ddr.bin"; > + pad-byte = <0xff>; > + align-size = <4>; > + align = <4>; > + > + u-boot-spl { > + align-end = <4>; > + }; > + > + blob_1: blob-ext@1 { > + filename = "lpddr4_pmu_train_1d_imem.bin"; > + size = <0x8000>; > + }; > + > + blob_2: blob-ext@2 { > + filename = "lpddr4_pmu_train_1d_dmem.bin"; > + size = <0x4000>; > + }; > + > + blob_3: blob-ext@3 { > + filename = "lpddr4_pmu_train_2d_imem.bin"; > + size = <0x8000>; > + }; > + > + blob_4: blob-ext@4 { > + filename = "lpddr4_pmu_train_2d_dmem.bin"; > + size = <0x4000>; > + }; > + }; > + > + signed_hdmi { > + filename = "signed_hdmi.bin"; > + > + blob_5: blob-ext@5 { > + filename = "signed_hdmi_imx8m.bin"; > + }; > + }; > + > + flash { > + mkimage { > + args = "-n spl/u-boot-spl.cfgout -T imx8mimage -e 0x7e1000"; > + > + blob { > + filename = "u-boot-spl-ddr.bin"; > + }; > + > + }; > + > + }; > + > + itb { > + filename = "u-boot.itb"; > + > + fit { > + description = "Configuration to load ATF before U-Boot"; > + #address-cells = <1>; > + fit,external-offset = ; > + > + images { > + uboot { > + description = "U-Boot (64-bit)"; > + type = "standalone"; > + arch = "arm64"; > + compression = "none"; > + load = ; > + > + uboot_blob: blob-ext { > + filename = "u-boot-nodtb.bin"; > + }; > + }; > + > + atf { > + description = "ARM Trusted Firmware"; > + type = "firmware"; > + arch = "arm64"; > + compression = "none"; > + load = <0x910000>; > + entry = <0x910000>; > + > + atf_blob: blob-ext { > + filename = "bl31.bin"; > + }; > + }; > + > + fdt { > + description = "NAME"; > + type = "flat_dt"; > + compression = "none"; > + > + uboot_fdt_blob: blob-ext { > + filename = "u-boot.dtb"; > + }; > + }; > + }; > + > + configurations { > + default = "conf"; > + > + conf { > + description = "NAME"; > + firmware = "uboot"; > + loadables = "atf"; > + fdt = "fdt"; > + }; > + }; > + }; > + }; > +}; > diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig > index 276b8bd974..c556e712b7 100644 > --- a/arch/arm/mach-imx/imx8m/Kconfig > +++ b/arch/arm/mach-imx/imx8m/Kconfig > @@ -36,6 +36,7 @@ config TARGET_IMX8MQ_CM > > config TARGET_IMX8MQ_EVK > bool "imx8mq_evk" > + select BINMAN > select IMX8MQ > select IMX8M_LPDDR4 > > diff --git a/board/freescale/imx8mq_evk/Kconfig b/board/freescale/imx8mq_evk/Kconfig > index c4d20ad7c7..a7c49744b3 100644 > --- a/board/freescale/imx8mq_evk/Kconfig > +++ b/board/freescale/imx8mq_evk/Kconfig > @@ -10,6 +10,6 @@ config SYS_CONFIG_NAME > default "imx8mq_evk" > > config IMX_CONFIG > - default "arch/arm/mach-imx/imx8m/imximage.cfg" > + default "board/freescale/imx8mq_evk/imximage.cfg" > > endif > diff --git a/board/freescale/imx8mq_evk/imximage.cfg b/board/freescale/imx8mq_evk/imximage.cfg > new file mode 100644 > index 0000000000..74f12b30d2 > --- /dev/null > +++ b/board/freescale/imx8mq_evk/imximage.cfg > @@ -0,0 +1,11 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * Copyright 2021 NXP > + */ > + > +#define __ASSEMBLY__ > + > +FIT > +BOOT_FROM sd > +SIGNED_HDMI signed_hdmi.bin > +LOADER mkimage.flash.mkimage 0x7e1000 > diff --git a/configs/imx8mq_evk_defconfig b/configs/imx8mq_evk_defconfig > index 62fe6f1523..5970d8c164 100644 > --- a/configs/imx8mq_evk_defconfig > +++ b/configs/imx8mq_evk_defconfig > @@ -18,7 +18,7 @@ CONFIG_SYS_LOAD_ADDR=0x40480000 > CONFIG_FIT=y > CONFIG_FIT_EXTERNAL_OFFSET=0x3000 > CONFIG_SPL_LOAD_FIT=y > -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh" > +# CONFIG_USE_SPL_FIT_GENERATOR is not set > CONFIG_BOARD_EARLY_INIT_F=y > CONFIG_BOARD_LATE_INIT=y > CONFIG_SPL_BOARD_INIT=y > -- > 2.30.0 > -- Heiko