[Buildroot] [PATCH 03/11] support/scripts/pkg-stats: store patch info in a hash

[Heiko Thiery <heiko.thiery@gmail.com>]

Am Fr., 3. Jan. 2020 um 16:23 Uhr schrieb Thomas Petazzoni
<thomas.petazzoni@bootlin.com>:
>
> On Fri,  3 Jan 2020 16:18:40 +0100
> Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> > This patch changes the variable to store the patch count to a hash. This
> > variable holds the patch count of the packages as well a list of the patch
> > file names.
> >
> > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
>
> Instead of "hash" you should use "dict", which is the actual name used
> in the Python world for this data type, if I'm correct. This is also
> valid for PATCH 01/11.

you are right

> > diff --git a/support/scripts/pkg-stats b/support/scripts/pkg-stats
> > index 9cfbcf1acc..92fc01d655 100755
> > --- a/support/scripts/pkg-stats
> > +++ b/support/scripts/pkg-stats
> > @@ -56,7 +56,7 @@ class Package:
> >          self.has_license = False
> >          self.has_license_files = False
> >          self.has_hash = False
> > -        self.patch_count = 0
> > +        self.patches = {'count':0, 'files': None}
>
> I am wondering if a dict here is really appropriate, shouldn't we
> instead keep a simpler:
>
>         self.patch_count
>         self.patch_files
>
> and be done with it ?
>
> Note: I haven't looked at the other patches in your series yet. Maybe
> you add more entries to the dict that make it more relevant.

No there are no other entries in this dict.
But thinking over that I consider removing the count filed because we
can calculate the count from the length of the list of patches?! What
do you think?

> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com