From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6205EC433F5 for ; Fri, 17 Sep 2021 16:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 41FCA61212 for ; Fri, 17 Sep 2021 16:10:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243506AbhIQQMF (ORCPT ); Fri, 17 Sep 2021 12:12:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242637AbhIQQL5 (ORCPT ); Fri, 17 Sep 2021 12:11:57 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9278EC061574; Fri, 17 Sep 2021 09:10:34 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id b15so16606857lfe.7; Fri, 17 Sep 2021 09:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zo7Kfu8UASbfOIxzSXjB/ZC/wcwccqd9kdursu9/738=; b=nqSY8F9cra8tnW2PVoYEx+0pPbCHqw/TTz+TWhX+WpXzPvmFd30kvkE4tgMwmoQ6Ib G2EJXJcETjXHUuhZBioUvcwYvFx1317dJ7vlRw9VjUwqAz/+/95Lyjr0zlAKh2nV3GiK AjXsLjtWR/sWMtUqztKh0Ld6lMZFFZYJ//feCDrav81r42quErifa4+FMKoejhL6Nhvj LcTTMGmCV+I0AXMGOyYp9PD8L9jbzBGY3K171DZlGaNzxpYc96AgnLupbB7BhNhJPZ7l 0EvJISFXWjFXjZa9w+J+QdQIBLAjpvq+UqQIzHSPE0nEPYMMeojJfyO4q7LbsdSGSJsB z/EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zo7Kfu8UASbfOIxzSXjB/ZC/wcwccqd9kdursu9/738=; b=4UvY1/UfuGg0rxYLuLKdB5T2LRCyvVwNgYTKJ1LxsIlFVogocRUsyg+8avfkHUk2Mh QygdFtWHwwrDNArBIOAVsJQpQ6h/Y7Ur1Ib2mNFcoEeqyauGAVeaZKfPBlCp9giMj4KZ GaMqEeY3Ts2UfaKmtoI/mGr5byMSX8jrHYaB1gCe1D2vxA1I64kX70sMHhhrKZaYIgEG ifmQBhwL+Vb3S5PC4FC8OgHJ11FQ3raS0uFXie4EgIDKHCmVZQINfd5MfjQeLMSCdN8U cOd9GNu7ug7dh+g8x5Fch5+9uVbt0NGFiBRDKSufasXR70oHizm7YiMaDYo0CJKk4Fpf j+Vw== X-Gm-Message-State: AOAM533MANbSPaAyk9x/ucWs0NRT2xzUhHhjyIM7szYyiC4PNPOK2AOK +YLE5jTwqAzv6Xscka9vVQE/jm+lUZQZU7oplIZb9uvLbdRcQalT X-Google-Smtp-Source: ABdhPJxP7ZE7dWbbEQ+3KNsObJWIfvWnJmHi2r9uJZFD8gWvYPp6CIPGvX//YnQ/Dm6ZPQajl0DsFlRx95QpeUx7PmA= X-Received: by 2002:a19:c38b:: with SMTP id t133mr8505200lff.196.1631895032908; Fri, 17 Sep 2021 09:10:32 -0700 (PDT) MIME-Version: 1.0 References: <20210915120325.20248-1-heiko.thiery@gmail.com> <7e7ee4244ababc0a46e0875222c7e37d@walle.cc> <898fd5e0-2073-3689-89b6-2c5071773786@kontron.de> <9bcf7b749dca57d42aa2e7afd88b5a26f3eeff2a.camel@pengutronix.de> In-Reply-To: <9bcf7b749dca57d42aa2e7afd88b5a26f3eeff2a.camel@pengutronix.de> From: Heiko Thiery Date: Fri, 17 Sep 2021 18:10:21 +0200 Message-ID: Subject: Re: [PATCH] arm64: dts: imx8mm-kontron-n801x-som: do not allow to switch off buck2 To: Lucas Stach Cc: Frieder Schrempf , devicetree@vger.kernel.org, =?UTF-8?Q?Guido_G=C3=BCnther?= , Fabio Estevam , Shengjiu Wang , "Angus Ainslie (Purism)" , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Joakim Zhang , Michael Walle , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lucas, Am Fr., 17. Sept. 2021 um 13:44 Uhr schrieb Lucas Stach : > > Am Freitag, dem 17.09.2021 um 09:28 +0200 schrieb Heiko Thiery: > > Hi Frieder, > > > > Am Mi., 15. Sept. 2021 um 14:09 Uhr schrieb Frieder Schrempf > > : > > > > > > On 15.09.21 14:05, Michael Walle wrote: > > > > Am 2021-09-15 14:03, schrieb Heiko Thiery: > > > > > The buck2 output of the PMIC is the VDD core voltage of the cpu. > > > > > Switching off this will poweroff the CPU. Add the 'regulator-always-on' > > > > > property to avoid this. > > > > > > > > Mh, have this ever worked? Is there a commit which introduced a regression? > > > > > > Yes, this did work before, even without 'regulator-always-on'. I > > > currently don't understand why this is needed. The regulator is > > > referenced in the CPU nodes as 'cpu-supply'. This should be enough to > > > not disable it as long as the CPU is up. > > > > I rechecked that with 5.11, 5.10 and 5.9 and I see on all of them the > > same issue: > > > > [ 31.716031] vdd-5v: disabling > > [ 31.719032] rst-usb-eth2: disabling > > [ 31.722553] buck2: disabling > > > > While on that I tried to compare with other boards and see that they > > also have the cpu-voltage marked as "regulator-always-on". The only > > exception in dts/freescale is in imx8mq-librem5-devkit.dts [1] that > > has not set this property. > > > > I agree with you and don't understand why this is happening. Has > > anyone else an explanation? > > > > [1] https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts#L319 > > > Maybe your kernel config is missing the cpufreq driver, so you don't > have a consumer of the regulator? > > Marking the regulator as always-on seems like the right thing to do, > you don't want to depend on a consumer showing up to make sure that > your CPU voltage isn't cut... shouldn't it be that the node cpu-supply here is a consumer of the referenced voltage? -- Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C13CC433F5 for ; Fri, 17 Sep 2021 16:13:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 147CC61212 for ; Fri, 17 Sep 2021 16:13:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 147CC61212 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E9GmUsv0o2tCPvREIVlKWkhh5V5+Yrd7Lm6DT+BwlSo=; b=FxforrAHYCejSe vS6yyxeEq5W2HdYCwlAWLmPTPKfksv41j2BFQu2ZmWDPh3qCVVf0tAzYo8g+umif4y6fV6+kesEck 0qoQMf8/QxzSdIdj6RDAfwDpZ0sqbgJKb4RYnkJRRPAzbFxvln8rIuEyltnuhZTG0XRRNVEm3v1L+ 8+lhe70ZuQtg0ceS5V+Ye398W3H7FWa6nBNVrweLn8Csd++hgygBxLg4irESh82xJpEQc15uDWU5A zr+rjkvE85IUzCeSPyEyEy1X7FJM5Ax9OIJ7SoJFSETCrrQyywiK0yuqXjgnUgBsICCpJHqbd2eaT YbjfZuTXyCWlExSBcMaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRGRj-00Ebpa-1S; Fri, 17 Sep 2021 16:10:39 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRGRe-00EboA-Ku for linux-arm-kernel@lists.infradead.org; Fri, 17 Sep 2021 16:10:36 +0000 Received: by mail-lf1-x133.google.com with SMTP id g1so35468476lfj.12 for ; Fri, 17 Sep 2021 09:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zo7Kfu8UASbfOIxzSXjB/ZC/wcwccqd9kdursu9/738=; b=nqSY8F9cra8tnW2PVoYEx+0pPbCHqw/TTz+TWhX+WpXzPvmFd30kvkE4tgMwmoQ6Ib G2EJXJcETjXHUuhZBioUvcwYvFx1317dJ7vlRw9VjUwqAz/+/95Lyjr0zlAKh2nV3GiK AjXsLjtWR/sWMtUqztKh0Ld6lMZFFZYJ//feCDrav81r42quErifa4+FMKoejhL6Nhvj LcTTMGmCV+I0AXMGOyYp9PD8L9jbzBGY3K171DZlGaNzxpYc96AgnLupbB7BhNhJPZ7l 0EvJISFXWjFXjZa9w+J+QdQIBLAjpvq+UqQIzHSPE0nEPYMMeojJfyO4q7LbsdSGSJsB z/EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zo7Kfu8UASbfOIxzSXjB/ZC/wcwccqd9kdursu9/738=; b=B4AHCPR/nxpbo/H1CE+Q5W34CQdQdabf4lRinfTudoS9vSBernnGR7hAvaKCtHvkit UutPCAOOb6kLjhlg2OBtPyQnSnbuDxJK+UkkWTW1FA2vGy4UbGOloUiJiuZ1qlnPgk/8 ntZwYLd3wFregDdR1AGDZC772ec0CjabJCfvt7HA3tlLaQeddHDGznb6e5FHkmJkwuPQ DV3JLlp9laoejEJGNN54wWzDjA3LLL7fQixxT3rxwgD7MW6+RIts+1VCrOQHKROsCoQx YErAXPKg/DNJkd8xw/VrEtEXm3nwOvsCRre4LkN8Mi47UGFtQX5UpYpid3rfewa+wVRa +1PQ== X-Gm-Message-State: AOAM532p2XjXC6YVqB5ETd9SusZvhrhCc+MQ2G2G4inLpZhsHqU0faBj OfajLZo8LE7M+kAnkThhhqumUVtYKlagDCXbI3g= X-Google-Smtp-Source: ABdhPJxP7ZE7dWbbEQ+3KNsObJWIfvWnJmHi2r9uJZFD8gWvYPp6CIPGvX//YnQ/Dm6ZPQajl0DsFlRx95QpeUx7PmA= X-Received: by 2002:a19:c38b:: with SMTP id t133mr8505200lff.196.1631895032908; Fri, 17 Sep 2021 09:10:32 -0700 (PDT) MIME-Version: 1.0 References: <20210915120325.20248-1-heiko.thiery@gmail.com> <7e7ee4244ababc0a46e0875222c7e37d@walle.cc> <898fd5e0-2073-3689-89b6-2c5071773786@kontron.de> <9bcf7b749dca57d42aa2e7afd88b5a26f3eeff2a.camel@pengutronix.de> In-Reply-To: <9bcf7b749dca57d42aa2e7afd88b5a26f3eeff2a.camel@pengutronix.de> From: Heiko Thiery Date: Fri, 17 Sep 2021 18:10:21 +0200 Message-ID: Subject: Re: [PATCH] arm64: dts: imx8mm-kontron-n801x-som: do not allow to switch off buck2 To: Lucas Stach Cc: Frieder Schrempf , devicetree@vger.kernel.org, =?UTF-8?Q?Guido_G=C3=BCnther?= , Fabio Estevam , Shengjiu Wang , "Angus Ainslie (Purism)" , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Joakim Zhang , Michael Walle , Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210917_091034_733709_BC11EE1D X-CRM114-Status: GOOD ( 26.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lucas, Am Fr., 17. Sept. 2021 um 13:44 Uhr schrieb Lucas Stach : > > Am Freitag, dem 17.09.2021 um 09:28 +0200 schrieb Heiko Thiery: > > Hi Frieder, > > > > Am Mi., 15. Sept. 2021 um 14:09 Uhr schrieb Frieder Schrempf > > : > > > > > > On 15.09.21 14:05, Michael Walle wrote: > > > > Am 2021-09-15 14:03, schrieb Heiko Thiery: > > > > > The buck2 output of the PMIC is the VDD core voltage of the cpu. > > > > > Switching off this will poweroff the CPU. Add the 'regulator-always-on' > > > > > property to avoid this. > > > > > > > > Mh, have this ever worked? Is there a commit which introduced a regression? > > > > > > Yes, this did work before, even without 'regulator-always-on'. I > > > currently don't understand why this is needed. The regulator is > > > referenced in the CPU nodes as 'cpu-supply'. This should be enough to > > > not disable it as long as the CPU is up. > > > > I rechecked that with 5.11, 5.10 and 5.9 and I see on all of them the > > same issue: > > > > [ 31.716031] vdd-5v: disabling > > [ 31.719032] rst-usb-eth2: disabling > > [ 31.722553] buck2: disabling > > > > While on that I tried to compare with other boards and see that they > > also have the cpu-voltage marked as "regulator-always-on". The only > > exception in dts/freescale is in imx8mq-librem5-devkit.dts [1] that > > has not set this property. > > > > I agree with you and don't understand why this is happening. Has > > anyone else an explanation? > > > > [1] https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts#L319 > > > Maybe your kernel config is missing the cpufreq driver, so you don't > have a consumer of the regulator? > > Marking the regulator as always-on seems like the right thing to do, > you don't want to depend on a consumer showing up to make sure that > your CPU voltage isn't cut... shouldn't it be that the node cpu-supply here is a consumer of the referenced voltage? -- Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel