From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4580C433F5 for ; Thu, 11 Nov 2021 17:21:32 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 406AD61241 for ; Thu, 11 Nov 2021 17:21:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 406AD61241 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 56E4783763; Thu, 11 Nov 2021 18:21:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JcarzutD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 769EF82EA5; Thu, 11 Nov 2021 18:21:28 +0100 (CET) Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6D7EE83A36 for ; Thu, 11 Nov 2021 18:21:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heiko.thiery@gmail.com Received: by mail-lj1-x232.google.com with SMTP id u25so10631004ljo.12 for ; Thu, 11 Nov 2021 09:21:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QWrr+lMCOUMsiOnk7msdemHe229x/Nm80P9tWYd0uJo=; b=JcarzutDYTN9A/HX72q1tZfli6JmTsgIVwheJsm1uCYkj4vo63Oftl/QuvWDyy0sXl gQPwYPHEj5b+9+ZFF4OScYIB/DXbFeci/eTVSGzDpDVkIlK+qkC4LTR/7VxYmlWYNbPv 7cmDc1L8x7TZTMbTmd9JHL8To2k2lV1omHUra6mKYBszqeq6lqCOJZMN09nXiKzhFkoQ ziCE+YKJizhYiuKjuTBZ8N1cJmcZndhZ/MFmLimeXvTcKWCUsVazJWk+Y/YhQi5FV9Vz 2g3Hw3A65FOn4mJOP8bjU4pgpSLNAdqlRJYgg0U0oj7+N9YJ8+XLFJEAcJSx1Zlegqgi W1Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QWrr+lMCOUMsiOnk7msdemHe229x/Nm80P9tWYd0uJo=; b=mJtL4XkGy3p1ArsIN2kDxgEBJ1+oiZl6uiLz0M1E87fSCemBgOWmQ4islz/AT7gt79 t6iNAw4gcE2vRVffjM4xt6xWVLHWzkjEuGH0ljbcFXQibrJ9dK14elJdPvCBiGdkbZjR fyHF2n5Jv/efithmcZ8+s+3lGjJSAYG5Wtew5Ad0BhS0Mej7y5dI2xd8EYZ3azaSl5DF H9wr1gn0PqXTlh0+/6ElRi4cuavnr3TCYzG6nlQkIu8K74TzH7RGgCYn4okzq5BCuRfx 30iyfx/7mabK0ERT1jqqJoaAvgkPgHxWF/99c7XEbeEMJuPkjzMVJHsLSfexZP1fqzRf yz1A== X-Gm-Message-State: AOAM533lcnLSTk3+Q8UiU3G9SP4oMS24OKZaiGacnZTOjVVTpGVMbH3M aip1q6SjucYqpse3MWAuX1fMFFk6j2gRO9Zsly0= X-Google-Smtp-Source: ABdhPJxBpt3SBwUZ0zj/bKlkmXNf/Xtrhy7xKk7Gx7jgoJ1GZI2viWVQtZMLPakZ/bURxCZzw7Y9+S/9O+JBJ5XsbGE= X-Received: by 2002:a05:651c:1413:: with SMTP id u19mr8705372lje.382.1636651282139; Thu, 11 Nov 2021 09:21:22 -0800 (PST) MIME-Version: 1.0 References: <20211022024220.23584-1-peng.fan@oss.nxp.com> <20211022024220.23584-5-peng.fan@oss.nxp.com> In-Reply-To: <20211022024220.23584-5-peng.fan@oss.nxp.com> From: Heiko Thiery Date: Thu, 11 Nov 2021 18:21:11 +0100 Message-ID: Subject: Re: [PATCH V3 4/5] imx: imx8mq use common imximage.cfg To: "Peng Fan (OSS)" Cc: sbabic@denx.de, festevam@gmail.com, u-boot@lists.denx.de, uboot-imx@nxp.com, Peng Fan Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Peng, Am Fr., 22. Okt. 2021 um 04:08 Uhr schrieb Peng Fan (OSS) : > > From: Peng Fan > > After all these board switch to binman, we could use common imximage.cfg > > Signed-off-by: Peng Fan > --- > arch/arm/mach-imx/imx8m/imximage.cfg | 12 +++--------- > board/freescale/imx8mq_evk/Kconfig | 2 +- > board/freescale/imx8mq_evk/imximage.cfg | 11 ----------- > board/google/imx8mq_phanbell/Kconfig | 2 +- > board/google/imx8mq_phanbell/imximage.cfg | 11 ----------- > board/technexion/pico-imx8mq/Kconfig | 2 +- > board/technexion/pico-imx8mq/imximage.cfg | 11 ----------- > 7 files changed, 6 insertions(+), 45 deletions(-) > delete mode 100644 board/freescale/imx8mq_evk/imximage.cfg > delete mode 100644 board/google/imx8mq_phanbell/imximage.cfg > delete mode 100644 board/technexion/pico-imx8mq/imximage.cfg > > diff --git a/arch/arm/mach-imx/imx8m/imximage.cfg b/arch/arm/mach-imx/imx8m/imximage.cfg > index 714b24273b..9c6eaf0a6d 100644 > --- a/arch/arm/mach-imx/imx8m/imximage.cfg > +++ b/arch/arm/mach-imx/imx8m/imximage.cfg > @@ -1,17 +1,11 @@ > /* SPDX-License-Identifier: GPL-2.0+ */ > /* > - * Copyright 2018 NXP > + * Copyright 2018-2021 NXP > */ > > #define __ASSEMBLY__ > > FIT > BOOT_FROM sd > -SIGNED_HDMI signed_hdmi_imx8m.bin > -LOADER spl/u-boot-spl-ddr.bin 0x7E1000 > -SECOND_LOADER u-boot.itb 0x40200000 0x60000 > - > -DDR_FW lpddr4_pmu_train_1d_imem.bin > -DDR_FW lpddr4_pmu_train_1d_dmem.bin > -DDR_FW lpddr4_pmu_train_2d_imem.bin > -DDR_FW lpddr4_pmu_train_2d_dmem.bin > +SIGNED_HDMI signed_hdmi.bin > +LOADER mkimage.flash.mkimage 0x7e1000 This file is only a temporarily created file by binman. You should use the output file .. here it should be flash.bin. But as Patrick already pointed out, we should create the final flash.bin like before. I also have a patch for adding a new im8mq board pending that has this already implemented.[1]. [1] https://patchwork.ozlabs.org/project/uboot/patch/20211014180824.10681-2-heiko.thiery@gmail.com/ > diff --git a/board/freescale/imx8mq_evk/Kconfig b/board/freescale/imx8mq_evk/Kconfig > index a7c49744b3..c4d20ad7c7 100644 > --- a/board/freescale/imx8mq_evk/Kconfig > +++ b/board/freescale/imx8mq_evk/Kconfig > @@ -10,6 +10,6 @@ config SYS_CONFIG_NAME > default "imx8mq_evk" > > config IMX_CONFIG > - default "board/freescale/imx8mq_evk/imximage.cfg" > + default "arch/arm/mach-imx/imx8m/imximage.cfg" > > endif > diff --git a/board/freescale/imx8mq_evk/imximage.cfg b/board/freescale/imx8mq_evk/imximage.cfg > deleted file mode 100644 > index 74f12b30d2..0000000000 > --- a/board/freescale/imx8mq_evk/imximage.cfg > +++ /dev/null > @@ -1,11 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0+ */ > -/* > - * Copyright 2021 NXP > - */ > - > -#define __ASSEMBLY__ > - > -FIT > -BOOT_FROM sd > -SIGNED_HDMI signed_hdmi.bin > -LOADER mkimage.flash.mkimage 0x7e1000 > diff --git a/board/google/imx8mq_phanbell/Kconfig b/board/google/imx8mq_phanbell/Kconfig > index e59b03cb17..54cfb99952 100644 > --- a/board/google/imx8mq_phanbell/Kconfig > +++ b/board/google/imx8mq_phanbell/Kconfig > @@ -10,6 +10,6 @@ config SYS_CONFIG_NAME > default "imx8mq_phanbell" > > config IMX_CONFIG > - default "board/google/imx8mq_phanbell/imximage.cfg" > + default "arch/arm/mach-imx/imx8m/imximage.cfg" > > endif > diff --git a/board/google/imx8mq_phanbell/imximage.cfg b/board/google/imx8mq_phanbell/imximage.cfg > deleted file mode 100644 > index 74f12b30d2..0000000000 > --- a/board/google/imx8mq_phanbell/imximage.cfg > +++ /dev/null > @@ -1,11 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0+ */ > -/* > - * Copyright 2021 NXP > - */ > - > -#define __ASSEMBLY__ > - > -FIT > -BOOT_FROM sd > -SIGNED_HDMI signed_hdmi.bin > -LOADER mkimage.flash.mkimage 0x7e1000 > diff --git a/board/technexion/pico-imx8mq/Kconfig b/board/technexion/pico-imx8mq/Kconfig > index 97655517d8..628b051149 100644 > --- a/board/technexion/pico-imx8mq/Kconfig > +++ b/board/technexion/pico-imx8mq/Kconfig > @@ -10,6 +10,6 @@ config SYS_CONFIG_NAME > default "pico-imx8mq" > > config IMX_CONFIG > - default "board/technexion/pico-imx8mq/imximage.cfg" > + default "arch/arm/mach-imx/imx8m/imximage.cfg" > > endif > diff --git a/board/technexion/pico-imx8mq/imximage.cfg b/board/technexion/pico-imx8mq/imximage.cfg > deleted file mode 100644 > index 74f12b30d2..0000000000 > --- a/board/technexion/pico-imx8mq/imximage.cfg > +++ /dev/null > @@ -1,11 +0,0 @@ > -/* SPDX-License-Identifier: GPL-2.0+ */ > -/* > - * Copyright 2021 NXP > - */ > - > -#define __ASSEMBLY__ > - > -FIT > -BOOT_FROM sd > -SIGNED_HDMI signed_hdmi.bin > -LOADER mkimage.flash.mkimage 0x7e1000 > -- > 2.30.0 >