From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73BA6C4338F for ; Fri, 20 Aug 2021 05:35:13 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F8B861042 for ; Fri, 20 Aug 2021 05:35:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3F8B861042 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 98A8082C0C; Fri, 20 Aug 2021 07:35:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NY0oreN+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8CDAD82C1A; Fri, 20 Aug 2021 07:35:06 +0200 (CEST) Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DF0A481EBD for ; Fri, 20 Aug 2021 07:35:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heiko.thiery@gmail.com Received: by mail-il1-x131.google.com with SMTP id v16so8340221ilo.10 for ; Thu, 19 Aug 2021 22:35:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oWeQXr76mtXSOWILO6x5YE5PM72Xod9RWhQy/1x7ebg=; b=NY0oreN+K3D09rOp9D2zI6D9XwUmJlO6+pXfr6LaYY6IFCuI0kPqVuiqiO69TXmjC9 SxBP4Q+Rv0W852GjrMXFCzudlhD6R1rYIQOJreZlL4as8f0pocfxc/ll2chETNa6J9Hi cI5QfpPbAPCi14sbjJMQGFHC+6kZuT1EZUxAXYZYnoZsK8ijPwosJjR6qrQJlW++54eG /KrwBHhW8vGaA6TIJh7aFJAe8TkV0ioo5BFLtyiXuk52Lda47wDWcf23nlS9OEnW+dN1 EruJvKjT+PpQdwixzlAlzyzbBxr5hPzUCdT17/Er8kNZCQn9Azf00vI1GpzpD0u+mHWP VzTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oWeQXr76mtXSOWILO6x5YE5PM72Xod9RWhQy/1x7ebg=; b=f6vwSEcKtXaUJg6oHZTCZOch1IgyI3S/8BXX6EryPS5LUiIv8tZhG4fDwbKsOlpkUX eSebHf3RGys514Vu5Nfmh3GZRfQx6GtJo+LHlYOz42e+np7my6Mvj2OvgxhxwFnylAY/ jJ0ABUHFvOvlAKsM3M46VLdawjXSKRc3haQ9KENM2yGfBbiUqV5sgG4qfEzoyLgn+H1+ KbHvU8ym8VNN5k/a9dy50xjTltsAhPyiAD5HYMUHUAfqncY/iu4FS9DyOrJ8hxQ3eLWm krSjk8sal1I733JSxzDcLF6KHgUdcboV7POxNAbrzyjppU8nw2Y7vl8r1F5824x7QJUb jP5g== X-Gm-Message-State: AOAM5326Rfm349mpb/wnwnMQMg/Bt2nB76HYz/CIbTTwyn2c0ap6Qv2i vdHi0YzQE+VOxAAwyEpRJ8Yv/vmReCv6ev5DkM8= X-Google-Smtp-Source: ABdhPJxEaG9Gr3+IkvZNCDya6yGAyTWrtV6gNExL9Y99qOPfrJBH4F0XwSUhD+e9Q+SBgKXO78gClhA17m+Y5HB/Wws= X-Received: by 2002:a05:6e02:20cc:: with SMTP id 12mr12440129ilq.98.1629437700174; Thu, 19 Aug 2021 22:35:00 -0700 (PDT) MIME-Version: 1.0 References: <20210819192802.2151226-1-festevam@denx.de> <20210819192802.2151226-2-festevam@denx.de> In-Reply-To: <20210819192802.2151226-2-festevam@denx.de> From: Heiko Thiery Date: Fri, 20 Aug 2021 07:34:49 +0200 Message-ID: Subject: Re: [PATCH v3 2/2] Makefile: Clean the i.MX8MM artifacts To: Fabio Estevam Cc: sbabic@denx.de, uboot-imx@nxp.com, u-boot@lists.denx.de, hs@denx.de, frieder.schrempf@kontron.de, tharvey@gateworks.com, marcel.ziswiler@toradex.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Fabio, Am Do., 19. Aug. 2021 um 21:28 Uhr schrieb Fabio Estevam : > > Clean the binaries generated by binman on imx8mm-evk: > spl.* mkimage*.mkimage imx-boot.* > > Reported-by: Frieder Schrempf > Signed-off-by: Fabio Estevam > --- > Changes since v2: > - None. Newly introducedin this series. > > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 3c8437d21a..7096fdf895 100644 > --- a/Makefile > +++ b/Makefile > @@ -2095,7 +2095,8 @@ CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h tools/version.h \ > boot* u-boot* MLO* SPL System.map fit-dtb.blob* \ > u-boot-ivt.img.log u-boot-dtb.imx.log SPL.log u-boot.imx.log \ > lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \ > - idbloader.img flash.bin flash.log defconfig keep-syms-lto.c > + idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \ > + spl.* mkimage*.mkimage imx-boot.* it might be useful to use one variable for all BINMAN clean files. Otherwise it is difficult to understand by whom the files were created. Something like that: --- a/Makefile +++ b/Makefile @@ -2091,12 +2091,14 @@ CLEAN_DIRS += $(MODVERDIR) \ $(foreach d, spl tpl, $(patsubst %,$d/%, \ $(filter-out include, $(shell ls -1 $d 2>/dev/null)))) +BINMAN_CLEAN_FILES = spl.* mkimage*.mkimage + CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h tools/version.h \ boot* u-boot* MLO* SPL System.map fit-dtb.blob* \ u-boot-ivt.img.log u-boot-dtb.imx.log SPL.log u-boot.imx.log \ lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \ idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \ - spl.* mkimage*.mkimage imx-boot.* + imx-boot.* $(BINMAN_CLEAN_FILES) + I had the idea, if binman could create a list with the created files. This could then be used to set the files to be deleted. I think of other users where the output files have a different name. Then the files could be deleted "automatically" with clean. -- Heiko