From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC369C433EF for ; Thu, 11 Nov 2021 13:54:39 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04E5A61057 for ; Thu, 11 Nov 2021 13:54:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 04E5A61057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3788783A16; Thu, 11 Nov 2021 14:54:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="V2ABgbnS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ABFE283A2C; Thu, 11 Nov 2021 14:54:34 +0100 (CET) Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 639EF83735 for ; Thu, 11 Nov 2021 14:54:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heiko.thiery@gmail.com Received: by mail-lj1-x22e.google.com with SMTP id v15so12188504ljc.0 for ; Thu, 11 Nov 2021 05:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1iVkbyT4owcTcmXUB4UkgQJxYbgUKYcfVUDuZp7K2kw=; b=V2ABgbnSwcMP84TYL9GtUSKQERDC+7scdZJflto4kqRtCgUwwSkBZ+OWKEKtWSytk3 E8lVp+nuakuzLre32XhXdKGNm1eT31HDrQukR2zEFApDLgZ038+qNNEsV7hGNGS0L7/f ZBNE5A/qJkS2Pfo71178521c3IrVHF2dfBENdhHV/Ue3TsDe8Kbhri/1nhTY1Ce+BIL2 +jtq5xaq0H84I4AOUQeAZ0qLWDOuW8nNy0YAKj9GIxuYwewixyb2FsDK3Ice/qJD8XHZ D36HK8cCFUkcsNxRrjwr9sYH+np+iDVOcUggkdplHj/v0HjBT6AKzT0bllSuNEtn19ZS gKIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1iVkbyT4owcTcmXUB4UkgQJxYbgUKYcfVUDuZp7K2kw=; b=SmRlojE2ygoM2Bjd+PuDwd/hIY0rPTiEYy59mNqQHGFFs4ByVq+TlCWn4CfxentYw/ wTt/UcN9MZFKIJ1VGwZnEh5grhivLJqr10Ghnp2TUFNjpbRx9NwvA5YTPooH51PNlsKO fTq4hITaQ+O/AsUXWTLuSdgU8c++pDthvQEaCt07waZgQliL2JoA/rVy2goSmn8626uK RPOLBS9HjXW6N95KaE/qkmcJqvDMwnJwk3OlIdF0SoCqsX8B58U1Cye06TlMFqo7+mXn sAt+pGnmkjkGB9WtV576dVGYA1mRo9WzZEAL862Zn0oT0nVjGmAqMiEWXBhIyIjR50wp m22g== X-Gm-Message-State: AOAM530cFtWD8sy74bsNxWHf1w5Rkbi3OjDB/+SwHAIaqqBwT/QFU73A 0IaS7/yEimu5licH96v71sNQwOEqX45Yiv0tVng= X-Google-Smtp-Source: ABdhPJzXgRmLhV4PHCKziAvrvkszlmVIcLGU+XEBP+PR3RWk3fBIj6VkUq9LkaZ4x799kGu38UC5mjHTgDyvYSYblrY= X-Received: by 2002:a2e:3102:: with SMTP id x2mr7162298ljx.276.1636638870685; Thu, 11 Nov 2021 05:54:30 -0800 (PST) MIME-Version: 1.0 References: <20211104185231.2927-1-heiko.thiery@gmail.com> <729199.1636053161@gemini.denx.de> <963318.1636296486@gemini.denx.de> <1288986.1636633445@gemini.denx.de> In-Reply-To: <1288986.1636633445@gemini.denx.de> From: Heiko Thiery Date: Thu, 11 Nov 2021 14:54:19 +0100 Message-ID: Subject: Re: [RFC 0/2] Do not stop with an error when mkimage fails To: Wolfgang Denk Cc: u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Michael Walle , Simon Glass Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Wolfgang, Am Do., 11. Nov. 2021 um 13:24 Uhr schrieb Wolfgang Denk : > > Dear Heiko, > > In message you wrote: > > > > > Sorry, but this makes no sense to me. If there is an error, it > > > should be reported and - if possible - handled. If this is not > > > possible, then the correct thing is to abort. Ignoring errors and > > > trying to continue is always the worst thing to do. > > > > The only reason I want to introduce this is because I want to have my > > imx8mq board built by CI. This board needs an external HDMI firmware > > which is used by mkimage. But because this firmware is not available > > in the CI build, it comes to the abort. With other boards it is also > > so that in the CI external blobs are not available and these make > > nevertheless without error a binman run. In this case only a warning > > is output. > > > > I know this is not a perfect solution but I don't know how to get my > > board merged without doing this kind of workaround for the U-Boot CI. > > It's not only not a perfect solution, it is the intentional > introduction of a bug, and thus totally unacceptable. > > If there is a file missing in the CI, then add/create it there. > > But do remove necessary error handling which would cause hard to > detec failures when for normal use. I understand your attitude and am meanwhile also of this opinion. The idea with the creation of dummy files I also had. I think we should go in this direction. Everything else would probably be connected with bigger changes. -- Heiko