All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Thiery <heiko.thiery@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/iproute2: Bump version to 5.11.0
Date: Sat, 10 Apr 2021 17:29:23 +0200	[thread overview]
Message-ID: <CAEyMn7bO9DFK6RRVXYDEFQNKXX-W5G_ZuwkFhLxcwWcpRoXHmA@mail.gmail.com> (raw)
In-Reply-To: <YGoG2Tqk6SVPHNpJ@pevik>

Hi Petr, Hi Thomas,

Am So., 4. Apr. 2021 um 20:35 Uhr schrieb Petr Vorel <petr.vorel@gmail.com>:
>
> Hi Thomas,
> > Hello Petr,
>
> > On Tue, 23 Mar 2021 19:10:04 +0100
> > Petr Vorel <petr.vorel@gmail.com> wrote:
>
> > > Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> > > ---
> > > Hi,
>
> > > NOTE: this should not be applied until uclibc based toolchains are
> > > regenerated. But posted for people who don't use uclibc and would like
> > > to have iproute2 sync with kernel version.
>
> > I think they have all been updated now. However, your patch doesn't
> > apply: it assumes that Buildroot master has iproute2 5.8.0, but we have
> > 5.7.0. And the patch we have in package/iproute2/ doesn't apply to
> > 5.11.0. Could you have a look and respin?
>
> Sure, I'll send fixed version, sorry for error.
>
> But I tried to build on updated package and it looks like error still exists.
> What do I do wrong?

I just tried to test the version bump of iproute2 to v5.11 and I see
the same/similar error on utils/pkg-test for
bootlin-armv5-uclibcbootlin-armv5-uclibc.

  109 |  char fh_buf[sizeof(struct file_handle) + sizeof(__u64)] = { 0 };
      |                     ^~~~~~
fs.c:124:5: error: dereferencing pointer to incomplete type ?struct file_handle?
  124 |  fhp->handle_bytes = sizeof(__u64);
      |     ^~
fs.c:125:6: warning: implicit declaration of function
?name_to_handle_at? [-Wimplicit-function-declaration]
  125 |  if (name_to_handle_at(AT_FDCWD, path, fhp, &mnt_id, 0) < 0) {
      |      ^~~~~~~~~~~~~~~~~
fs.c:109:7: warning: unused variable ?fh_buf? [-Wunused-variable]
  109 |  char fh_buf[sizeof(struct file_handle) + sizeof(__u64)] = { 0 };
      |       ^~~~~~
fs.c: In function ?get_cgroup2_path?:
fs.c:172:21: error: invalid application of ?sizeof? to incomplete type
?struct file_handle?
  172 |  char fh_buf[sizeof(struct file_handle) + sizeof(__u64)] = { 0 };
      |                     ^~~~~~
fs.c:200:5: error: dereferencing pointer to incomplete type ?struct file_handle?
  200 |  fhp->handle_bytes = sizeof(__u64);
      |     ^~
fs.c:204:7: warning: implicit declaration of function
?open_by_handle_at? [-Wimplicit-function-declaration]
  204 |  fd = open_by_handle_at(mnt_fd, fhp, 0);
      |       ^~~~~~~~~~~~~~~~~
fs.c:172:7: warning: unused variable ?fh_buf? [-Wunused-variable]
  172 |  char fh_buf[sizeof(struct file_handle) + sizeof(__u64)] = { 0 };

Looks like your patch in uclibc [1] is not in the used version of the
bootlin toolchain [2]. As far as I can see the toolchain uses uclibc
v1.0.34.

[1] https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=8bc41f131b8d70c84c300f14cd64abd448126b43
[2] https://toolchains.bootlin.com/releases_armv5-eabi.html

I think we have to wait until the toolchains will be updated to
include uclibc version 1.0.36 or greater.

Thank you
-- 
Heiko

  reply	other threads:[~2021-04-10 15:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23 18:10 [Buildroot] [PATCH 1/1] package/iproute2: Bump version to 5.11.0 Petr Vorel
2021-04-04 13:52 ` Thomas Petazzoni
2021-04-04 18:35   ` Petr Vorel
2021-04-10 15:29     ` Heiko Thiery [this message]
2021-04-10 16:25       ` Petr Vorel
2021-04-12  6:40         ` Heiko Thiery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEyMn7bO9DFK6RRVXYDEFQNKXX-W5G_ZuwkFhLxcwWcpRoXHmA@mail.gmail.com \
    --to=heiko.thiery@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.