From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CDE8C433EF for ; Sat, 18 Jun 2022 21:56:54 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 61CEC83F22; Sat, 18 Jun 2022 23:56:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="muNlGBQV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6F93983F22; Sat, 18 Jun 2022 23:56:51 +0200 (CEST) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 369EA83C0C for ; Sat, 18 Jun 2022 23:56:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heiko.thiery@gmail.com Received: by mail-wm1-x32a.google.com with SMTP id z9so3911375wmf.3 for ; Sat, 18 Jun 2022 14:56:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kz81pB1LRK9alK/bD/dDpgc+ZGMRH0SGp1jn6LPxJXs=; b=muNlGBQVuRbrgJHPbki1+XDiQYygZGR1caHkiXiBoY36TGDJ+3OwNtjgD+s9oh7td8 JZCKTq5CMhyj+r64lZVva3V1pOT4K4JJ1WAtskHPKyleKvU5ilLv4o4kZWw6xw/YmTwQ ked21j2zYvO5Z5RL2dsKTBKlv+jJi5YGJ/0ld3cc/2g7MX3RFE8dvn8RRDeeV4rh0sZb F8SJqymuCv3Yy8HRLuzBSf4N3GtHwNtYWe0n7711Fn7aXT+pcTvXyjziqWfveLnq8D+F 1q7ROq0cYbKsMZWrBBhDoXpJZZaVbkdJ3mXnUKe56swNM/7XVHXzVveIrLdxZjEBnMuc rPEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kz81pB1LRK9alK/bD/dDpgc+ZGMRH0SGp1jn6LPxJXs=; b=tFAAX+fFy2pmQqzlYDCjqrbd/ccGdqwTdX5JvB/H8wZ1xBfM2y4cgI0wihis/ebk8/ jxDEAGaWw9+hM0SakQqq1O+BxPffraFk5hG7K9Ow12Y/3TxFugVVfF5hi8/vLRlyK04U IWDFurBHbi4WUvBAi19B5Y8AbZSKioh+skNVayx5/eLJHfMfRux5/+wkAk03vMbjec9i DROakn22C/0xt+dqNckO+HAYK25EvUD9X/dvKE8kmjTen05oJlP3vH6oslWW8RLpkXpt BEpPliLQSt1qEs04ttsLwT5lyZWWOnAjTKNs54/B0JPtneFqtTXeqNqo43yxGH8n+49L 4d4Q== X-Gm-Message-State: AOAM533p4VhUdH01j10gX1UClv1zbHUsvNu9JX9QmVaPRklUCkCDtkWW 4UoKT/7r+qFx0bkiGCQhs2VTuNJtDY/DVdrQj28= X-Google-Smtp-Source: ABdhPJxWRdnofbsWlb4hiWzV+gR0f1opHSPqrJh/tgUjuUszHYeZ8VsWA0bD2pm5JvTdLHjXlsfLfd9/0go3KaejsfQ= X-Received: by 2002:a05:600c:4f56:b0:39c:6fb7:ee3d with SMTP id m22-20020a05600c4f5600b0039c6fb7ee3dmr27948675wmq.36.1655589408542; Sat, 18 Jun 2022 14:56:48 -0700 (PDT) MIME-Version: 1.0 References: <20220613211005.30871-1-heiko.thiery@gmail.com> In-Reply-To: From: Heiko Thiery Date: Sat, 18 Jun 2022 23:56:37 +0200 Message-ID: Subject: Re: [PATCH v4] imx: add i.MX8MN DDR3L evk board support To: Michael Nazzareno Trimarchi , Marek Vasut Cc: u-boot@lists.denx.de, Ying-Chun Liu , Peng Fan , Fabio Estevam , Marcel Ziswiler , Tim Harvey , Sean Anderson , =?UTF-8?Q?Thomas_Sch=C3=A4fer?= , Stefano Babic , Fabio Estevam Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Michael, Hi Marek, Am Mi., 15. Juni 2022 um 08:43 Uhr schrieb Michael Nazzareno Trimarchi : > > Hi Heiko > > On Wed, Jun 15, 2022 at 8:23 AM Heiko Thiery wrote: > > > > Hi Marek, > > > > [SNIP] > > > > > > diff --git a/board/freescale/imx8mn_evk/spl.c b/board/freescale/imx8mn_evk/spl.c > > > > index 14cb51368f..0d9909a662 100644 > > > > --- a/board/freescale/imx8mn_evk/spl.c > > > > +++ b/board/freescale/imx8mn_evk/spl.c > > > > @@ -83,6 +83,15 @@ int power_init_board(void) > > > > #ifdef CONFIG_IMX8MN_LOW_DRIVE_MODE > > > > /* Set VDD_SOC/VDD_DRAM to 0.8v for low drive mode */ > > > > pmic_reg_write(dev, PCA9450_BUCK1OUT_DVS0, 0x10); > > > > +#elif defined(CONFIG_TARGET_IMX8MN_DDR3L_EVK) > > > > + /* Set VDD_SOC to 0.85v for DDR3L at 1600MTS */ > > > > + pmic_reg_write(dev, PCA9450_BUCK1OUT_DVS0, 0x14); > > > > + > > > > + /* Disable the BUCK2 */ > > > > + pmic_reg_write(dev, PCA9450_BUCK2CTRL, 0x48); > > > > + > > > > + /* Set NVCC_DRAM to 1.35v */ > > > > + pmic_reg_write(dev, PCA9450_BUCK6OUT, 0x1E); > > > > #else > > > > > > All this part is not done by the spl pmic driver? > > > > I saw that you added the PCA9450 driver. Do you know if this > > initialization can be done by the driver when CONFIG_SPL_DM_REGULATOR > > is enabled? If I see this correctly, it can't be done. Is that > > correct? > > +&i2c1 { > + u-boot,dm-spl; > +}; > + > +&{/soc@0/bus@30800000/i2c@30a20000/pmic@4b} { > + u-boot,dm-spl; > +}; > + > +&{/soc@0/bus@30800000/i2c@30a20000/pmic@4b/regulators} { > + u-boot,dm-spl; > +}; > + > +&pinctrl_i2c1 { > + u-boot,dm-spl; > +}; > + > +&pinctrl_pmic { > + u-boot,dm-spl; > +}; > + > > Maybe something like this should work. Now question is about should be > done in pre-reloc or not It took me a little while to understand what was meant by this. In the meantime I could change the PMIC/Regulator initialization to DT/DM and can make the setting so. What is not clear to me yet is at which point this should be done (regulators_enable_boot_on()). Currently I do it in the board/spl specific board_init_f(). Do any of you have any advice here? Thanks -- Heiko > Michael > > > > -- > > Heiko > > > > -- > Michael Nazzareno Trimarchi > Co-Founder & Chief Executive Officer > M. +39 347 913 2170 > michael@amarulasolutions.com > __________________________________ > > Amarula Solutions BV > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL > T. +31 (0)85 111 9172 > info@amarulasolutions.com > www.amarulasolutions.com