All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Le Magourou <lemagoup@gmail.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Vivek Gautam <vivek.gautam@codeaurora.org>,
	Manu Gautam <mgautam@codeaurora.org>,
	andy.gross@linaro.org, linux-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	dianders@chromium.org, linux-usb@vger.kernel.org,
	gregkh@linuxfoundation.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH v2] arm64: dts: msm8996: Use dwc3-qcom glue driver for USB
Date: Tue, 10 Jul 2018 17:03:32 +0200	[thread overview]
Message-ID: <CAEz4NHpAYwgW0s7euAw4kWrc=V4Z9Oritu9+1rmkxmSwuZ5=ow@mail.gmail.com> (raw)
In-Reply-To: <87in64s97v.fsf@linux.intel.com>

Hi Felipe,

2018-06-27 14:30 GMT+02:00 Felipe Balbi <felipe.balbi@linux.intel.com>:
>
> looks like we need to do away with the wait_event_lock_irq()
> call. usb_ep_dequeue() can be called from within the controller's
> interrupt handler, so we can't rely on wait_event_lock_irq(). I guess
> the best thing here would be to mark TRBs as dirty (and not increment
> dequeue pointer), so they aren't reused by accident, then let endpoint
> continue processing. Once command completion interrupt fires, we
> increment dequeue pointer.
>
> This should work better, I suppose. Do you want a shot at implementing
> this?

I wrote a patch to implement this last week, and sent it to linux-arm-msm.
Feel free to review it and tell me if this complies with what you
suggested to me.

Regards,

Pierre Le Magourou

WARNING: multiple messages have this Message-ID
From: lemagoup@gmail.com
To: Felipe Balbi <felipe.balbi@linux.intel.com>
Cc: Vivek Gautam <vivek.gautam@codeaurora.org>,
	Manu Gautam <mgautam@codeaurora.org>,
	andy.gross@linaro.org, linux-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	dianders@chromium.org, linux-usb@vger.kernel.org,
	gregkh@linuxfoundation.org, bjorn.andersson@linaro.org
Subject: [v2] arm64: dts: msm8996: Use dwc3-qcom glue driver for USB
Date: Tue, 10 Jul 2018 17:03:32 +0200	[thread overview]
Message-ID: <CAEz4NHpAYwgW0s7euAw4kWrc=V4Z9Oritu9+1rmkxmSwuZ5=ow@mail.gmail.com> (raw)

Hi Felipe,

2018-06-27 14:30 GMT+02:00 Felipe Balbi <felipe.balbi@linux.intel.com>:
>
> looks like we need to do away with the wait_event_lock_irq()
> call. usb_ep_dequeue() can be called from within the controller's
> interrupt handler, so we can't rely on wait_event_lock_irq(). I guess
> the best thing here would be to mark TRBs as dirty (and not increment
> dequeue pointer), so they aren't reused by accident, then let endpoint
> continue processing. Once command completion interrupt fires, we
> increment dequeue pointer.
>
> This should work better, I suppose. Do you want a shot at implementing
> this?

I wrote a patch to implement this last week, and sent it to linux-arm-msm.
Feel free to review it and tell me if this complies with what you
suggested to me.

Regards,

Pierre Le Magourou
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-07-10 15:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-31 10:47 Manu Gautam
2018-05-31 10:47 ` [v2] " Manu Gautam
2018-06-07  8:30 ` [PATCH v2] " Vivek Gautam
2018-06-07  8:30   ` [v2] " Vivek Gautam
2018-06-11  6:36   ` [PATCH v2] " Julien Massot
2018-06-11  6:36     ` [v2] " Julien Massot
2018-06-11  7:01     ` [PATCH v2] " Vivek Gautam
2018-06-11  7:01       ` [v2] " Vivek Gautam
2018-06-11 12:33       ` [PATCH v2] " Julien Massot
2018-06-11 12:33         ` [v2] " Julien Massot
     [not found]         ` <CADb+VZKtAspuvO64FVEBHUbcB0Nr57jWpBmpS5GfCE+QKD4CcA@mail.gmail.com>
2018-06-27  9:27           ` [PATCH v2] " Felipe Balbi
2018-06-27  9:27             ` [v2] " Felipe Balbi
     [not found]             ` <CADb+VZJVtfgSDD+7F1J6p2YG0dguN7BhP=bzz3r8jO7FT7dk8w@mail.gmail.com>
2018-06-27 12:30               ` [PATCH v2] " Felipe Balbi
2018-06-27 12:30                 ` [v2] " Felipe Balbi
2018-07-10 15:03                 ` Pierre Le Magourou [this message]
2018-07-10 15:03                   ` lemagoup
2018-06-26  9:37   ` [PATCH v2] " Manu Gautam
2018-06-26  9:37     ` [v2] " Manu Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEz4NHpAYwgW0s7euAw4kWrc=V4Z9Oritu9+1rmkxmSwuZ5=ow@mail.gmail.com' \
    --to=lemagoup@gmail.com \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mgautam@codeaurora.org \
    --cc=vivek.gautam@codeaurora.org \
    --subject='Re: [PATCH v2] arm64: dts: msm8996: Use dwc3-qcom glue driver for USB' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.