From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f193.google.com ([209.85.223.193]:34411 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933688AbeGJPDe (ORCPT ); Tue, 10 Jul 2018 11:03:34 -0400 MIME-Version: 1.0 In-Reply-To: <87in64s97v.fsf@linux.intel.com> References: <20180531104710.23965-1-mgautam@codeaurora.org> <87r2ksshod.fsf@linux.intel.com> <87in64s97v.fsf@linux.intel.com> From: Pierre Le Magourou Date: Tue, 10 Jul 2018 17:03:32 +0200 Message-ID: Subject: Re: [PATCH v2] arm64: dts: msm8996: Use dwc3-qcom glue driver for USB Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org To: Felipe Balbi Cc: Vivek Gautam , Manu Gautam , andy.gross@linaro.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dianders@chromium.org, linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, bjorn.andersson@linaro.org List-ID: Hi Felipe, 2018-06-27 14:30 GMT+02:00 Felipe Balbi : > > looks like we need to do away with the wait_event_lock_irq() > call. usb_ep_dequeue() can be called from within the controller's > interrupt handler, so we can't rely on wait_event_lock_irq(). I guess > the best thing here would be to mark TRBs as dirty (and not increment > dequeue pointer), so they aren't reused by accident, then let endpoint > continue processing. Once command completion interrupt fires, we > increment dequeue pointer. > > This should work better, I suppose. Do you want a shot at implementing > this? I wrote a patch to implement this last week, and sent it to linux-arm-msm. Feel free to review it and tell me if this complies with what you suggested to me. Regards, Pierre Le Magourou From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] arm64: dts: msm8996: Use dwc3-qcom glue driver for USB From: lemagoup@gmail.com Message-Id: Date: Tue, 10 Jul 2018 17:03:32 +0200 To: Felipe Balbi Cc: Vivek Gautam , Manu Gautam , andy.gross@linaro.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dianders@chromium.org, linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, bjorn.andersson@linaro.org List-ID: SGkgRmVsaXBlLAoKMjAxOC0wNi0yNyAxNDozMCBHTVQrMDI6MDAgRmVsaXBlIEJhbGJpIDxmZWxp cGUuYmFsYmlAbGludXguaW50ZWwuY29tPjoKPgo+IGxvb2tzIGxpa2Ugd2UgbmVlZCB0byBkbyBh d2F5IHdpdGggdGhlIHdhaXRfZXZlbnRfbG9ja19pcnEoKQo+IGNhbGwuIHVzYl9lcF9kZXF1ZXVl KCkgY2FuIGJlIGNhbGxlZCBmcm9tIHdpdGhpbiB0aGUgY29udHJvbGxlcidzCj4gaW50ZXJydXB0 IGhhbmRsZXIsIHNvIHdlIGNhbid0IHJlbHkgb24gd2FpdF9ldmVudF9sb2NrX2lycSgpLiBJIGd1 ZXNzCj4gdGhlIGJlc3QgdGhpbmcgaGVyZSB3b3VsZCBiZSB0byBtYXJrIFRSQnMgYXMgZGlydHkg KGFuZCBub3QgaW5jcmVtZW50Cj4gZGVxdWV1ZSBwb2ludGVyKSwgc28gdGhleSBhcmVuJ3QgcmV1 c2VkIGJ5IGFjY2lkZW50LCB0aGVuIGxldCBlbmRwb2ludAo+IGNvbnRpbnVlIHByb2Nlc3Npbmcu IE9uY2UgY29tbWFuZCBjb21wbGV0aW9uIGludGVycnVwdCBmaXJlcywgd2UKPiBpbmNyZW1lbnQg ZGVxdWV1ZSBwb2ludGVyLgo+Cj4gVGhpcyBzaG91bGQgd29yayBiZXR0ZXIsIEkgc3VwcG9zZS4g RG8geW91IHdhbnQgYSBzaG90IGF0IGltcGxlbWVudGluZwo+IHRoaXM/CgpJIHdyb3RlIGEgcGF0 Y2ggdG8gaW1wbGVtZW50IHRoaXMgbGFzdCB3ZWVrLCBhbmQgc2VudCBpdCB0byBsaW51eC1hcm0t bXNtLgpGZWVsIGZyZWUgdG8gcmV2aWV3IGl0IGFuZCB0ZWxsIG1lIGlmIHRoaXMgY29tcGxpZXMg d2l0aCB3aGF0IHlvdQpzdWdnZXN0ZWQgdG8gbWUuCgpSZWdhcmRzLAoKUGllcnJlIExlIE1hZ291 cm91Ci0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5z dWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21v QHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJu ZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK