All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"bvanassche@acm.org" <bvanassche@acm.org>
Subject: Re: Nullblk configfs oddities
Date: Mon, 18 Apr 2022 18:02:08 -0400	[thread overview]
Message-ID: <CAEzrpqeHrrqqn7056Le8nmf+VbUugxXV2QjZeQTraW1dwJHviA@mail.gmail.com> (raw)
In-Reply-To: <c7f02531-8637-89a2-d8b7-1da03240db73@nvidia.com>

On Mon, Apr 18, 2022 at 5:54 PM Chaitanya Kulkarni
<chaitanyak@nvidia.com> wrote:
>
> On 4/18/22 14:38, Josef Bacik wrote:
> > Hello,
> >
> > I'm trying to add a test to fsperf and it requires the use of nullblk.  I'm
> > trying to use the configfs thing, and it's doing some odd things.  My basic
> > reproducer is
> >
> > modprobe null_blk
> > mkdir /sys/kernel/config/nullb/nullb0
> > echo some shit into the config
> > echo 1 > /sys/kernel/config/nullb/nullb0/power
> >
> > Now null_blk apparently defaults to nr_devices == 1, so it creates nullb0 on
> > modprobe.  But this doesn't show up in the configfs directory.  There's no way
> > to find this out until when I try to mkfs my nullb0 and it doesn't work.  The
> > above steps gets my device created at /dev/nullb1, but there's no actual way to
> > figure out that's what happened.  If I do something like
> > /sys/kernel/config/nullb/nullbfsperf I still just get nullb<number>, I don't get
> > my fancy name.
> >
>
> when you load module with default module parameter it will create a
> default device with no memory backed mode, that will not be visible in
> the configfs.
>
> So you need to load the module with nr_devices=0 that will prevent the
> null_blk to create the default device which is not memory backed and not
> present in the configfs:-
>

Yup I know what it's doing, I'm raising this as it's weird and took me
a bit to work out what was happening, and it annoyed me.  It's not
anything I can't work around, but the UX kinda sucks.  Thanks,

Josef

  reply	other threads:[~2022-04-18 22:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-18 21:38 Nullblk configfs oddities Josef Bacik
2022-04-18 21:54 ` Chaitanya Kulkarni
2022-04-18 22:02   ` Josef Bacik [this message]
2022-04-18 22:15     ` Chaitanya Kulkarni
2022-04-18 22:14   ` Jens Axboe
2022-04-18 22:21     ` Chaitanya Kulkarni
2022-04-18 22:24       ` Jens Axboe
2022-04-18 22:28         ` Josef Bacik
2022-04-19  4:23         ` Damien Le Moal
2022-04-19 14:49           ` Bart Van Assche
2022-05-03 20:20           ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEzrpqeHrrqqn7056Le8nmf+VbUugxXV2QjZeQTraW1dwJHviA@mail.gmail.com \
    --to=josef@toxicpanda.com \
    --cc=bvanassche@acm.org \
    --cc=chaitanyak@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.