All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hanley <jhanley@dgtlrift.com>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] .PO files modified under build
Date: Thu, 23 Mar 2017 10:11:23 -0400	[thread overview]
Message-ID: <CAF++6APQ=H6=-BmE=wJHzibKLcAGbP75FLOPJP3vX3kdeww+5Q@mail.gmail.com> (raw)

I have a git clone of qemu, and I build out of qemu-build...  essentially
the layout looks like:
./
  ./qemu/ -> clone of qemu
  ./qemu-build/
  ./Makefile

The contents of the top level Makefile contain the following rules:
rwildcard=$(wildcard $1$2) $(foreach d,$(wildcard $1*),$(call
rwildcard,$d/,$2))
files   := $(call rwildcard,qemu/,*.[ch])

.PHONY: clean_orphan_artifacts
clean_orphan_artifacts: $(note update)
        $(Q)                            \
        $(GIT_VERBOSE)  ;               \
        cd qemu &&                      \
        git clean -f -d -X
                $(call trace,GIT CLEAN)

qemu-build: qemu $(files) clean_orphan_artifacts
        $(Q)    \
        mkdir -p $(@)                   &&      \
        cd $(@)                         &&      \
        ../qemu/configure                       \
                --prefix=$(current_path)/local  \
                --target-list=arm-softmmu       \
                --disable-werror        &&      \
        $(MAKE)                         &&      \
        $(MAKE) install                         \
        $(call trace,BUILD)

It seems that somehow the .po files are being modified under the qemu repo
even though the entire build is out of ./qemu-build.

The two questions are:
   Should the .po files be modified under the qemu path when building out
of another (ie qemu-build)?
   Should the .po files continue to be versioned or placed in .gitignore if
they are (apparently) generated?

             reply	other threads:[~2017-03-23 14:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 14:11 James Hanley [this message]
2017-03-24 11:58 ` [Qemu-devel] .PO files modified under build Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF++6APQ=H6=-BmE=wJHzibKLcAGbP75FLOPJP3vX3kdeww+5Q@mail.gmail.com' \
    --to=jhanley@dgtlrift.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.