From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C93C2B9F4 for ; Fri, 25 Jun 2021 13:26:29 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id EC58961628 for ; Fri, 25 Jun 2021 13:26:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC58961628 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nfware.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA20A40698; Fri, 25 Jun 2021 15:26:27 +0200 (CEST) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by mails.dpdk.org (Postfix) with ESMTP id C1F254068A for ; Fri, 25 Jun 2021 15:26:26 +0200 (CEST) Received: by mail-ej1-f49.google.com with SMTP id ot9so14112393ejb.8 for ; Fri, 25 Jun 2021 06:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gb5yePXqQCrQniGotgXK2kJVXoL8qAVaFTUd1uhtogk=; b=E5moeGQpJ2GxPOZkIkibzAuQ5UJFWlKzrwhgnnLrOfH1vApbnUhZksQxRYVo+tNh3g wC7ANc8jHRjbcMZYeSt9x6IKi/TUdwyYGZxxwf6DUwz0G5s4Y9nLVuJU2EAQR3z6XYhl H++cyCy+JBqhVrnaGnAojTVazn/NEQAqrCi/jyoKY34GG4+XNTUuL5mxUjyw5ZEnT/Lc uqejATD5XNn1ubOvu9FSHVd2F1XzpjewN41P9FzUWlJDo5f82N2i5lSSiHYODNWP6OBR F/bx8MxjmEwyROUTzHBCTJ8IHDoQZBuyedUSXDIak1k0aHV1uwrOqW2RsVqlIqlvW6OO kWPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gb5yePXqQCrQniGotgXK2kJVXoL8qAVaFTUd1uhtogk=; b=A15m7Ow+V4rjD87lZDc6yfGA/E4CrjW4gHdMU16AsKeF0kzGuKpwdkA0d4ODVtDj/z JNFrwAxDJUBwEoLHCxIWcueMg8kQzvdkqj65qkK2+JE9ivy5SMfMttJeF0bYol+/f/ri t17crcBubJMcHSfa8p/nT7lAQZ222/KtJg3tsywMdQRndqq9LROQCeri46rlZxcPBVNO xtdGc2lCNu79w9vMbU4muxqGG6rzEx2kuGzwBNL2AGogwokX4KiuiMjtD4hu3JobZK5X iiVH5zMBOFSQK4FDSCR1gbN4oQtBL/GOK3cjUzfQpx9sXpNdJ9MRoEWN7n7dzHpQ1N8v +CBw== X-Gm-Message-State: AOAM532SzAFKbfZxsa//vybUo/BPOFE3/t10plGTlFsM6V7x3+ZvJbTM zqdiQoTleO5zYHiOmlT3IkHxc3t6do5u3RJkKpacEA== X-Google-Smtp-Source: ABdhPJx840alC+HXIYl8ntweZ97W4R+Yc+LyJLQswNYCinxuB2Q24SnxmxrF5V7GknJ3UrJgh+gCuADqCHV5zI0GXPY= X-Received: by 2002:a17:906:1792:: with SMTP id t18mr10748441eje.38.1624627586505; Fri, 25 Jun 2021 06:26:26 -0700 (PDT) MIME-Version: 1.0 References: <7ecdea57-f87e-6a1e-e52d-422a925046e4@ashroe.eu> In-Reply-To: From: Igor Ryzhov Date: Fri, 25 Jun 2021 16:26:14 +0300 Message-ID: To: Ferruh Yigit Cc: "Kinsella, Ray" , Thomas Monjalon , Stephen Hemminger , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] Experimental symbols in kni lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, all, Let's please discuss another approach to setting KNI link status before making this API stable: http://patches.dpdk.org/project/dpdk/patch/20190925093623.18419-1-iryzhov@nfware.com/ I explained the problem with the current implementation there. More than that, using ioctl approach makes it possible to set also speed and duplex and use them to implement get_link_ksettings callback. I can send patches for both features. Igor On Thu, Jun 24, 2021 at 4:54 PM Kinsella, Ray wrote: > Sounds more than reasonable, +1 from me. > > Ray K > > On 24/06/2021 14:24, Ferruh Yigit wrote: > > On 6/24/2021 11:42 AM, Kinsella, Ray wrote: > >> Hi Ferruh, > >> > >> The following kni experimental symbols are present in both v21.05 and > v19.11 release. These symbols should be considered for promotion to stable > as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= > 2yrs at this point. > >> > >> * rte_kni_update_link > >> > >> Ray K > >> > > > > Hi Ray, > > > > Thanks for follow up. > > > > I just checked the API and planning a small behavior update to it. > > If the update is accepted, I suggest keeping the API experimental for > 21.08 too, > > but can mature it on v21.11. > > > > Thanks, > > ferruh > > >