From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Ryzhov <iryzhov@nfware.com>
Subject: Re: [PATCH] kni: fix rte_kni_update_link
Date: Mon, 28 Jan 2019 16:49:19 +0300
Message-ID: <CAF+s_FzMp1AzPNG9oOCzSAT0yLZuSrzfFqVurXnatpqG2+vA1g@mail.gmail.com>
References: <20190124204749.49912-1-iryzhov@nfware.com>
 <CAF+s_FxDRtAtOQQTpiu-bXqDArJuagQZULaK9JGtEj1RDwwe+g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: stable@dpdk.org, dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com
 [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 5D29D5B16
 for <dev@dpdk.org>; Mon, 28 Jan 2019 14:49:31 +0100 (CET)
Received: by mail-pg1-f194.google.com with SMTP id j10so7248669pga.1
 for <dev@dpdk.org>; Mon, 28 Jan 2019 05:49:31 -0800 (PST)
In-Reply-To: <CAF+s_FxDRtAtOQQTpiu-bXqDArJuagQZULaK9JGtEj1RDwwe+g@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi again,

Sorry for bothering, I should have done more testing. It works as it is now.
So, self NACK on the patch.

Best regards,
Igor

On Mon, Jan 28, 2019 at 2:45 PM Igor Ryzhov <iryzhov@nfware.com> wrote:

> Hi Ferruh,
>
> Can you, please, take a look at this patch?
> The current implementation is broken, I think the patch should be merged
> into 19.02 and 18.11.1.
>
> Best regards,
> Igor
>
> On Thu, Jan 24, 2019 at 11:47 PM Igor Ryzhov <iryzhov@nfware.com> wrote:
>
>> After read, file offset must be set to 0 before write.
>> Otherwise, the third byte will be overwritten instead of the first.
>>
>> Fixes: c6fd54f28c24 ("kni: add function to set link state on kernel
>> interface")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>
>> ---
>>  lib/librte_kni/rte_kni.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c
>> index 73aeccccf..5899bb14a 100644
>> --- a/lib/librte_kni/rte_kni.c
>> +++ b/lib/librte_kni/rte_kni.c
>> @@ -746,6 +746,12 @@ rte_kni_update_link(struct rte_kni *kni, unsigned
>> int linkup)
>>         }
>>         old_linkup = (old_carrier[0] == '1');
>>
>> +       if (lseek(fd, 0, SEEK_SET) == -1) {
>> +               RTE_LOG(ERR, KNI, "Failed to change file position:
>> %s.\n", path);
>> +               close(fd);
>> +               return -1;
>> +       }
>> +
>>         new_carrier = linkup ? "1" : "0";
>>         ret = write(fd, new_carrier, 1);
>>         if (ret < 1) {
>> --
>> 2.20.1
>>
>>