From mboxrd@z Thu Jan  1 00:00:00 1970
From: Igor Ryzhov <iryzhov@nfware.com>
Subject: Re: [PATCH v2 1/5] kni: add API to set link status on
 kernel interface
Date: Fri, 28 Sep 2018 11:02:42 +0300
Message-ID: <CAF+s_FztUxxoq75ZgrdYk_atqYBqCC-NJ45ZdDpvTn_+Zkegsw@mail.gmail.com>
References: <20180911232906.18352-1-dg@adax.com>
 <20180919195549.5585-1-dg@adax.com>
 <20180919195549.5585-2-dg@adax.com>
 <671135e5-a666-4254-c5c6-672c3863146b@intel.com>
 <CAGyogRZx6THZuRreTLEBiYjZ8V_sbZk3HZywSprUU0PM5Wy7QA@mail.gmail.com>
 <e8ba3242-2aea-87bf-3dd2-c1522285620e@intel.com>
 <CAGyogRa5rF5B_0=U68Dj1A1cyQevO+Qeww-9zAh86ekce+n64A@mail.gmail.com>
 <61731242-db6c-0c5d-bcab-e82b45e324d7@intel.com>
 <CAGyogRZcZPBwj8JcE+--RHqx2SY-sZc0W1M26bSQkBVjyxZ_Mg@mail.gmail.com>
 <d76bffde-506c-49b6-8db6-cfa79ad983d3@intel.com>
 <CAGyogRaO95E=KN-J=oFroXVcPeZrAqOY4T+yDPWcGiHCZMpM0Q@mail.gmail.com>
 <846eed94-2ed7-7b89-5a3e-696ec3674a26@intel.com>
 <CAGyogRaNVQqgZLVsAHjH0Hwma6_Y+16CdjLpAkBg+Me3bL7xqw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
 Stephen Hemminger <stephen@networkplumber.org>
To: Dan Gora <dg@adax.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com
 [209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 7E54B1B154
 for <dev@dpdk.org>; Fri, 28 Sep 2018 10:02:54 +0200 (CEST)
Received: by mail-pf1-f194.google.com with SMTP id k21-v6so3748909pff.11
 for <dev@dpdk.org>; Fri, 28 Sep 2018 01:02:54 -0700 (PDT)
In-Reply-To: <CAGyogRaNVQqgZLVsAHjH0Hwma6_Y+16CdjLpAkBg+Me3bL7xqw@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Dan, Ferruh,

Why do we need "struct rte_eth_link" as a parameter at all?
Only link status is used in the function =E2=80=93 let's use it only:

rte_kni_update_link(struct rte_kni *kni, int link_status) /* 0 =E2=80=93 do=
wn, 1 =E2=80=93
up */

It will also solve your differences as we won't have any "redundant"
information to print :)

Best regards,
Igor

On Fri, Sep 28, 2018 at 2:52 AM Dan Gora <dg@adax.com> wrote:

> On Thu, Sep 27, 2018 at 8:44 PM, Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> >> Well, yes the link_status (link up, link down) _is_ applied to the KNI
> >> interface.  When that occurs, most people want to know what the link
> >> speed is that the link came up at.
> >
> > +1 to this, people would like to know link speed of the interface.
> > Are you printing link speed of interface? You are printing whatever use=
r
> pass to
> > API.
>
> There is no such thing as "link speed of the interface".  The link
> speed is the speed of the underlying Ethernet link that the interface
> corresponds to.  This is true for all other ethernet interfaces in the
> kernel.
>
> > I guess you trust to user to provide correct values there, but since
> only link
> > up & down matters, what prevents user to leave other fields, like speed=
,
> just
> > random values?
>
> Nothing.  What prevents anyone from providing random values for
> anything?  The point of the API was to make it super simple, just:
>
> rte_eth_link_get_nowait(portid, &link);
> rte_kni_update_link(p[portid]->kni[i], &link);
>
> No messing around with the link info retrieved from
> rte_eth_link_get(_nowait), just dump in the struct that was returned.
>