From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38596C47080 for ; Wed, 2 Jun 2021 01:06:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1549661159 for ; Wed, 2 Jun 2021 01:06:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229850AbhFBBIY (ORCPT ); Tue, 1 Jun 2021 21:08:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:36462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229687AbhFBBIW (ORCPT ); Tue, 1 Jun 2021 21:08:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9240161027 for ; Wed, 2 Jun 2021 01:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622596000; bh=jW/ATu8pEb4Sd//hBxYhELVxo4bcjLQROVsn3uX2jgM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Z5J4/SltIiNbmMf9YqCauwCkid2albzuuW512n5KnftVcKzsLK8m6MnNtC3xb0Zh0 HSkhgOiuZFFmeirh1cmbI9F0nH0RgOhCdSQClwu5nZLNwuwF+tlIl27om9CqyngvEu XxQtCF/3PZaV8lWITh8nZvrjPLbKKUrJ1VH4ZrGK54ylR7niK2je3v2TQMtTshW2/i 99TPXomLBFX0X6JrLJi/rc0pk4kyZ/ts1pmwuk4QlyLzBYzHL6nuxOCT4AJhL+urkX p0dVCP2J0Mrj8vVLu+M30f02k45YFyOqGpOz7nEIkdAJvEf62vqfxOj3abj1WOx0pz w86gwErmF+EnA== Received: by mail-lj1-f182.google.com with SMTP id f12so429967ljp.2 for ; Tue, 01 Jun 2021 18:06:40 -0700 (PDT) X-Gm-Message-State: AOAM5327PcGoG89TiZlC7aHj0rIaNxgH9WKfls+zclM35XgZ/W0Igfb9 uqKMOh6084fgHNw5mDTeeDWXbV2gIq/1mUTpRbA= X-Google-Smtp-Source: ABdhPJynHtrtnVj3WyNwivcsVRYyCCfB0UXfVBTTpKPFWZ4ZUz1kzzxJRC+3tIHOWzeeZOnSmGmnrhibeX8HGz+I168= X-Received: by 2002:a2e:9dcf:: with SMTP id x15mr23261591ljj.257.1622595998923; Tue, 01 Jun 2021 18:06:38 -0700 (PDT) MIME-Version: 1.0 References: <1622589753-9206-1-git-send-email-mlin@kernel.org> <1622589753-9206-3-git-send-email-mlin@kernel.org> In-Reply-To: From: Ming Lin Date: Tue, 1 Jun 2021 18:06:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] mm: adds NOSIGBUS extension for out-of-band shmem read To: Linus Torvalds Cc: Hugh Dickins , Simon Ser , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/1/2021 5:16 PM, Linus Torvalds wrote: > This series passes my "looks fine, is simple and straightforward" test. > > One nit: > > On Tue, Jun 1, 2021 at 1:22 PM Ming Lin wrote: >> >> + error = vm_insert_page(vma, (unsigned long)vmf->address, >> + ZERO_PAGE(0)); > > On architectures where this matters - bad virtual caches - it would be > better to use ZERO_PAGE(vmf->address). > > It doesn't make a difference on any sane architecture, but it's the > RightThing(tm) to do. grep -Rn ZERO_PAGE linux/arch/ | grep define s390 and mips do use the "address" of ZERO_PAGE(address) Fixed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 496FCC4708F for ; Wed, 2 Jun 2021 01:06:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D858C61003 for ; Wed, 2 Jun 2021 01:06:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D858C61003 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 762E26B006E; Tue, 1 Jun 2021 21:06:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 712BA6B0070; Tue, 1 Jun 2021 21:06:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58C7C6B0071; Tue, 1 Jun 2021 21:06:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 22E726B006E for ; Tue, 1 Jun 2021 21:06:42 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AC1C68249980 for ; Wed, 2 Jun 2021 01:06:41 +0000 (UTC) X-FDA: 78206993802.02.54E280E Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP id 4E3B66000148 for ; Wed, 2 Jun 2021 01:06:28 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8D8F061003 for ; Wed, 2 Jun 2021 01:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622596000; bh=jW/ATu8pEb4Sd//hBxYhELVxo4bcjLQROVsn3uX2jgM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Z5J4/SltIiNbmMf9YqCauwCkid2albzuuW512n5KnftVcKzsLK8m6MnNtC3xb0Zh0 HSkhgOiuZFFmeirh1cmbI9F0nH0RgOhCdSQClwu5nZLNwuwF+tlIl27om9CqyngvEu XxQtCF/3PZaV8lWITh8nZvrjPLbKKUrJ1VH4ZrGK54ylR7niK2je3v2TQMtTshW2/i 99TPXomLBFX0X6JrLJi/rc0pk4kyZ/ts1pmwuk4QlyLzBYzHL6nuxOCT4AJhL+urkX p0dVCP2J0Mrj8vVLu+M30f02k45YFyOqGpOz7nEIkdAJvEf62vqfxOj3abj1WOx0pz w86gwErmF+EnA== Received: by mail-lj1-f174.google.com with SMTP id bn21so437283ljb.1 for ; Tue, 01 Jun 2021 18:06:40 -0700 (PDT) X-Gm-Message-State: AOAM532ftCP5Fi/BuVzghVjbmt7hSEIxAYE383Gl7uAGjWiQf65a4FSk FefTkF2hehCdGSa7i2zDXB6NXqf5MSncqo4L5sg= X-Google-Smtp-Source: ABdhPJynHtrtnVj3WyNwivcsVRYyCCfB0UXfVBTTpKPFWZ4ZUz1kzzxJRC+3tIHOWzeeZOnSmGmnrhibeX8HGz+I168= X-Received: by 2002:a2e:9dcf:: with SMTP id x15mr23261591ljj.257.1622595998923; Tue, 01 Jun 2021 18:06:38 -0700 (PDT) MIME-Version: 1.0 References: <1622589753-9206-1-git-send-email-mlin@kernel.org> <1622589753-9206-3-git-send-email-mlin@kernel.org> In-Reply-To: From: Ming Lin Date: Tue, 1 Jun 2021 18:06:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] mm: adds NOSIGBUS extension for out-of-band shmem read To: Linus Torvalds Cc: Hugh Dickins , Simon Ser , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4E3B66000148 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Z5J4/Slt"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf25.hostedemail.com: domain of mlin@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=mlin@kernel.org X-Rspamd-Server: rspam03 X-Stat-Signature: qe94cheu8x7rz5nb77od9cjnprbc1f5r X-HE-Tag: 1622595988-16622 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/1/2021 5:16 PM, Linus Torvalds wrote: > This series passes my "looks fine, is simple and straightforward" test. > > One nit: > > On Tue, Jun 1, 2021 at 1:22 PM Ming Lin wrote: >> >> + error = vm_insert_page(vma, (unsigned long)vmf->address, >> + ZERO_PAGE(0)); > > On architectures where this matters - bad virtual caches - it would be > better to use ZERO_PAGE(vmf->address). > > It doesn't make a difference on any sane architecture, but it's the > RightThing(tm) to do. grep -Rn ZERO_PAGE linux/arch/ | grep define s390 and mips do use the "address" of ZERO_PAGE(address) Fixed.