From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EE77C43466 for ; Fri, 18 Sep 2020 03:52:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 144BE2311C for ; Fri, 18 Sep 2020 03:52:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="S4SaM1NG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726458AbgIRDwR (ORCPT ); Thu, 17 Sep 2020 23:52:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726260AbgIRDwR (ORCPT ); Thu, 17 Sep 2020 23:52:17 -0400 Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33A32C061756 for ; Thu, 17 Sep 2020 20:52:17 -0700 (PDT) Received: by mail-yb1-xb42.google.com with SMTP id 67so3308736ybt.6 for ; Thu, 17 Sep 2020 20:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Nme931I5f1UOsrOsO4Rb7WHHBrdHAMoy/1dfpIEkmUw=; b=S4SaM1NGJL7jkwHvKbSHmLJtNecMzgaGWgtOhwJ5PvGNoEFS9whv2xwQUVYUUt7Y+c 0Wlnmc1kw05G3htSrglqn2XjmqLNmqGbWoAINAzCVMtut0L8lMK5L7cGNUfwYy3SaOQs dKXdsv49srMvy5uV1fYnwxcR5cPazt1PH9h2nrMMdd8SfsmxuCpxk4Knk3m6yKUmRP6Z mft9aSK0zGa/6BBSu14M60iv9T7PutIyn081Ez6mUV/IH80E9i0hHSB7KBnJXk09CxZ4 WA4zIXuYP+lhCXo3fHmjwDl8ExTmcuqSOeLsdmbaOIoASBZTc5ocuQYG8fEWvaVBctgL TSCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Nme931I5f1UOsrOsO4Rb7WHHBrdHAMoy/1dfpIEkmUw=; b=PEvlKbeZ0fXYT9HJbtr6zS0oJR3LttGosE2gXkMwsUFWkha1nUDTGmHCsj/z9WZvG7 qj1OZYXsxNCsqaVC1crBzFQADygzq94hc8ZwWQ0FDTRb6ynPfVkWWcGorx0sb30a2cNz fzOyLYsBIZiftZxe0FO/3BNoj+4WCuBuEjBKRJCjrx0rIVF78b3XVL3ZCmexNEoOLrP8 3XMYz2QM0dftxAJWZXPUEIpDKbx7buSKkCB3L/nGRbKECac5DEVjWhnIzD1hEQG8A0Qa eXia1fIfUN/G2YeMzVoLsX0slcO/XT5CfZQlFsNY7fvgHgnhvyTFnxN6wh5Y4DwGmt+j c/Jw== X-Gm-Message-State: AOAM530FiTCSxeOTClbCu/C/Kte9OF7yz5sxLbB2QzZvytf6792XZjZ5 aw38noy9a2VvrxIkI90v/BVmhY0X+S1diRsIHeNJtUtMhZQ= X-Google-Smtp-Source: ABdhPJyLJTvEF5MXENMyCWAwK46pIB/PtI8Z5niW+AWW7qz0g5gvUjB4hunEZyEPL/VdhBZoP/lGOSsp/yKYtNBY3rY= X-Received: by 2002:a25:7606:: with SMTP id r6mr11568379ybc.42.1600401135999; Thu, 17 Sep 2020 20:52:15 -0700 (PDT) MIME-Version: 1.0 References: <20200917202313.143f66f3@canb.auug.org.au> <20f0b8f7-bbe8-fd31-819e-998054e41766@infradead.org> In-Reply-To: <20f0b8f7-bbe8-fd31-819e-998054e41766@infradead.org> From: =?UTF-8?B?TWFoZXNoIEJhbmRld2FyICjgpK7gpLngpYfgpLYg4KSs4KSC4KSh4KWH4KS14KS+4KSwKQ==?= Date: Thu, 17 Sep 2020 20:52:00 -0700 Message-ID: Subject: Re: linux-next: Tree for Sep 17 (netdevice.h: net_has_fallback_tunnels when SYSCTL is not set) To: Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , David Miller , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2020 at 1:33 PM Randy Dunlap wrote: > > On 9/17/20 3:23 AM, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20200916: > > > > I am seeing build errors when CONFIG_SYSCTL is not set: > > ld: net/ipv4/ip_tunnel.o: in function `ip_tunnel_init_net': > ip_tunnel.c:(.text+0x2ea0): undefined reference to `sysctl_fb_tunnels_only_for_init_net' > ld: net/ipv6/ip6_vti.o: in function `vti6_init_net': > ip6_vti.c:(.text+0x1b56): undefined reference to `sysctl_fb_tunnels_only_for_init_net' > ld: net/ipv6/sit.o: in function `sit_init_net': > sit.c:(.text+0x4568): undefined reference to `sysctl_fb_tunnels_only_for_init_net' > ld: net/ipv6/ip6_tunnel.o: in function `ip6_tnl_init_net': > ip6_tunnel.c:(.text+0x27d6): undefined reference to `sysctl_fb_tunnels_only_for_init_net' > ld: net/ipv6/ip6_gre.o: in function `ip6gre_init_net': > ip6_gre.c:(.text+0x3a5e): undefined reference to `sysctl_fb_tunnels_only_for_init_net' > > due to 316cdaa1158af: > > commit 316cdaa1158af17250397054f92bb339fbd8e282 > Author: Mahesh Bandewar > Date: Wed Aug 26 09:05:35 2020 -0700 > > net: add option to not create fall-back tunnels in root-ns as well > > > This was first reported to netdev@ on Sept. 02 but Mahesh was not cc-ed > on that report. > Thanks Randy for the report. Probably we shouldn't have removed the !ENBALED(CONFIG_SYSCTL) check. Let me cook a fix and send it. > > -- > ~Randy > Reported-by: Randy Dunlap