From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 10/10] xen: add per-platform defaults for NR_CPUS Date: Fri, 1 Jun 2018 03:49:17 +0100 Message-ID: References: <1527803317-31750-10-git-send-email-sstabellini@kernel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5422278396345212359==" Return-path: In-Reply-To: <1527803317-31750-10-git-send-email-sstabellini@kernel.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Stefano Stabellini Cc: artem_mygaiev@epam.com, lars.kurth@citrix.com, andrii_anisov@epam.com, andrew.cooper3@citrix.com, dfaggioli@suse.com, julien.grall@arm.com, JBeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============5422278396345212359== Content-Type: multipart/alternative; boundary="00000000000001e5ee056d8ba2d5" --00000000000001e5ee056d8ba2d5 Content-Type: text/plain; charset="UTF-8" Hi, Sorry for the formatting. I am pretty sure you need to CC "THE REST" here. On Thu, 31 May 2018, 22:50 Stefano Stabellini, wrote: > Add specific per-platform defaults for NR_CPUS. Note that the order of > the defaults matter: they need to go first, otherwise the generic > defaults will be applied. > > This is done so that Xen builds customized for a specific hardware > platform can have the right NR_CPUS number. > > Signed-off-by: Stefano Stabellini > CC: JBeulich@suse.com > CC: andrew.cooper3@citrix.com > --- > xen/arch/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig > index cf0acb7..d451eb8 100644 > --- a/xen/arch/Kconfig > +++ b/xen/arch/Kconfig > @@ -2,6 +2,9 @@ > config NR_CPUS > int "Maximum number of physical CPUs" > range 1 4095 > + default "8" if ARM && RCAR3 > + default "4" if ARM && QEMU > + default "4" if ARM && MPSOC > default "256" if X86 > default "128" if ARM > ---help--- > IMHO, it would make sense to move this option in the arch/{arm,x86)/Kconfig. But I am not sure how this will work as with this series you can select multiple platforms in on Kconfig. What will be the end result? Anyway, as I mention the way to go is a option list with only one possible choice. Cheers, -- > 1.9.1 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xenproject.org > https://lists.xenproject.org/mailman/listinfo/xen-devel --00000000000001e5ee056d8ba2d5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi,

Sorry for the formatting. I am pretty sure you need = to CC "THE REST" here.

<= div dir=3D"ltr">On Thu, 31 May 2018, 22:50 Stefano Stabellini, <sstabellini@kernel.org> wrote:
Add specific per-platform defaults fo= r NR_CPUS. Note that the order of
the defaults matter: they need to go first, otherwise the generic
defaults will be applied.

This is done so that Xen builds customized for a specific hardware
platform can have the right NR_CPUS number.

Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
CC: JBeulich@suse.co= m
CC: andrew.c= ooper3@citrix.com
---
=C2=A0xen/arch/Kconfig | 3 +++
=C2=A01 file changed, 3 insertions(+)

diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig
index cf0acb7..d451eb8 100644
--- a/xen/arch/Kconfig
+++ b/xen/arch/Kconfig
@@ -2,6 +2,9 @@
=C2=A0config NR_CPUS
=C2=A0 =C2=A0 =C2=A0 =C2=A0 int "Maximum number of physical CPUs"=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 range 1 4095
+=C2=A0 =C2=A0 =C2=A0 =C2=A0default "8" if ARM && RCAR3 +=C2=A0 =C2=A0 =C2=A0 =C2=A0default "4" if ARM && QEMU +=C2=A0 =C2=A0 =C2=A0 =C2=A0default "4" if ARM && MPSOC =C2=A0 =C2=A0 =C2=A0 =C2=A0 default "256" if X86
=C2=A0 =C2=A0 =C2=A0 =C2=A0 default "128" if ARM
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ---help---
IMHO, it would make sense to move this option in the arch/{arm,= x86)/Kconfig.

But I am not sure how this will work= as with this series you can select multiple platforms in on Kconfig. What = will be the end result?

Anyway, as I mention the w= ay to go is a option list with only one possible choice.

Cheers,


--
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-dev= el@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo= /xen-devel
--00000000000001e5ee056d8ba2d5-- --===============5422278396345212359== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============5422278396345212359==--