From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH 3/6] tests/modetest: silence compiler warning about uninitialised variables Date: Fri, 30 Aug 2013 11:21:56 -0400 Message-ID: References: <1377808314-30699-1-git-send-email-emil.l.velikov@gmail.com> <1377808314-30699-4-git-send-email-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f171.google.com (mail-ie0-f171.google.com [209.85.223.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F743E69E6 for ; Fri, 30 Aug 2013 08:21:56 -0700 (PDT) Received: by mail-ie0-f171.google.com with SMTP id 9so3463800iec.2 for ; Fri, 30 Aug 2013 08:21:56 -0700 (PDT) In-Reply-To: <1377808314-30699-4-git-send-email-emil.l.velikov@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Emil Velikov Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On Thu, Aug 29, 2013 at 4:31 PM, Emil Velikov wrote: > The compiler is unaware of that we have at least one crts/connector/plane > thus it complains that some of our variables will be used uninitialised. > > Signed-off-by: Emil Velikov Reviewed-by: Rob Clark > --- > > This patch looks like a rather silly thing to do, although it seems like > the only was to silence the gcc compiler > --- > tests/modetest/modetest.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c > index f96b930..ed604b4 100644 > --- a/tests/modetest/modetest.c > +++ b/tests/modetest/modetest.c > @@ -781,7 +781,7 @@ static struct crtc *pipe_find_crtc(struct device *dev, struct pipe_arg *pipe) > > static int pipe_find_crtc_and_mode(struct device *dev, struct pipe_arg *pipe) > { > - drmModeModeInfo *mode; > + drmModeModeInfo *mode = NULL; > int i; > > pipe->mode = NULL; > @@ -838,8 +838,8 @@ struct property_arg { > > static void set_property(struct device *dev, struct property_arg *p) > { > - drmModeObjectProperties *props; > - drmModePropertyRes **props_info; > + drmModeObjectProperties *props = NULL; > + drmModePropertyRes **props_info = NULL; > const char *obj_type; > int ret; > int i; > -- > 1.8.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel