From mboxrd@z Thu Jan 1 00:00:00 1970 From: robdclark@gmail.com (Rob Clark) Date: Thu, 17 Oct 2013 20:20:45 -0400 Subject: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver In-Reply-To: <20131008173418.0fc21d60@armhf> References: <20131006220728.GG12758@n2100.arm.linux.org.uk> <20131007111807.5e86ea6e@armhf> <20131007094404.GI12758@n2100.arm.linux.org.uk> <20131007124820.2189a4c3@armhf> <20131007110902.GL12758@n2100.arm.linux.org.uk> <20131008111913.09bfe93e@armhf> <20131008094939.GD25034@n2100.arm.linux.org.uk> <20131008173418.0fc21d60@armhf> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 8, 2013 at 11:34 AM, Jean-Francois Moine wrote: > On Tue, 8 Oct 2013 10:49:39 +0100 > Russell King - ARM Linux wrote: > >> On Tue, Oct 08, 2013 at 11:19:13AM +0200, Jean-Francois Moine wrote: >> > The Cubox is an open platform, and I use it just like a desktop PC. >> > When its required drivers will be in the mainline, I will do the same >> > as I do with PCs: I will not recompile a specific kernel each time >> > there are kernel bugs or security issues. Instead, I will just upgrade >> > my system from my distributor (Debian), and, in the packages, there >> > will be a generic mvebu kernel as there is already one for Marvell >> > Armada 370/xp, Freescale iMX5x/iMX6 (linux-image-3.10-3-armmp). >> > But, for that, all the Cubox specific stuff must be described in a DT. >> >> Which scenario is better: >> >> 1. To have something in mainline which is capable of driving the hardware, >> but may need some additional work to make it useful for DT based setups. >> >> or >> >> 2. To have nothing. >> >> Now, you may prefer to have nothing, but personally, I prefer there to be >> forward progress. Forward progress means getting some kind of DRM driver >> into mainline. Yes, it may not work with DT setups yet, but - as per >> the discussions that have happened _endlessly_ on this topic, it's >> something that can be resolved at a later date. >> >> We _still_ haven't worked out how to properly deal with the TDA998x >> driver (or indeed any DRM based outputs) in a DT based setup, and all >> the time that problem exists, it won't be possible to write a proper >> stable DT binding for this. >> >> So please, get off your hobby horse about this and allow us to make some >> modicum of progress. > > You forgot: > > 3. To have all patches ready for submission and have a working DT driven > Cubox kernel. No need to block this patch on DT support for all platforms that can use this driver. I don't see an issue with removing non-DT support later if it is no longer needed, or adding DT support in a future patch for platforms which can use it. So this patch looks fine to me. Signed-off-by: Rob Clark I will submit a patch to add DT to the tda998x driver as soon as I have > checked the new audio properties we talked about yesterday. > > Normally, this should have no impact on your Armada drm driver, and, > yes, I will add DT to your driver as soon as it will be accepted > (sorry to not ack it now: I had no time yet to have a look at it). > > -- > Ken ar c'henta? | ** Breizh ha Linux atav! ** > Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver Date: Thu, 17 Oct 2013 20:20:45 -0400 Message-ID: References: <20131006220728.GG12758@n2100.arm.linux.org.uk> <20131007111807.5e86ea6e@armhf> <20131007094404.GI12758@n2100.arm.linux.org.uk> <20131007124820.2189a4c3@armhf> <20131007110902.GL12758@n2100.arm.linux.org.uk> <20131008111913.09bfe93e@armhf> <20131008094939.GD25034@n2100.arm.linux.org.uk> <20131008173418.0fc21d60@armhf> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20131008173418.0fc21d60@armhf> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jean-Francois Moine Cc: Russell King - ARM Linux , Jason Cooper , David Airlie , "dri-devel@lists.freedesktop.org" , Daniel Vetter , "linux-arm-kernel@lists.infradead.org" , Sebastian Hesselbarth List-Id: dri-devel@lists.freedesktop.org On Tue, Oct 8, 2013 at 11:34 AM, Jean-Francois Moine wrot= e: > On Tue, 8 Oct 2013 10:49:39 +0100 > Russell King - ARM Linux wrote: > >> On Tue, Oct 08, 2013 at 11:19:13AM +0200, Jean-Francois Moine wrote: >> > The Cubox is an open platform, and I use it just like a desktop PC. >> > When its required drivers will be in the mainline, I will do the same >> > as I do with PCs: I will not recompile a specific kernel each time >> > there are kernel bugs or security issues. Instead, I will just upgrade >> > my system from my distributor (Debian), and, in the packages, there >> > will be a generic mvebu kernel as there is already one for Marvell >> > Armada 370/xp, Freescale iMX5x/iMX6 (linux-image-3.10-3-armmp). >> > But, for that, all the Cubox specific stuff must be described in a DT. >> >> Which scenario is better: >> >> 1. To have something in mainline which is capable of driving the hardwar= e, >> but may need some additional work to make it useful for DT based setu= ps. >> >> or >> >> 2. To have nothing. >> >> Now, you may prefer to have nothing, but personally, I prefer there to be >> forward progress. Forward progress means getting some kind of DRM driver >> into mainline. Yes, it may not work with DT setups yet, but - as per >> the discussions that have happened _endlessly_ on this topic, it's >> something that can be resolved at a later date. >> >> We _still_ haven't worked out how to properly deal with the TDA998x >> driver (or indeed any DRM based outputs) in a DT based setup, and all >> the time that problem exists, it won't be possible to write a proper >> stable DT binding for this. >> >> So please, get off your hobby horse about this and allow us to make some >> modicum of progress. > > You forgot: > > 3. To have all patches ready for submission and have a working DT driven > Cubox kernel. No need to block this patch on DT support for all platforms that can use this driver. I don't see an issue with removing non-DT support later if it is no longer needed, or adding DT support in a future patch for platforms which can use it. So this patch looks fine to me. Signed-off-by: Rob Clark I will submit a patch to add DT to the tda998x driver as soon as I have > checked the new audio properties we talked about yesterday. > > Normally, this should have no impact on your Armada drm driver, and, > yes, I will add DT to your driver as soon as it will be accepted > (sorry to not ack it now: I had no time yet to have a look at it). > > -- > Ken ar c'henta=F1 | ** Breizh ha Linux atav! ** > Jef | http://moinejf.free.fr/