From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH] drm/omap: call drm_put_dev directly in ->remove Date: Wed, 11 Dec 2013 14:35:57 -0500 Message-ID: References: <1386768034-27472-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f181.google.com (mail-ie0-f181.google.com [209.85.223.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 86FDCFA7D2 for ; Wed, 11 Dec 2013 11:35:58 -0800 (PST) Received: by mail-ie0-f181.google.com with SMTP id e14so11874268iej.12 for ; Wed, 11 Dec 2013 11:35:58 -0800 (PST) In-Reply-To: <1386768034-27472-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org On Wed, Dec 11, 2013 at 8:20 AM, Daniel Vetter wrote: > Again omap already sets the driver data pointer to the drm_device. > > v2: Don't rip out the platform_driver_unregister call for omap_dmm_driver. > Pesky difference between drm and dmm ... > > Cc: Rob Clark > Signed-off-by: Daniel Vetter looks better, thanks Reviewed-by: Rob Clark > --- > drivers/gpu/drm/omapdrm/omap_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c > index e7fa3cd96743..7be34b7d06f2 100644 > --- a/drivers/gpu/drm/omapdrm/omap_drv.c > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c > @@ -665,7 +665,7 @@ static int pdev_probe(struct platform_device *device) > static int pdev_remove(struct platform_device *device) > { > DBG(""); > - drm_platform_exit(&omap_drm_driver, device); > + drm_put_dev(platform_get_drvdata(device)); > > platform_driver_unregister(&omap_dmm_driver); > return 0; > -- > 1.8.4.3 >