From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH] omap2+: add drm device Date: Fri, 13 Jan 2012 13:53:27 -0600 Message-ID: References: <1326483687-458-1-git-send-email-rob.clark@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:36030 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753335Ab2AMTx2 convert rfc822-to-8bit (ORCPT ); Fri, 13 Jan 2012 14:53:28 -0500 Received: by vbmv11 with SMTP id v11so1438775vbm.19 for ; Fri, 13 Jan 2012 11:53:27 -0800 (PST) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Contreras Cc: linux-omap@vger.kernel.org, patches@linaro.org, Tomi Valkeinen , Andy Gross , Greg KH On Fri, Jan 13, 2012 at 1:49 PM, Felipe Contreras wrote: > On Fri, Jan 13, 2012 at 9:46 PM, Rob Clark wrote: >> On Fri, Jan 13, 2012 at 1:41 PM, Rob Clark wr= ote: >>> +/* files from staging that contain platform data structure definit= ions */ >>> +#include "../../../drivers/staging/omapdrm/omap_priv.h" >>> +#include "../../../drivers/staging/omapdrm/omap_dmm_tiler.h" >> >> btw, I'm not a huge fan of doing #includes this way, so if someone h= as >> a better suggestion (given that staging drivers should not have >> headers outside of drivers/staging) please let me know > > Move those structs to /arch/arm/plat-omap/drm.h? Can I do that? Maybe it depends of if you consider those structs as part of the driver, or part of the platform? I guess that looks like how it was handled for dspbridge, so maybe that means it is a suitable precedent.. BR, -R > -- > Felipe Contreras > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap"= in > the body of a message to majordomo@vger.kernel.org > More majordomo info at =A0http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html