From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7371FC433E0 for ; Fri, 15 May 2020 21:48:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D00920643 for ; Fri, 15 May 2020 21:48:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gv5cLZR2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727867AbgEOVsP (ORCPT ); Fri, 15 May 2020 17:48:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727814AbgEOVsP (ORCPT ); Fri, 15 May 2020 17:48:15 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED2CCC061A0C; Fri, 15 May 2020 14:48:14 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id s9so3490121eju.1; Fri, 15 May 2020 14:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LxeJwDOC4JESBFPEWaMDxHHvxvCUi5Rdm/ngJV7pp5o=; b=gv5cLZR2/19GNH1WNdqRaNYCRHAoQhvJOZeAe7DRqu0h3xx2h2zr0ED4THVChJ4Ku4 sxIguvV6iuWWddqwgeioUP1eppq6vKl6TQ7AwHLbROQTC/sx/SZcOLKH4ZcaRvHiyGQq xdFxCWMeiCKtaRfZixXSoz+VWbXbS1aNle/WIZquDuuO0H1XpFJiDTlB6vNWk5MzFkab CKN+zBEbZAtZnAo26vP7Y5JX+cpmNf7VY0gATjEm42BdrK4WdtJg0cwB9fnAoGKGAH+J aUCYBt8KZ7mhNeYnU7k1ZWgSHonazOf5gpvv/gCpm0m+jTUDbpVfGEPdpsrd7AF1ivmj k9cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LxeJwDOC4JESBFPEWaMDxHHvxvCUi5Rdm/ngJV7pp5o=; b=dOUM3MlQ7OYCotoXEQxnCcuDN5u8998uxAOFI4I2SGpUYu8OqJ9om4ewhkvdHM07Tt 8H//Ilug9/TkMEPoC39mRaFQGep/uexaKeIWcd7g5muzncVUdfxMdLnp4Tql6dyJTWot ptAHb6id81TqkACF4f2ciACElEPsiCIf0jW4qkyPUdFL6uZpWouJMeeeEztFuTuf1RzB SENXXs7zAk+JodtfXsAXn96Rc4Zp/y3jclpla7sGn7032p8F/f8sSmoIwCeEh6HAhb2l RrlRFyyFoViO8a4e5s7vbHIlC4h+ErDXc5MdweciPtaIhNZ50654SxkGsFV0tdCr5vOp H/+Q== X-Gm-Message-State: AOAM532umBtgkWc27RpgmKRqIhGPMBT9o62YB1rLhpBGPjS5HMGQc2dl R6PgKY+PtNMDoI9Uicmgzyvl1LXdBPgf39JoBDg= X-Google-Smtp-Source: ABdhPJxzQ1KczziCXxwnrq+IJ8zQvE+wvGpU2ZR+A70QjLCVg9dy4aM8cJQqI/HGsL979n/RLG/86VIcDk4qIuc8GO0= X-Received: by 2002:a17:906:2503:: with SMTP id i3mr4552438ejb.293.1589579293554; Fri, 15 May 2020 14:48:13 -0700 (PDT) MIME-Version: 1.0 References: <20200508163314.1.Idfa69d5d3fc9623083c0ff78572fea87dccb199c@changeid> In-Reply-To: <20200508163314.1.Idfa69d5d3fc9623083c0ff78572fea87dccb199c@changeid> From: Rob Clark Date: Fri, 15 May 2020 14:48:33 -0700 Message-ID: Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: Clear old error bits before AUX transfers To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Rob Clark , Jernej Skrabec , Jonas Karlman , David Airlie , linux-arm-msm , dri-devel , Sandeep Panda , Sean Paul , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, May 8, 2020 at 4:33 PM Douglas Anderson wrote: > > The AUX channel transfer error bits in the status register are latched > and need to be cleared. Clear them before doing our transfer so we > don't see old bits and get confused. > > Without this patch having a single failure would mean that all future > transfers would look like they failed. > > Fixes: b814ec6d4535 ("drm/bridge: ti-sn65dsi86: Implement AUX channel") > Signed-off-by: Douglas Anderson Reviewed-by: Rob Clark > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 6ad688b320ae..d865cc2565bc 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -827,6 +827,12 @@ static ssize_t ti_sn_aux_transfer(struct drm_dp_aux *aux, > buf[i]); > } > > + /* Clear old status bits before start so we don't get confused */ > + regmap_write(pdata->regmap, SN_AUX_CMD_STATUS_REG, > + AUX_IRQ_STATUS_NAT_I2C_FAIL | > + AUX_IRQ_STATUS_AUX_RPLY_TOUT | > + AUX_IRQ_STATUS_AUX_SHORT); > + > regmap_write(pdata->regmap, SN_AUX_CMD_REG, request_val | AUX_CMD_SEND); > > ret = regmap_read_poll_timeout(pdata->regmap, SN_AUX_CMD_REG, val, > -- > 2.26.2.645.ge9eca65c58-goog > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A76C433E1 for ; Fri, 15 May 2020 21:48:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FC2B20756 for ; Fri, 15 May 2020 21:48:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gv5cLZR2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FC2B20756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F1716ED4C; Fri, 15 May 2020 21:48:16 +0000 (UTC) Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46B266ED4C for ; Fri, 15 May 2020 21:48:15 +0000 (UTC) Received: by mail-ej1-x644.google.com with SMTP id e2so3412231eje.13 for ; Fri, 15 May 2020 14:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LxeJwDOC4JESBFPEWaMDxHHvxvCUi5Rdm/ngJV7pp5o=; b=gv5cLZR2/19GNH1WNdqRaNYCRHAoQhvJOZeAe7DRqu0h3xx2h2zr0ED4THVChJ4Ku4 sxIguvV6iuWWddqwgeioUP1eppq6vKl6TQ7AwHLbROQTC/sx/SZcOLKH4ZcaRvHiyGQq xdFxCWMeiCKtaRfZixXSoz+VWbXbS1aNle/WIZquDuuO0H1XpFJiDTlB6vNWk5MzFkab CKN+zBEbZAtZnAo26vP7Y5JX+cpmNf7VY0gATjEm42BdrK4WdtJg0cwB9fnAoGKGAH+J aUCYBt8KZ7mhNeYnU7k1ZWgSHonazOf5gpvv/gCpm0m+jTUDbpVfGEPdpsrd7AF1ivmj k9cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LxeJwDOC4JESBFPEWaMDxHHvxvCUi5Rdm/ngJV7pp5o=; b=KqoeOKLTMVriHF+3xooyAYaVkN+23QoZhaZuO7gkwDDjrZRm2OEtuh0CAueriQR3zM 713CyG3XGIQnB1mDzb024IcTJAC/U3RAOpPBTtXsh+v3MtD0RF3RElxxJ6iD9cCPSg8+ bBUesPm2RWetZ0A0KtaZNxUwtKkke7BQ20w72SPiuy1/BB3j2Vxpk0o8//xUaKxJISoX J/ZC/BdmuPUlO4u5i01BraDL7h9To44M3ouX3IkCNT5+Q9T2cBL4sLGu3HvTsFXavtqw 7RBwoWJz/0yHmuLQeOupupMDAb4JKRlJVBuM7AOs3y2nE1guiar0YpgfxJc7AAAvzbBh 9EnA== X-Gm-Message-State: AOAM531fqemvk3Rxt7iz3gFMYwtRAIoblr4VJ/xCH5GcD087V59NfV++ D2y+FieLO0NETdjzcM98LAfN/acGjDvn3zk/hLU= X-Google-Smtp-Source: ABdhPJxzQ1KczziCXxwnrq+IJ8zQvE+wvGpU2ZR+A70QjLCVg9dy4aM8cJQqI/HGsL979n/RLG/86VIcDk4qIuc8GO0= X-Received: by 2002:a17:906:2503:: with SMTP id i3mr4552438ejb.293.1589579293554; Fri, 15 May 2020 14:48:13 -0700 (PDT) MIME-Version: 1.0 References: <20200508163314.1.Idfa69d5d3fc9623083c0ff78572fea87dccb199c@changeid> In-Reply-To: <20200508163314.1.Idfa69d5d3fc9623083c0ff78572fea87dccb199c@changeid> From: Rob Clark Date: Fri, 15 May 2020 14:48:33 -0700 Message-ID: Subject: Re: [PATCH] drm/bridge: ti-sn65dsi86: Clear old error bits before AUX transfers To: Douglas Anderson X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Jernej Skrabec , Jonas Karlman , David Airlie , linux-arm-msm , Neil Armstrong , Sandeep Panda , dri-devel , Linux Kernel Mailing List , Andrzej Hajda , Sean Paul , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 8, 2020 at 4:33 PM Douglas Anderson wrote: > > The AUX channel transfer error bits in the status register are latched > and need to be cleared. Clear them before doing our transfer so we > don't see old bits and get confused. > > Without this patch having a single failure would mean that all future > transfers would look like they failed. > > Fixes: b814ec6d4535 ("drm/bridge: ti-sn65dsi86: Implement AUX channel") > Signed-off-by: Douglas Anderson Reviewed-by: Rob Clark > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 6ad688b320ae..d865cc2565bc 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -827,6 +827,12 @@ static ssize_t ti_sn_aux_transfer(struct drm_dp_aux *aux, > buf[i]); > } > > + /* Clear old status bits before start so we don't get confused */ > + regmap_write(pdata->regmap, SN_AUX_CMD_STATUS_REG, > + AUX_IRQ_STATUS_NAT_I2C_FAIL | > + AUX_IRQ_STATUS_AUX_RPLY_TOUT | > + AUX_IRQ_STATUS_AUX_SHORT); > + > regmap_write(pdata->regmap, SN_AUX_CMD_REG, request_val | AUX_CMD_SEND); > > ret = regmap_read_poll_timeout(pdata->regmap, SN_AUX_CMD_REG, val, > -- > 2.26.2.645.ge9eca65c58-goog > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel