From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rob Clark <robdclark@gmail.com>
Subject: Re: [PATCH 1/2] drm: store the gem vma offset manager in a typed
	pointer
Date: Tue, 17 Dec 2013 20:22:06 -0500
Message-ID: <CAF6AEGsh6ewJT9vr2MPycL3YpTcgRS5g73bOhgRGa64cGahwbQ@mail.gmail.com>
References: <CANq1E4R3UK5=pe7LNheX31QkiV_CGx3PRCWp4XLcBQ9tTo3rSA@mail.gmail.com>
	<1386768287-30353-1-git-send-email-daniel.vetter@ffwll.ch>
	<CAPM=9twfaOWuapjbEB=rE6=kc=5gPXHv-mM5n-nfMWyV2XT0pQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-ie0-f169.google.com (mail-ie0-f169.google.com
	[209.85.223.169])
	by gabe.freedesktop.org (Postfix) with ESMTP id 11DC7FD7EC
	for <dri-devel@lists.freedesktop.org>;
	Tue, 17 Dec 2013 17:22:08 -0800 (PST)
Received: by mail-ie0-f169.google.com with SMTP id e14so9571021iej.28
	for <dri-devel@lists.freedesktop.org>;
	Tue, 17 Dec 2013 17:22:07 -0800 (PST)
In-Reply-To: <CAPM=9twfaOWuapjbEB=rE6=kc=5gPXHv-mM5n-nfMWyV2XT0pQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Dave Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On Tue, Dec 17, 2013 at 8:04 PM, Dave Airlie <airlied@gmail.com> wrote:
> On Wed, Dec 11, 2013 at 11:24 PM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>> This was hidden in a generic void * dev->mm_private. But only ever
>> used for gem. But thanks to this fake generic pretension no one
>> noticed that Rob's drm drivers are now all broken.
>
> Should this go to fixes?

I think should go in fixes probably.. wasn't it broken since vma
offset mgr?  I guess I don't test debugfs enough.

oh, and:

Signed-off-by: Rob Clark <robdclark@gmail.com>

(sorry, overlooked this thread earlier, even though I think Daniel
mentioned the issue on irc)

> Or is the problem only introduced in this series?
>
> Dave.
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel