From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH 04/50] drm/tilcdc: call drm_put_dev directly from ->remove Date: Wed, 11 Dec 2013 14:39:00 -0500 Message-ID: References: <1386758111-3446-1-git-send-email-daniel.vetter@ffwll.ch> <1386758111-3446-5-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com [209.85.223.182]) by gabe.freedesktop.org (Postfix) with ESMTP id 46794FA366 for ; Wed, 11 Dec 2013 11:39:01 -0800 (PST) Received: by mail-ie0-f182.google.com with SMTP id as1so11860416iec.27 for ; Wed, 11 Dec 2013 11:39:00 -0800 (PST) In-Reply-To: <1386758111-3446-5-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org On Wed, Dec 11, 2013 at 5:34 AM, Daniel Vetter wrote: > tilcdc already stores the drm_device in the driver data pointer. So > use that. > > Cc: Rob Clark > Signed-off-by: Daniel Vetter Reviewed-by: Rob Clark > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index 116da199b942..e6d77d02e444 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -594,7 +594,7 @@ static int tilcdc_pdev_probe(struct platform_device *pdev) > > static int tilcdc_pdev_remove(struct platform_device *pdev) > { > - drm_platform_exit(&tilcdc_driver, pdev); > + drm_put_dev(platform_get_drvdata(pdev)); > > return 0; > } > -- > 1.8.4.3 >