From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1321BC433EF for ; Mon, 20 Sep 2021 18:27:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA96F61168 for ; Mon, 20 Sep 2021 18:27:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA96F61168 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 126F76E5BE; Mon, 20 Sep 2021 18:27:33 +0000 (UTC) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 567BF6E5BE; Mon, 20 Sep 2021 18:27:32 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id d21so32294608wra.12; Mon, 20 Sep 2021 11:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y9zwU5sYqKQSmloO/YdgRLqeETN2yQaV2Mq9YoCcAeI=; b=SyirlfFaRyUdz9gloQTpR5LDjfVwEkVbGAKz3rA4+raBnbaIk7GgLE3cRNSVmNsJ2T JkAkx5J15BZqvGTnXpSAtMhcW8GIpbkKYz2o/fjKqnI7nvBKVq2Jtz7IbC8Fxfend/aT cCRjbtW6tlCL62XP7oma8j5FxslfQyutluSRo3uL68wvPMjUlYshaafTq0nWn7rc+/K0 X23Cy/6Zd2aJ/yV5Bd1gNBmWM7UE1ZhKunrY3CvgiHOnnJEeBbf3dekuSIuwb6Q/2klJ ROAo5Rgkac0ZG3z2/sAy1GbRbPopzBsEH3+I1VBUbmtoYuVc/qLJlZm084MYYLGUrKoK +CPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y9zwU5sYqKQSmloO/YdgRLqeETN2yQaV2Mq9YoCcAeI=; b=QSHGjVKeQaf7Et0xh/372SwaU1yUkqdqGuEkuwK8InOLb+E4DiH+J3kKUbuD3y5Ii/ AQNuzs2Jr5z5pOUX650jfuU1gYWxurbKoEE/zUWfiAIo0JOFmYdzCPgkxt8IgnyFUqiH 00VVPtcGdIZT5DIcjoRM16lk0uhtfXP0vi+ZGBAoMYif21aORIX0r9qmlAOL0H0DvOex m1XLhjq2Qi8rlR9nESVqRwn3r5QPXBNdj07qOTu4H82UScJIUC9NzGwryi3nkp3lvdeF uFElBaOaEJd7IG8jiCqFE4FBkclWlhHAU3v7t7OD5ddjGrj+Jue7gD0aOngEMPOTP5pN Af6A== X-Gm-Message-State: AOAM530zVOGwFWoh3GATZCe1Io9G91TCWUpmch+EOXBTnpBUH5TYmXlG 11OGjQN60BluODY32RI4W4SSUdZBkrmNB4qxbAU= X-Google-Smtp-Source: ABdhPJw/EQD0n+XxVEqlN0NQvPPWtr7hnSNfLxBFHmeACTGd4fEURr8HGGl7QADWcofo1LfgcxwBHTMNCADEDP4umVY= X-Received: by 2002:adf:e5c2:: with SMTP id a2mr29789784wrn.251.1632162450723; Mon, 20 Sep 2021 11:27:30 -0700 (PDT) MIME-Version: 1.0 References: <20210811235253.924867-1-robdclark@gmail.com> <20210811235253.924867-5-robdclark@gmail.com> In-Reply-To: From: Rob Clark Date: Mon, 20 Sep 2021 11:32:02 -0700 Message-ID: Subject: Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support To: Doug Anderson Cc: Laurent Pinchart , dri-devel , linux-arm-msm , freedreno , Stephen Boyd , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , open list Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Aug 12, 2021 at 1:08 PM Doug Anderson wrote: > > Laurent, > > On Thu, Aug 12, 2021 at 12:26 PM Laurent Pinchart > wrote: > > > > Hi Rob, > > > > Thank you for the patch. > > > > On Wed, Aug 11, 2021 at 04:52:50PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Slightly awkward to fish out the display_info when we aren't creating > > > own connector. But I don't see an obvious better way. > > > > We need a bit more than this, to support the NO_CONNECTOR case, the > > bridge has to implement a few extra operations, and set the bridge .ops > > field. I've submitted two patches to do so a while ago: > > > > - [RFC PATCH 08/11] drm/bridge: ti-sn65dsi86: Implement bridge connector operations ([1]) > > Rob asked me about this over IRC, so if he left it out and it's needed > then it's my fault. However, I don't believe it's needed until your > series making this bridge chip support full DP. For the the eDP case > the bridge chip driver in ToT no longer queries the EDID itself. It > simply provides an AUX bus to the panel driver and the panel driver > queries the EDID. I think that means we don't need to add > DRM_BRIDGE_OP_EDID, right? > > I was also wondering if in the full DP case we should actually model > the physical DP jack as a drm_bridge and have it work the same way. It > would get probed via the DP AUX bus just like a panel. I seem to > remember Stephen Boyd was talking about modeling the DP connector as a > drm_bridge because it would allow us to handle the fact that some TCPC > chips could only support HBR2 whereas others could support HBR3. Maybe > it would end up being a fairly elegant solution? > > > - [RFC PATCH 09/11] drm/bridge: ti-sn65dsi86: Make connector creation optional ([2]) > > > > The second patch is similar to the first half of this patch, but misses > > the cleanup code. I'll try to rebase this and resubmit, but it may take > > a bit of time. > > Whoops! You're right that Rob's patch won't work at all because we'll > just hit the "Fix bridge driver to make connector optional!" case. I > should have noticed that. :( Yes, indeed.. once I fix that, I get no display.. Not sure if Laurent is still working on his series, otherwise I can try to figure out what bridge ops are missing BR, -R From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 049F6C433EF for ; Tue, 21 Sep 2021 02:19:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF36B61242 for ; Tue, 21 Sep 2021 02:19:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347375AbhIUCUc (ORCPT ); Mon, 20 Sep 2021 22:20:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343753AbhIUCMK (ORCPT ); Mon, 20 Sep 2021 22:12:10 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FD01C08EE15; Mon, 20 Sep 2021 11:27:32 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id u18so30610634wrg.5; Mon, 20 Sep 2021 11:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=y9zwU5sYqKQSmloO/YdgRLqeETN2yQaV2Mq9YoCcAeI=; b=SyirlfFaRyUdz9gloQTpR5LDjfVwEkVbGAKz3rA4+raBnbaIk7GgLE3cRNSVmNsJ2T JkAkx5J15BZqvGTnXpSAtMhcW8GIpbkKYz2o/fjKqnI7nvBKVq2Jtz7IbC8Fxfend/aT cCRjbtW6tlCL62XP7oma8j5FxslfQyutluSRo3uL68wvPMjUlYshaafTq0nWn7rc+/K0 X23Cy/6Zd2aJ/yV5Bd1gNBmWM7UE1ZhKunrY3CvgiHOnnJEeBbf3dekuSIuwb6Q/2klJ ROAo5Rgkac0ZG3z2/sAy1GbRbPopzBsEH3+I1VBUbmtoYuVc/qLJlZm084MYYLGUrKoK +CPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y9zwU5sYqKQSmloO/YdgRLqeETN2yQaV2Mq9YoCcAeI=; b=hpEndldJR5rQZssKX9SmBbm9fU/ZNXnn1LU92u9L9nMxXXl4XyAEi6ld3/st/KtdLH +SnIXcuda0raa1ikpvM6XfrYf6B6jq7ZOeJbC+7gSclCXgbZkVLHXt0Ln1usngmp6RWx gS/+dyvdNHAFVrRZN/AvQ9FHj3fwoe99C9RUmugPP1KYiqGitCapHve0qrDtsXXIdqpJ gSemyPERbkEwOmnFTZZNin68iGRt4eA1Ct5b3TRRg/1gnTm/5xXerN2Sem9nanVu+sYL jWyGfpRVCLT2AjGr6YSu1uIkuqof/HScR7n5Hhq7WoIW94o11FfE5hP5c50XBh29yg2v hgIw== X-Gm-Message-State: AOAM533jqDbm9dBXAYMHQ7Wsyhxwj/ehGUs8lz7SRpxP/Oo3OBWvWBmS ZoX4czQW1PrGAP1UsGdLCCVKrfb4MFzJtJYEXuA= X-Google-Smtp-Source: ABdhPJw/EQD0n+XxVEqlN0NQvPPWtr7hnSNfLxBFHmeACTGd4fEURr8HGGl7QADWcofo1LfgcxwBHTMNCADEDP4umVY= X-Received: by 2002:adf:e5c2:: with SMTP id a2mr29789784wrn.251.1632162450723; Mon, 20 Sep 2021 11:27:30 -0700 (PDT) MIME-Version: 1.0 References: <20210811235253.924867-1-robdclark@gmail.com> <20210811235253.924867-5-robdclark@gmail.com> In-Reply-To: From: Rob Clark Date: Mon, 20 Sep 2021 11:32:02 -0700 Message-ID: Subject: Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support To: Doug Anderson Cc: Laurent Pinchart , dri-devel , linux-arm-msm , freedreno , Stephen Boyd , Rob Clark , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Aug 12, 2021 at 1:08 PM Doug Anderson wrote: > > Laurent, > > On Thu, Aug 12, 2021 at 12:26 PM Laurent Pinchart > wrote: > > > > Hi Rob, > > > > Thank you for the patch. > > > > On Wed, Aug 11, 2021 at 04:52:50PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > Slightly awkward to fish out the display_info when we aren't creating > > > own connector. But I don't see an obvious better way. > > > > We need a bit more than this, to support the NO_CONNECTOR case, the > > bridge has to implement a few extra operations, and set the bridge .ops > > field. I've submitted two patches to do so a while ago: > > > > - [RFC PATCH 08/11] drm/bridge: ti-sn65dsi86: Implement bridge connector operations ([1]) > > Rob asked me about this over IRC, so if he left it out and it's needed > then it's my fault. However, I don't believe it's needed until your > series making this bridge chip support full DP. For the the eDP case > the bridge chip driver in ToT no longer queries the EDID itself. It > simply provides an AUX bus to the panel driver and the panel driver > queries the EDID. I think that means we don't need to add > DRM_BRIDGE_OP_EDID, right? > > I was also wondering if in the full DP case we should actually model > the physical DP jack as a drm_bridge and have it work the same way. It > would get probed via the DP AUX bus just like a panel. I seem to > remember Stephen Boyd was talking about modeling the DP connector as a > drm_bridge because it would allow us to handle the fact that some TCPC > chips could only support HBR2 whereas others could support HBR3. Maybe > it would end up being a fairly elegant solution? > > > - [RFC PATCH 09/11] drm/bridge: ti-sn65dsi86: Make connector creation optional ([2]) > > > > The second patch is similar to the first half of this patch, but misses > > the cleanup code. I'll try to rebase this and resubmit, but it may take > > a bit of time. > > Whoops! You're right that Rob's patch won't work at all because we'll > just hit the "Fix bridge driver to make connector optional!" case. I > should have noticed that. :( Yes, indeed.. once I fix that, I get no display.. Not sure if Laurent is still working on his series, otherwise I can try to figure out what bridge ops are missing BR, -R