From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 165C6C433EF for ; Tue, 1 Mar 2022 17:45:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232482AbiCARpy (ORCPT ); Tue, 1 Mar 2022 12:45:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236614AbiCARpw (ORCPT ); Tue, 1 Mar 2022 12:45:52 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 326632AC6C; Tue, 1 Mar 2022 09:45:11 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id r10so21748083wrp.3; Tue, 01 Mar 2022 09:45:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LCKZuqBaQrqVvcLu/EUZDoUvEFQ31pI7qQ+wygT5714=; b=GgdmWlO6xVaLOUNuLj+YvNsSoAlTqMq+dOrCyEjLKS+ZFbI2FQbSkpU2ikDfOzkS63 fgIHsSAFVJRTiXxioBvPS3Fj5Spj2nIxhcf2L7R24GTdQHbeGQvQjtZgzBZ/HE+QNYJA iHjXoDqknYBPfOULvIzlb2BeMyItKLFDk0d9hVXJe3mtde2171/FtAcKiIgiAURpFuOU /epZze29QyzrVoZGY1GgRHXmkgHyQuzsLFB/cP1oufq80EOxPWTAQ7xwZD4ElrD/Ck99 ptIoFxorgkey4MAKh+JiiQMTS+K3YJlcQf+6XnCZcc8xtgx2W05S2wMssyHlyn/TMk7/ DN6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LCKZuqBaQrqVvcLu/EUZDoUvEFQ31pI7qQ+wygT5714=; b=H/UPYG/ks8na1TXBmlSUxf279velAzY15/vcuX0RsP8lsn3THLwmdpStSbu7rFDJeP ZyMuJdyUQDU1y036DxZLLBayBQyKb2BtvVrdMyzNOP7vpg9wLd6uCqSTxgwqO+mmf6D+ 4mtS/euVvuAZq9h1L6EUlPfIi34D/vbe1FmgB/FJ7Q1yAZfLaZcftl/fhvmnBDEVAfSq Ib7jbcvikcSQwsXyuDdt5l3TmzoAo7DMpaflxr+i3vkzr64SjmostX58z/mUBgSUosDG v9NUdKzfhOL8mqlFnC2tbNZQhtKw9oHA/s/V9M3m2IPeqm9J5gM0ApA221o4YYtB3+je LbBw== X-Gm-Message-State: AOAM533EDXIJ0qJ+Gvv7Z/sYx8rwPTe0nYj8LjLBaAWfhyVQArG41qAf Imy+3y9ruEb14+BklZYRFtdjGDgSxj6Ah6ZwQ1g= X-Google-Smtp-Source: ABdhPJwQNgpFjfl73NGhoHP4atwM/20R77juX1EAsRkGpJfhZO7TsJePIDQE5ElT3fRCwE7agOirdL04RUfznC8bUXE= X-Received: by 2002:a5d:44c7:0:b0:1ed:e11c:9b73 with SMTP id z7-20020a5d44c7000000b001ede11c9b73mr19967467wrr.574.1646156709718; Tue, 01 Mar 2022 09:45:09 -0800 (PST) MIME-Version: 1.0 References: <1644349472-31077-1-git-send-email-quic_abhinavk@quicinc.com> <654d620b-9e14-c47f-b48c-762dc0bd32a1@quicinc.com> <7db7d01fcf5a3edce61161769c0e6eb1541237bf.camel@sipsolutions.net> <2add9ba7-7bc8-bd1d-1963-61e8154b0e3c@quicinc.com> <989efb15-cc5e-8f6d-c313-118f01498e33@quicinc.com> <8fa2f879e33e4e42b76e21c6fbdcb023@AcuMS.aculab.com> In-Reply-To: <8fa2f879e33e4e42b76e21c6fbdcb023@AcuMS.aculab.com> From: Rob Clark Date: Tue, 1 Mar 2022 09:45:39 -0800 Message-ID: Subject: Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins To: David Laight Cc: Abhinav Kumar , Johannes Berg , Greg KH , "rafael@kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "swboyd@chromium.org" , "khsieh@codeaurora.org" , "nganji@codeaurora.org" , "seanpaul@chromium.org" , "dmitry.baryshkov@linaro.org" , "aravindh@codeaurora.org" , "freedreno@lists.freedesktop.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Feb 28, 2022 at 10:49 PM David Laight wrote: > > From: Abhinav Kumar > > Sent: 28 February 2022 21:38 > ... > > We also did some profiling around how much increasing the block size > > helps and here is the data: > > > > Block size cost > > > > 4KB 229s > > 8KB 86s > > You must have an O(n^2) operation in there - find it. The problem is how the devcoredump/sysfs interface works, which results in "re-rendering" the output for each block.. it's fine for moderate size sysfs files, but scales quite badly once you get into couple MB size sysfs files. It could be fixed by having some way to keep state across successive read callbacks. BR, -R > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A7CCC433F5 for ; Tue, 1 Mar 2022 17:45:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 33FD510E5C6; Tue, 1 Mar 2022 17:45:13 +0000 (UTC) Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F27510E5A6; Tue, 1 Mar 2022 17:45:11 +0000 (UTC) Received: by mail-wr1-x429.google.com with SMTP id ay10so3878979wrb.6; Tue, 01 Mar 2022 09:45:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LCKZuqBaQrqVvcLu/EUZDoUvEFQ31pI7qQ+wygT5714=; b=GgdmWlO6xVaLOUNuLj+YvNsSoAlTqMq+dOrCyEjLKS+ZFbI2FQbSkpU2ikDfOzkS63 fgIHsSAFVJRTiXxioBvPS3Fj5Spj2nIxhcf2L7R24GTdQHbeGQvQjtZgzBZ/HE+QNYJA iHjXoDqknYBPfOULvIzlb2BeMyItKLFDk0d9hVXJe3mtde2171/FtAcKiIgiAURpFuOU /epZze29QyzrVoZGY1GgRHXmkgHyQuzsLFB/cP1oufq80EOxPWTAQ7xwZD4ElrD/Ck99 ptIoFxorgkey4MAKh+JiiQMTS+K3YJlcQf+6XnCZcc8xtgx2W05S2wMssyHlyn/TMk7/ DN6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LCKZuqBaQrqVvcLu/EUZDoUvEFQ31pI7qQ+wygT5714=; b=4jiHEIiHiuG3h9QUgINlxWIk3oplB1MKgpBP6JBa9JB8IqQiZyK6njoy0Y1UgForyJ 5JJ8y4sbMFQj+BduZlgxkXCI6Z+IoJh2h42zfW5dzSVxdUS8oJGi8w3X1eUTWd/3We5X lWsxY/K70x/2NJd4BOT4tN8Yvdczl0YOQz1/AJzpw1wSygLQLyS8SHNeiDvwlxnEBCBb 8X+s4i4rxtppHYGh/XisCc6BCFf2zsHx04evgJaXpMKhM0on5T+DvdiASn/doCSNes2n NUs7wEGWZA9k0WNTfB21aEXdU4+BPeEolQdk4OiVDVt60FZchMIukIGiMbx6FWsy9U4e Ua3Q== X-Gm-Message-State: AOAM5316o19Pxej4XZtaiG8/2nc0RlO3qCA5rESRvEH8j2C0fCGiBJ7v 2ONs9E1kaoVTbKemI8rkOT+nLBLABUYb2CtoHB8= X-Google-Smtp-Source: ABdhPJwQNgpFjfl73NGhoHP4atwM/20R77juX1EAsRkGpJfhZO7TsJePIDQE5ElT3fRCwE7agOirdL04RUfznC8bUXE= X-Received: by 2002:a5d:44c7:0:b0:1ed:e11c:9b73 with SMTP id z7-20020a5d44c7000000b001ede11c9b73mr19967467wrr.574.1646156709718; Tue, 01 Mar 2022 09:45:09 -0800 (PST) MIME-Version: 1.0 References: <1644349472-31077-1-git-send-email-quic_abhinavk@quicinc.com> <654d620b-9e14-c47f-b48c-762dc0bd32a1@quicinc.com> <7db7d01fcf5a3edce61161769c0e6eb1541237bf.camel@sipsolutions.net> <2add9ba7-7bc8-bd1d-1963-61e8154b0e3c@quicinc.com> <989efb15-cc5e-8f6d-c313-118f01498e33@quicinc.com> <8fa2f879e33e4e42b76e21c6fbdcb023@AcuMS.aculab.com> In-Reply-To: <8fa2f879e33e4e42b76e21c6fbdcb023@AcuMS.aculab.com> From: Rob Clark Date: Tue, 1 Mar 2022 09:45:39 -0800 Message-ID: Subject: Re: [PATCH] devcoredump: increase the device delete timeout to 10 mins To: David Laight Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "aravindh@codeaurora.org" , "rafael@kernel.org" , Greg KH , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Abhinav Kumar , "khsieh@codeaurora.org" , "nganji@codeaurora.org" , "seanpaul@chromium.org" , "linux-arm-msm@vger.kernel.org" , "dmitry.baryshkov@linaro.org" , Johannes Berg , "swboyd@chromium.org" , "freedreno@lists.freedesktop.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 28, 2022 at 10:49 PM David Laight wrote: > > From: Abhinav Kumar > > Sent: 28 February 2022 21:38 > ... > > We also did some profiling around how much increasing the block size > > helps and here is the data: > > > > Block size cost > > > > 4KB 229s > > 8KB 86s > > You must have an O(n^2) operation in there - find it. The problem is how the devcoredump/sysfs interface works, which results in "re-rendering" the output for each block.. it's fine for moderate size sysfs files, but scales quite badly once you get into couple MB size sysfs files. It could be fixed by having some way to keep state across successive read callbacks. BR, -R > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales)