From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 686EFC433EF for ; Thu, 9 Sep 2021 20:50:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35AD760FDA for ; Thu, 9 Sep 2021 20:50:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235679AbhIIUvM (ORCPT ); Thu, 9 Sep 2021 16:51:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234786AbhIIUvL (ORCPT ); Thu, 9 Sep 2021 16:51:11 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 013F3C061574; Thu, 9 Sep 2021 13:50:01 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id d6so4377869wrc.11; Thu, 09 Sep 2021 13:50:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aaLbY2Tz0R78gM5UFyzV3LES/psE8wo8ewJyYFtaGmE=; b=M3sRkj5UCFFxWHbtvRCrqQogUWXztMX+umO/Fg+EG1xChVQpXicgxu7gvlC9YY2bTk JbMKLpuNoijQ1Kj9gEbQxrNYKJDwjpjkXIjmTEKdd65hOcdjs3YA6SzoHLYl4kVS/K7U wvBZ/yO3gsUyIvnHcgs0AqT6TMLDp++0yr1NJGHXqgf1eTaXqcUhK5DK5FUy46JtvUgS 2T+a5IVMxYE4lM2sr1YpH9jtzgsuRXD0oLap47Yd+rZPXBZvAAJtOFvch5aqzhoRas/8 zBeohRfEYcUdiuoduv0JESigNg7lYZIzAByKfaE6NXp9YbAhr/TAYIN94NUm2XYKjnz+ CxQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aaLbY2Tz0R78gM5UFyzV3LES/psE8wo8ewJyYFtaGmE=; b=tNsoR6BZUT73DbthRCq+OnLgmapaxoMXb+6QgDMQLKPCEHM9iSRzhWe+ABEZGnrB1a enArxDMoePaDHf+DuLzl5dPAP7bA2/urEyvnMJxAuJouAEL6RXdTcbOCwMP8OlCwcAe1 HMMzucoFwR4L9Tz66X7OPnn9BPpu1zJp/tHx7L8Ivemz0VNIOef11weFd0NvdPEZOfYX tkVqeG7e+BWYJfNLhzepM3ILwk0Z2jJPzDpCKXfoLYKNDV3VcVaJ+965lzMI+MVseYW2 HFJ4hSD5QCKvK4VfFecitTxKMDQkO6i2tU6WMRs/FFEZlkyJFjZwA2BkBZkW4qjuWlLW RBcw== X-Gm-Message-State: AOAM531E+FnEUWJkGAyuuBPFMMKo3IccoPjFsdy5LAuBv9ZdutTz+Tux HvYa28Pamui/TTqMTmKQ3A1don05aVHeW4zuoYY= X-Google-Smtp-Source: ABdhPJx/Ub7e1GmbjPXeYixhcXbC0J+o/GQmR9fJDlfxq9p1WW/IYvC8I8ePRPlX6Yd9TfwCCOlcoo0G92X2v9QjjUE= X-Received: by 2002:adf:e5c2:: with SMTP id a2mr5852512wrn.251.1631220599548; Thu, 09 Sep 2021 13:49:59 -0700 (PDT) MIME-Version: 1.0 References: <8aa590be-6a9f-9343-e897-18e86ea48202@linaro.org> <6eefedb2-9e59-56d2-7703-2faf6cb0ca3a@codeaurora.org> <83ecbe74-caf0-6c42-e6f5-4887b3b534c6@linaro.org> <53d3e5b7-9dc0-a806-70e9-b9b5ff877462@codeaurora.org> In-Reply-To: From: Rob Clark Date: Thu, 9 Sep 2021 13:54:26 -0700 Message-ID: Subject: Re: [PATCH] drm/msm: Disable frequency clamping on a630 To: Akhil P Oommen Cc: Amit Pundir , Bjorn Andersson , Caleb Connolly , dri-devel , freedreno , linux-arm-msm , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Jordan Crouse , Jonathan Marek , Sai Prakash Ranjan , open list , Stephen Boyd Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Sep 9, 2021 at 12:50 PM Akhil P Oommen wrote: > > On 9/9/2021 9:42 PM, Amit Pundir wrote: > > On Thu, 9 Sept 2021 at 17:47, Amit Pundir wrote: > >> > >> On Wed, 8 Sept 2021 at 07:50, Bjorn Andersson > >> wrote: > >>> > >>> On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: > >>> > >>>> On 8/9/2021 9:48 PM, Caleb Connolly wrote: > >>>>> > >>>>> > >>>>> On 09/08/2021 17:12, Rob Clark wrote: > >>>>>> On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen > >>>>>> wrote: > >>> [..] > >>>>>>> I am a bit confused. We don't define a power domain for gpu in dt, > >>>>>>> correct? Then what exactly set_opp do here? Do you think this usleep is > >>>>>>> what is helping here somehow to mask the issue? > >>>>> The power domains (for cx and gx) are defined in the GMU DT, the OPPs in > >>>>> the GPU DT. For the sake of simplicity I'll refer to the lowest > >>>>> frequency (257000000) and OPP level (RPMH_REGULATOR_LEVEL_LOW_SVS) as > >>>>> the "min" state, and the highest frequency (710000000) and OPP level > >>>>> (RPMH_REGULATOR_LEVEL_TURBO_L1) as the "max" state. These are defined in > >>>>> sdm845.dtsi under the gpu node. > >>>>> > >>>>> The new devfreq behaviour unmasks what I think is a driver bug, it > >>>>> inadvertently puts much more strain on the GPU regulators than they > >>>>> usually get. With the new behaviour the GPU jumps from it's min state to > >>>>> the max state and back again extremely rapidly under workloads as small > >>>>> as refreshing UI. Where previously the GPU would rarely if ever go above > >>>>> 342MHz when interacting with the device, it now jumps between min and > >>>>> max many times per second. > >>>>> > >>>>> If my understanding is correct, the current implementation of the GMU > >>>>> set freq is the following: > >>>>> - Get OPP for frequency to set > >>>>> - Push the frequency to the GMU - immediately updating the core clock > >>>>> - Call dev_pm_opp_set_opp() which triggers a notify chain, this winds > >>>>> up somewhere in power management code and causes the gx regulator level > >>>>> to be updated > >>>> > >>>> Nope. dev_pm_opp_set_opp() sets the bandwidth for gpu and nothing else. We > >>>> were using a different api earlier which got deprecated - > >>>> dev_pm_opp_set_bw(). > >>>> > >>> > >>> On the Lenovo Yoga C630 this is reproduced by starting alacritty and if > >>> I'm lucky I managed to hit a few keys before it crashes, so I spent a > >>> few hours looking into this as well... > >>> > >>> As you say, the dev_pm_opp_set_opp() will only cast a interconnect vote. > >>> The opp-level is just there for show and isn't used by anything, at > >>> least not on 845. > >>> > >>> Further more, I'm missing something in my tree, so the interconnect > >>> doesn't hit sync_state, and as such we're not actually scaling the > >>> buses. So the problem is not that Linux doesn't turn on the buses in > >>> time. > >>> > >>> So I suspect that the "AHB bus error" isn't saying that we turned off > >>> the bus, but rather that the GPU becomes unstable or something of that > >>> sort. > >>> > >>> > >>> Lastly, I reverted 9bc95570175a ("drm/msm: Devfreq tuning") and ran > >>> Aquarium for 20 minutes without a problem. I then switched the gpu > >>> devfreq governor to "userspace" and ran the following: > >>> > >>> while true; do > >>> echo 257000000 > /sys/class/devfreq/5000000.gpu/userspace/set_freq > >>> echo 710000000 > /sys/class/devfreq/5000000.gpu/userspace/set_freq > >>> done > >>> > >>> It took 19 iterations of this loop to crash the GPU. > >> > >> Ack. With your above script, I can reproduce a crash too on db845c > >> (A630) running v5.14. I didn't get any crash log though and device > >> just rebooted to USB crash mode. > >> > >> And same crash on RB5 (A650) too https://hastebin.com/raw/ejutetuwun > > Are we sure this is the same issue? It could be, but I thought we were > seeing a bunch of random gpu errors (which may eventually hit device crash). In the sense that async-serror often seems to be a clk issue, it *could* be related.. but this would have to be triggered by CPU access. The symptom does seem very different. BR, -R > -Akhil > > > > > fwiw I can't reproduce this crash on RB5 so far with v5.15-rc1 merge > > window (HEAD: 477f70cd2a67) > > > >> > >>> > >>> So the problem doesn't seem to be Rob's change, it's just that prior to > >>> it the chance to hitting it is way lower. Question is still what it is > >>> that we're triggering. > >>> > >>> Regards, > >>> Bjorn > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DFE8C433F5 for ; Thu, 9 Sep 2021 20:50:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C66C26113A for ; Thu, 9 Sep 2021 20:50:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C66C26113A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D939C6E90E; Thu, 9 Sep 2021 20:50:01 +0000 (UTC) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2207E6E90E; Thu, 9 Sep 2021 20:50:01 +0000 (UTC) Received: by mail-wr1-x434.google.com with SMTP id n5so4362561wro.12; Thu, 09 Sep 2021 13:50:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aaLbY2Tz0R78gM5UFyzV3LES/psE8wo8ewJyYFtaGmE=; b=M3sRkj5UCFFxWHbtvRCrqQogUWXztMX+umO/Fg+EG1xChVQpXicgxu7gvlC9YY2bTk JbMKLpuNoijQ1Kj9gEbQxrNYKJDwjpjkXIjmTEKdd65hOcdjs3YA6SzoHLYl4kVS/K7U wvBZ/yO3gsUyIvnHcgs0AqT6TMLDp++0yr1NJGHXqgf1eTaXqcUhK5DK5FUy46JtvUgS 2T+a5IVMxYE4lM2sr1YpH9jtzgsuRXD0oLap47Yd+rZPXBZvAAJtOFvch5aqzhoRas/8 zBeohRfEYcUdiuoduv0JESigNg7lYZIzAByKfaE6NXp9YbAhr/TAYIN94NUm2XYKjnz+ CxQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aaLbY2Tz0R78gM5UFyzV3LES/psE8wo8ewJyYFtaGmE=; b=dxH+7HmjoLBx8lKOQPjVIccocVc2ZKdzP9KGZ2BTgK3bLiRsxdLQoAJypVvDcUftYy 8djfF7FXeYrriZSUUXeNalKtmiDn1Is7gDSCey8vY41QXOcRqd+3gOufetULHpN8zn/G 2N3lVARdNkSAEq4CklMck9do97L2vN7UtO5SJ2ZeNd7tG3MyI4SoEGynQyZUJKKa8zIm DvcC1zmXQO30LjY9/ZHm05twrqD/QxlQ+X+9HxdNDr9I4ijfw7kzKUXgz4BtfoF3Ss0Y G16kqnfB8rvZ57Iph7TkiDBQgKQsGbmy+JC0hl1Do9yCH8ilbgVoUulrk+zeDWmWejME SrWQ== X-Gm-Message-State: AOAM531VyHtnU8yYsEZBz8X3k0F6anxdpwaSlcRf/yH0UCtxhjxTDqug oMgPNIYK32gw9ppZo+LRQ8Hle/rM8Oa1aX8yqZ4= X-Google-Smtp-Source: ABdhPJx/Ub7e1GmbjPXeYixhcXbC0J+o/GQmR9fJDlfxq9p1WW/IYvC8I8ePRPlX6Yd9TfwCCOlcoo0G92X2v9QjjUE= X-Received: by 2002:adf:e5c2:: with SMTP id a2mr5852512wrn.251.1631220599548; Thu, 09 Sep 2021 13:49:59 -0700 (PDT) MIME-Version: 1.0 References: <8aa590be-6a9f-9343-e897-18e86ea48202@linaro.org> <6eefedb2-9e59-56d2-7703-2faf6cb0ca3a@codeaurora.org> <83ecbe74-caf0-6c42-e6f5-4887b3b534c6@linaro.org> <53d3e5b7-9dc0-a806-70e9-b9b5ff877462@codeaurora.org> In-Reply-To: From: Rob Clark Date: Thu, 9 Sep 2021 13:54:26 -0700 Message-ID: Subject: Re: [PATCH] drm/msm: Disable frequency clamping on a630 To: Akhil P Oommen Cc: Amit Pundir , Bjorn Andersson , Caleb Connolly , dri-devel , freedreno , linux-arm-msm , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Jordan Crouse , Jonathan Marek , Sai Prakash Ranjan , open list , Stephen Boyd Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Sep 9, 2021 at 12:50 PM Akhil P Oommen wrote: > > On 9/9/2021 9:42 PM, Amit Pundir wrote: > > On Thu, 9 Sept 2021 at 17:47, Amit Pundir wrote: > >> > >> On Wed, 8 Sept 2021 at 07:50, Bjorn Andersson > >> wrote: > >>> > >>> On Mon 09 Aug 10:26 PDT 2021, Akhil P Oommen wrote: > >>> > >>>> On 8/9/2021 9:48 PM, Caleb Connolly wrote: > >>>>> > >>>>> > >>>>> On 09/08/2021 17:12, Rob Clark wrote: > >>>>>> On Mon, Aug 9, 2021 at 7:52 AM Akhil P Oommen > >>>>>> wrote: > >>> [..] > >>>>>>> I am a bit confused. We don't define a power domain for gpu in dt, > >>>>>>> correct? Then what exactly set_opp do here? Do you think this usleep is > >>>>>>> what is helping here somehow to mask the issue? > >>>>> The power domains (for cx and gx) are defined in the GMU DT, the OPPs in > >>>>> the GPU DT. For the sake of simplicity I'll refer to the lowest > >>>>> frequency (257000000) and OPP level (RPMH_REGULATOR_LEVEL_LOW_SVS) as > >>>>> the "min" state, and the highest frequency (710000000) and OPP level > >>>>> (RPMH_REGULATOR_LEVEL_TURBO_L1) as the "max" state. These are defined in > >>>>> sdm845.dtsi under the gpu node. > >>>>> > >>>>> The new devfreq behaviour unmasks what I think is a driver bug, it > >>>>> inadvertently puts much more strain on the GPU regulators than they > >>>>> usually get. With the new behaviour the GPU jumps from it's min state to > >>>>> the max state and back again extremely rapidly under workloads as small > >>>>> as refreshing UI. Where previously the GPU would rarely if ever go above > >>>>> 342MHz when interacting with the device, it now jumps between min and > >>>>> max many times per second. > >>>>> > >>>>> If my understanding is correct, the current implementation of the GMU > >>>>> set freq is the following: > >>>>> - Get OPP for frequency to set > >>>>> - Push the frequency to the GMU - immediately updating the core clock > >>>>> - Call dev_pm_opp_set_opp() which triggers a notify chain, this winds > >>>>> up somewhere in power management code and causes the gx regulator level > >>>>> to be updated > >>>> > >>>> Nope. dev_pm_opp_set_opp() sets the bandwidth for gpu and nothing else. We > >>>> were using a different api earlier which got deprecated - > >>>> dev_pm_opp_set_bw(). > >>>> > >>> > >>> On the Lenovo Yoga C630 this is reproduced by starting alacritty and if > >>> I'm lucky I managed to hit a few keys before it crashes, so I spent a > >>> few hours looking into this as well... > >>> > >>> As you say, the dev_pm_opp_set_opp() will only cast a interconnect vote. > >>> The opp-level is just there for show and isn't used by anything, at > >>> least not on 845. > >>> > >>> Further more, I'm missing something in my tree, so the interconnect > >>> doesn't hit sync_state, and as such we're not actually scaling the > >>> buses. So the problem is not that Linux doesn't turn on the buses in > >>> time. > >>> > >>> So I suspect that the "AHB bus error" isn't saying that we turned off > >>> the bus, but rather that the GPU becomes unstable or something of that > >>> sort. > >>> > >>> > >>> Lastly, I reverted 9bc95570175a ("drm/msm: Devfreq tuning") and ran > >>> Aquarium for 20 minutes without a problem. I then switched the gpu > >>> devfreq governor to "userspace" and ran the following: > >>> > >>> while true; do > >>> echo 257000000 > /sys/class/devfreq/5000000.gpu/userspace/set_freq > >>> echo 710000000 > /sys/class/devfreq/5000000.gpu/userspace/set_freq > >>> done > >>> > >>> It took 19 iterations of this loop to crash the GPU. > >> > >> Ack. With your above script, I can reproduce a crash too on db845c > >> (A630) running v5.14. I didn't get any crash log though and device > >> just rebooted to USB crash mode. > >> > >> And same crash on RB5 (A650) too https://hastebin.com/raw/ejutetuwun > > Are we sure this is the same issue? It could be, but I thought we were > seeing a bunch of random gpu errors (which may eventually hit device crash). In the sense that async-serror often seems to be a clk issue, it *could* be related.. but this would have to be triggered by CPU access. The symptom does seem very different. BR, -R > -Akhil > > > > > fwiw I can't reproduce this crash on RB5 so far with v5.15-rc1 merge > > window (HEAD: 477f70cd2a67) > > > >> > >>> > >>> So the problem doesn't seem to be Rob's change, it's just that prior to > >>> it the chance to hitting it is way lower. Question is still what it is > >>> that we're triggering. > >>> > >>> Regards, > >>> Bjorn >