From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933190AbbDISyc (ORCPT ); Thu, 9 Apr 2015 14:54:32 -0400 Received: from mail-qc0-f170.google.com ([209.85.216.170]:36534 "EHLO mail-qc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932841AbbDISya (ORCPT ); Thu, 9 Apr 2015 14:54:30 -0400 MIME-Version: 1.0 In-Reply-To: <1428603178.13881.20.camel@x220> References: <20150409112240.GA4748@station.rsr.lip6.fr> <20150409142024.GA3040@kroah.com> <20150409170707.GA7742@kroah.com> <1428603178.13881.20.camel@x220> Date: Thu, 9 Apr 2015 14:54:29 -0400 Message-ID: Subject: Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING From: Rob Clark To: Paul Bolle Cc: Greg KH , Valentin Rothberg , Hai Li , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , David Airlie , rupran@einserver.de, stefan.hengelein@fau.de Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 9, 2015 at 2:12 PM, Paul Bolle wrote: > On Thu, 2015-04-09 at 19:07 +0200, Greg KH wrote: >> I really don't understand. Why is this code in the kernel tree if it >> can't be built? How does anyone use this? By taking it and copying it >> where? If it can't be built, and no one can update it, and of course >> not run it, why is it here? What good is this code doing sitting here? > > The Erlangen bot (courtesy of Valentin, Stefan, and Andreas) has taken > over what I've been doing for quite some time, but doing it much more > thoroughly. And my experience tells me that the reports they'll send in > will trigger more discussions like this one. > > A lesson I learned from my daily checks for Kconfig oddities is that > people go to great lengths defending unbuildable code. (Do a web search > for ATHEROS_AR231X to find a discussion that dragged on for over three > years!) Personally I stopped caring after someone insisted on having a > file in the tree that was in no way connected to the build system: not a > single line in any of the Makefiles pointed at it. So, as far as I'm > concerned, if people can't point at a patch pending, somehow, somewhere, > that would make their code buildable one might as well delete the code. > > I really think it's as simple as that. > In the example you reference, sure it is as simple as that. But here we are not talking about files that aren't even referenced by build system. We are talking about a driver which does build and run on upstream kernel, and which has a few small #ifdef blocks to simplify backporting to downstream kernels (which we still do need to use for some generations and some devices) Sure, I'd love never to have to deal with a downstream kernel. But really.. I didn't create the downstream mess in the arm/android ecosystem, I'm just trying to cope with it as best as possible.. don't hate the player, hate the game :-P BR, -R > > Paul Bolle > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: drm/msm/mdp5: undefined CONFIG_MSM_BUS_SCALING Date: Thu, 9 Apr 2015 14:54:29 -0400 Message-ID: References: <20150409112240.GA4748@station.rsr.lip6.fr> <20150409142024.GA3040@kroah.com> <20150409170707.GA7742@kroah.com> <1428603178.13881.20.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qc0-f177.google.com (mail-qc0-f177.google.com [209.85.216.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D7C86E258 for ; Thu, 9 Apr 2015 11:54:30 -0700 (PDT) Received: by qcpm10 with SMTP id m10so3284203qcp.3 for ; Thu, 09 Apr 2015 11:54:29 -0700 (PDT) In-Reply-To: <1428603178.13881.20.camel@x220> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Bolle Cc: Greg KH , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , rupran@einserver.de, stefan.hengelein@fau.de, Valentin Rothberg List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBBcHIgOSwgMjAxNSBhdCAyOjEyIFBNLCBQYXVsIEJvbGxlIDxwZWJvbGxlQHRpc2Nh bGkubmw+IHdyb3RlOgo+IE9uIFRodSwgMjAxNS0wNC0wOSBhdCAxOTowNyArMDIwMCwgR3JlZyBL SCB3cm90ZToKPj4gSSByZWFsbHkgZG9uJ3QgdW5kZXJzdGFuZC4gIFdoeSBpcyB0aGlzIGNvZGUg aW4gdGhlIGtlcm5lbCB0cmVlIGlmIGl0Cj4+IGNhbid0IGJlIGJ1aWx0PyAgSG93IGRvZXMgYW55 b25lIHVzZSB0aGlzPyAgQnkgdGFraW5nIGl0IGFuZCBjb3B5aW5nIGl0Cj4+IHdoZXJlPyAgSWYg aXQgY2FuJ3QgYmUgYnVpbHQsIGFuZCBubyBvbmUgY2FuIHVwZGF0ZSBpdCwgYW5kIG9mIGNvdXJz ZQo+PiBub3QgcnVuIGl0LCB3aHkgaXMgaXQgaGVyZT8gIFdoYXQgZ29vZCBpcyB0aGlzIGNvZGUg ZG9pbmcgc2l0dGluZyBoZXJlPwo+Cj4gVGhlIEVybGFuZ2VuIGJvdCAoY291cnRlc3kgb2YgVmFs ZW50aW4sIFN0ZWZhbiwgYW5kIEFuZHJlYXMpIGhhcyB0YWtlbgo+IG92ZXIgd2hhdCBJJ3ZlIGJl ZW4gZG9pbmcgZm9yIHF1aXRlIHNvbWUgdGltZSwgYnV0IGRvaW5nIGl0IG11Y2ggbW9yZQo+IHRo b3JvdWdobHkuIEFuZCBteSBleHBlcmllbmNlIHRlbGxzIG1lIHRoYXQgdGhlIHJlcG9ydHMgdGhl eSdsbCBzZW5kIGluCj4gd2lsbCB0cmlnZ2VyIG1vcmUgZGlzY3Vzc2lvbnMgbGlrZSB0aGlzIG9u ZS4KPgo+IEEgbGVzc29uIEkgbGVhcm5lZCBmcm9tIG15IGRhaWx5IGNoZWNrcyBmb3IgS2NvbmZp ZyBvZGRpdGllcyBpcyB0aGF0Cj4gcGVvcGxlIGdvIHRvIGdyZWF0IGxlbmd0aHMgZGVmZW5kaW5n IHVuYnVpbGRhYmxlIGNvZGUuIChEbyBhIHdlYiBzZWFyY2gKPiBmb3IgQVRIRVJPU19BUjIzMVgg dG8gZmluZCBhIGRpc2N1c3Npb24gdGhhdCBkcmFnZ2VkIG9uIGZvciBvdmVyIHRocmVlCj4geWVh cnMhKSBQZXJzb25hbGx5IEkgc3RvcHBlZCBjYXJpbmcgYWZ0ZXIgc29tZW9uZSBpbnNpc3RlZCBv biBoYXZpbmcgYQo+IGZpbGUgaW4gdGhlIHRyZWUgdGhhdCB3YXMgaW4gbm8gd2F5IGNvbm5lY3Rl ZCB0byB0aGUgYnVpbGQgc3lzdGVtOiBub3QgYQo+IHNpbmdsZSBsaW5lIGluIGFueSBvZiB0aGUg TWFrZWZpbGVzIHBvaW50ZWQgYXQgaXQuIFNvLCBhcyBmYXIgYXMgSSdtCj4gY29uY2VybmVkLCBp ZiBwZW9wbGUgY2FuJ3QgcG9pbnQgYXQgYSBwYXRjaCBwZW5kaW5nLCBzb21laG93LCBzb21ld2hl cmUsCj4gdGhhdCB3b3VsZCBtYWtlIHRoZWlyIGNvZGUgYnVpbGRhYmxlIG9uZSBtaWdodCBhcyB3 ZWxsIGRlbGV0ZSB0aGUgY29kZS4KPgo+IEkgcmVhbGx5IHRoaW5rIGl0J3MgYXMgc2ltcGxlIGFz IHRoYXQuCj4KCkluIHRoZSBleGFtcGxlIHlvdSByZWZlcmVuY2UsIHN1cmUgaXQgaXMgYXMgc2lt cGxlIGFzIHRoYXQuICBCdXQgaGVyZQp3ZSBhcmUgbm90IHRhbGtpbmcgYWJvdXQgZmlsZXMgdGhh dCBhcmVuJ3QgZXZlbiByZWZlcmVuY2VkIGJ5IGJ1aWxkCnN5c3RlbS4gIFdlIGFyZSB0YWxraW5n IGFib3V0IGEgZHJpdmVyIHdoaWNoIGRvZXMgYnVpbGQgYW5kIHJ1biBvbgp1cHN0cmVhbSBrZXJu ZWwsIGFuZCB3aGljaCBoYXMgYSBmZXcgc21hbGwgI2lmZGVmIGJsb2NrcyB0byBzaW1wbGlmeQpi YWNrcG9ydGluZyB0byBkb3duc3RyZWFtIGtlcm5lbHMgKHdoaWNoIHdlIHN0aWxsIGRvIG5lZWQg dG8gdXNlIGZvcgpzb21lIGdlbmVyYXRpb25zIGFuZCBzb21lIGRldmljZXMpCgpTdXJlLCBJJ2Qg bG92ZSBuZXZlciB0byBoYXZlIHRvIGRlYWwgd2l0aCBhIGRvd25zdHJlYW0ga2VybmVsLiAgQnV0 CnJlYWxseS4uIEkgZGlkbid0IGNyZWF0ZSB0aGUgZG93bnN0cmVhbSBtZXNzIGluIHRoZSBhcm0v YW5kcm9pZAplY29zeXN0ZW0sIEknbSBqdXN0IHRyeWluZyB0byBjb3BlIHdpdGggaXQgYXMgYmVz dCBhcyBwb3NzaWJsZS4uIGRvbid0CmhhdGUgdGhlIHBsYXllciwgaGF0ZSB0aGUgZ2FtZSA6LVAK CkJSLAotUgoKPgo+IFBhdWwgQm9sbGUKPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo=