From mboxrd@z Thu Jan 1 00:00:00 1970 From: robdclark@gmail.com (Rob Clark) Date: Fri, 18 Oct 2013 11:00:34 -0400 Subject: [PATCH 1/5] drm/i2c: tda998x: set VIF for full range, underscanned display In-Reply-To: <20131007105944.6746352b@armhf> References: <20131006220728.GG12758@n2100.arm.linux.org.uk> <20131007105944.6746352b@armhf> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Oct 7, 2013 at 4:59 AM, Jean-Francois Moine wrote: > On Sun, 06 Oct 2013 23:07:55 +0100 > Russell King wrote: > >> Signed-off-by: Russell King >> --- >> drivers/gpu/drm/i2c/tda998x_drv.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c >> index 60e8404..704040b5 100644 >> --- a/drivers/gpu/drm/i2c/tda998x_drv.c >> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c >> @@ -549,6 +549,8 @@ tda998x_write_avi(struct drm_encoder *encoder, struct drm_display_mode *mode) >> buf[HB(0)] = 0x82; >> buf[HB(1)] = 0x02; >> buf[HB(2)] = 13; >> + buf[PB(1)] = 2; /* underscanned display */ >> + buf[PB(3)] = 2 << 2; /* full range */ >> buf[PB(4)] = drm_match_cea_mode(mode); >> >> tda998x_write_if(encoder, DIP_IF_FLAGS_IF2, REG_IF2_HB0, buf, > > You should use the 'hdmi.h' constants which are meaningful enough: > > buf[PB(1)] = HDMI_SCAN_MODE_UNDERSCAN; > buf[PB(3)] = HDMI_QUANTIZATION_RANGE_FULL << 2; > with the update to use hdmi.h const, this has my Reviewed-by: Rob Clark (and other ones I replied last night, s/s-o-b/r-b/) > -- > Ken ar c'henta? | ** Breizh ha Linux atav! ** > Jef | http://moinejf.free.fr/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH 1/5] drm/i2c: tda998x: set VIF for full range, underscanned display Date: Fri, 18 Oct 2013 11:00:34 -0400 Message-ID: References: <20131006220728.GG12758@n2100.arm.linux.org.uk> <20131007105944.6746352b@armhf> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20131007105944.6746352b@armhf> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jean-Francois Moine Cc: Jason Cooper , David Airlie , "dri-devel@lists.freedesktop.org" , Daniel Vetter , Russell King , "linux-arm-kernel@lists.infradead.org" , Sebastian Hesselbarth List-Id: dri-devel@lists.freedesktop.org On Mon, Oct 7, 2013 at 4:59 AM, Jean-Francois Moine wrote: > On Sun, 06 Oct 2013 23:07:55 +0100 > Russell King wrote: > >> Signed-off-by: Russell King >> --- >> drivers/gpu/drm/i2c/tda998x_drv.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda= 998x_drv.c >> index 60e8404..704040b5 100644 >> --- a/drivers/gpu/drm/i2c/tda998x_drv.c >> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c >> @@ -549,6 +549,8 @@ tda998x_write_avi(struct drm_encoder *encoder, struc= t drm_display_mode *mode) >> buf[HB(0)] =3D 0x82; >> buf[HB(1)] =3D 0x02; >> buf[HB(2)] =3D 13; >> + buf[PB(1)] =3D 2; /* underscanned display */ >> + buf[PB(3)] =3D 2 << 2; /* full range */ >> buf[PB(4)] =3D drm_match_cea_mode(mode); >> >> tda998x_write_if(encoder, DIP_IF_FLAGS_IF2, REG_IF2_HB0, buf, > > You should use the 'hdmi.h' constants which are meaningful enough: > > buf[PB(1)] =3D HDMI_SCAN_MODE_UNDERSCAN; > buf[PB(3)] =3D HDMI_QUANTIZATION_RANGE_FULL << 2; > with the update to use hdmi.h const, this has my Reviewed-by: Rob Clark (and other ones I replied last night, s/s-o-b/r-b/) > -- > Ken ar c'henta=F1 | ** Breizh ha Linux atav! ** > Jef | http://moinejf.free.fr/