From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA70C432BE for ; Mon, 9 Aug 2021 18:03:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DA9B0610FD for ; Mon, 9 Aug 2021 18:03:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231882AbhHISDc (ORCPT ); Mon, 9 Aug 2021 14:03:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232642AbhHISD3 (ORCPT ); Mon, 9 Aug 2021 14:03:29 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01CF0C0613D3; Mon, 9 Aug 2021 11:03:09 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id d131-20020a1c1d890000b02902516717f562so609968wmd.3; Mon, 09 Aug 2021 11:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AottaItdNpwEGaBVEcs2HSf4MSRq1/DJ2ThJuxRDL0Y=; b=t3NjC6Wc6R/U+WyQTTgjVH/rdU4MqhTP0Ldt3iBZ+QpVu9bL/uGwFDnkHE9hVifDCw 3IHL95I8zaBeiaRjAM8US5bFNnCjxRac/VGFA+Geg17X9YiMzbnumQpHDImztVOSJ7zm pyRaYK6D8iHhJZyQf177eCA5HEiqiDgZx1cwGEq3jiyTFf0a3HaF4WT3h2XDMC9JveI8 25FJk7rWKgpQTmPm+7RSUs+LWiOVzjwOm6CljybSU6PCzUweeQn5O2mir8+//cpT9hE3 jh0ItWDJiXwm4P60mG+2u9z+n9u2Ajd1YDkL5rO3eq0Xr1w8yOfy8tu3aDGGz69D8y9B sZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AottaItdNpwEGaBVEcs2HSf4MSRq1/DJ2ThJuxRDL0Y=; b=iTk/E7LcbSPgkcTty2EEaKAW505JYlBDS/9GL+C9QYwhQZn2kVWeoHVZo76IAqMvSb RHj/qexfYomV4CbMpvWysMPsZV4eT0LhOZqeGHnndhQxBWi6lqgIjaX4dVSqIeIJElr+ H0p+edEMWqmoj7cxjNKB2gKB4GUZLcV5S1OKifwtcrsk7Mnuqgi05agbKyHnVdnPFWrR P8jiCzYrj+yXo2GrUMDgxwNHnhqkjHsLmqU9gHmUgiSIbuGPO6LlD06CeIsf+mcD9XBz 04xFo57+y9v8VnlurQIOh6EmkVo9aaa0AXkDg+3L+uWfdvY5HEWBohXUAUU2ybiyvUI8 SiRQ== X-Gm-Message-State: AOAM53390z314XD9jHV88/zxuAWWWUFmd9Li166EcW85i03SgxqJ0phm tpRHc0jUQ+vcVtEmkz0uvOr6nSIxmq/3K0nyRCc= X-Google-Smtp-Source: ABdhPJwPQuU1umbzHs0AJtjSZtlKt3cKEhS0AjOuobmEY6ysunNkpvrb+zdwqw/9Gv8yOZQu0gTllxVLx8C+clsD3c0= X-Received: by 2002:a1c:f414:: with SMTP id z20mr398052wma.94.1628532187414; Mon, 09 Aug 2021 11:03:07 -0700 (PDT) MIME-Version: 1.0 References: <20210728140052.GB22887@mms-0441> <8b2742c8891abe4fec3664730717a089@codeaurora.org> <20210802105544.GA27657@willie-the-truck> <20210802151409.GE28735@willie-the-truck> <20210809145651.GC1458@willie-the-truck> <20210809170508.GB1589@willie-the-truck> <20210809174022.GA1840@willie-the-truck> <76bfd0b4248148dfbf9d174ddcb4c2a2@codeaurora.org> In-Reply-To: <76bfd0b4248148dfbf9d174ddcb4c2a2@codeaurora.org> From: Rob Clark Date: Mon, 9 Aug 2021 11:07:22 -0700 Message-ID: Subject: Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache To: Sai Prakash Ranjan Cc: Will Deacon , Georgi Djakov , "Isaac J. Manjarres" , David Airlie , Akhil P Oommen , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Linux Kernel Mailing List , Sean Paul , Jordan Crouse , Kristian H Kristensen , dri-devel , Daniel Vetter , linux-arm-msm , freedreno , Robin Murphy , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Aug 9, 2021 at 10:47 AM Sai Prakash Ranjan wrote: > > On 2021-08-09 23:10, Will Deacon wrote: > > On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob Clark wrote: > >> On Mon, Aug 9, 2021 at 10:05 AM Will Deacon wrote: > >> > > >> > On Mon, Aug 09, 2021 at 09:57:08AM -0700, Rob Clark wrote: > >> > > On Mon, Aug 9, 2021 at 7:56 AM Will Deacon wrote: > >> > > > On Mon, Aug 02, 2021 at 06:36:04PM -0700, Rob Clark wrote: > >> > > > > On Mon, Aug 2, 2021 at 8:14 AM Will Deacon wrote: > >> > > > > > On Mon, Aug 02, 2021 at 08:08:07AM -0700, Rob Clark wrote: > >> > > > > > > On Mon, Aug 2, 2021 at 3:55 AM Will Deacon wrote: > >> > > > > > > > On Thu, Jul 29, 2021 at 10:08:22AM +0530, Sai Prakash Ranjan wrote: > >> > > > > > > > > On 2021-07-28 19:30, Georgi Djakov wrote: > >> > > > > > > > > > On Mon, Jan 11, 2021 at 07:45:02PM +0530, Sai Prakash Ranjan wrote: > >> > > > > > > > > > > commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") > >> > > > > > > > > > > removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went > >> > > > > > > > > > > the memory type setting required for the non-coherent masters to use > >> > > > > > > > > > > system cache. Now that system cache support for GPU is added, we will > >> > > > > > > > > > > need to set the right PTE attribute for GPU buffers to be sys cached. > >> > > > > > > > > > > Without this, the system cache lines are not allocated for GPU. > >> > > > > > > > > > > > >> > > > > > > > > > > So the patches in this series introduces a new prot flag IOMMU_LLC, > >> > > > > > > > > > > renames IO_PGTABLE_QUIRK_ARM_OUTER_WBWA to IO_PGTABLE_QUIRK_PTW_LLC > >> > > > > > > > > > > and makes GPU the user of this protection flag. > >> > > > > > > > > > > >> > > > > > > > > > Thank you for the patchset! Are you planning to refresh it, as it does > >> > > > > > > > > > not apply anymore? > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > I was waiting on Will's reply [1]. If there are no changes needed, then > >> > > > > > > > > I can repost the patch. > >> > > > > > > > > >> > > > > > > > I still think you need to handle the mismatched alias, no? You're adding > >> > > > > > > > a new memory type to the SMMU which doesn't exist on the CPU side. That > >> > > > > > > > can't be right. > >> > > > > > > > > >> > > > > > > > >> > > > > > > Just curious, and maybe this is a dumb question, but what is your > >> > > > > > > concern about mismatched aliases? I mean the cache hierarchy on the > >> > > > > > > GPU device side (anything beyond the LLC) is pretty different and > >> > > > > > > doesn't really care about the smmu pgtable attributes.. > >> > > > > > > >> > > > > > If the CPU accesses a shared buffer with different attributes to those which > >> > > > > > the device is using then you fall into the "mismatched memory attributes" > >> > > > > > part of the Arm architecture. It's reasonably unforgiving (you should go and > >> > > > > > read it) and in some cases can apply to speculative accesses as well, but > >> > > > > > the end result is typically loss of coherency. > >> > > > > > >> > > > > Ok, I might have a few other sections to read first to decipher the > >> > > > > terminology.. > >> > > > > > >> > > > > But my understanding of LLC is that it looks just like system memory > >> > > > > to the CPU and GPU (I think that would make it "the point of > >> > > > > coherence" between the GPU and CPU?) If that is true, shouldn't it be > >> > > > > invisible from the point of view of different CPU mapping options? > >> > > > > >> > > > You could certainly build a system where mismatched attributes don't cause > >> > > > loss of coherence, but as it's not guaranteed by the architecture and the > >> > > > changes proposed here affect APIs which are exposed across SoCs, then I > >> > > > don't think it helps much. > >> > > > > >> > > > >> > > Hmm, the description of the new mapping flag is that it applies only > >> > > to transparent outer level cache: > >> > > > >> > > +/* > >> > > + * Non-coherent masters can use this page protection flag to set cacheable > >> > > + * memory attributes for only a transparent outer level of cache, also known as > >> > > + * the last-level or system cache. > >> > > + */ > >> > > +#define IOMMU_LLC (1 << 6) > >> > > > >> > > But I suppose we could call it instead IOMMU_QCOM_LLC or something > >> > > like that to make it more clear that it is not necessarily something > >> > > that would work with a different outer level cache implementation? > >> > > >> > ... or we could just deal with the problem so that other people can reuse > >> > the code. I haven't really understood the reluctance to solve this properly. > >> > > >> > Am I missing some reason this isn't solvable? > >> > >> Oh, was there another way to solve it (other than foregoing setting > >> INC_OCACHE in the pgtables)? Maybe I misunderstood, is there a > >> corresponding setting on the MMU pgtables side of things? > > > > Right -- we just need to program the CPU's MMU with the matching memory > > attributes! It's a bit more fiddly if you're just using ioremap_wc() > > though, as it's usually the DMA API which handles the attributes under > > the > > hood. > > > > Anyway, sorry, I should've said that explicitly earlier on. We've done > > this > > sort of thing in the Android tree so I assumed Sai knew what needed to > > be > > done and then I didn't think to explain to you :( > > > > Right I was aware of that but even in the android tree there is no user > :) > I think we can't have a new memory type without any user right in > upstream > like android tree? > > @Rob, I think you already tried adding a new MT and used > pgprot_syscached() > in GPU driver but it was crashing? Correct, but IIRC there were some differences in the code for memory types compared to the android tree.. I couldn't figure out the necessary patches to cherry-pick to get the android patch to apply cleanly, so I tried re-implementing it without having much of a clue about how that code works (which was probably the issue) ;-) BR, -R From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC35FC432BE for ; Mon, 9 Aug 2021 18:03:16 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 530B9610EA for ; Mon, 9 Aug 2021 18:03:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 530B9610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 10E6A82A2D; Mon, 9 Aug 2021 18:03:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m4doppA3JkPZ; Mon, 9 Aug 2021 18:03:12 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id D431482A6C; Mon, 9 Aug 2021 18:03:11 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id AD054C001A; Mon, 9 Aug 2021 18:03:11 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 79ED7C000E for ; Mon, 9 Aug 2021 18:03:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5A55B6FAC8 for ; Mon, 9 Aug 2021 18:03:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sFW4Bu3OLP0d for ; Mon, 9 Aug 2021 18:03:09 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by smtp3.osuosl.org (Postfix) with ESMTPS id 651116062F for ; Mon, 9 Aug 2021 18:03:09 +0000 (UTC) Received: by mail-wm1-x333.google.com with SMTP id w21-20020a7bc1150000b02902e69ba66ce6so621325wmi.1 for ; Mon, 09 Aug 2021 11:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AottaItdNpwEGaBVEcs2HSf4MSRq1/DJ2ThJuxRDL0Y=; b=t3NjC6Wc6R/U+WyQTTgjVH/rdU4MqhTP0Ldt3iBZ+QpVu9bL/uGwFDnkHE9hVifDCw 3IHL95I8zaBeiaRjAM8US5bFNnCjxRac/VGFA+Geg17X9YiMzbnumQpHDImztVOSJ7zm pyRaYK6D8iHhJZyQf177eCA5HEiqiDgZx1cwGEq3jiyTFf0a3HaF4WT3h2XDMC9JveI8 25FJk7rWKgpQTmPm+7RSUs+LWiOVzjwOm6CljybSU6PCzUweeQn5O2mir8+//cpT9hE3 jh0ItWDJiXwm4P60mG+2u9z+n9u2Ajd1YDkL5rO3eq0Xr1w8yOfy8tu3aDGGz69D8y9B sZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AottaItdNpwEGaBVEcs2HSf4MSRq1/DJ2ThJuxRDL0Y=; b=cVNy1Zltxtcs7nynD05KaTJ9hqprNwQCbyJcMIeTfn9HPPhERWq6H+y5oUgm0fbgIA ojCQS/80VGThpdr4o8aP+VVc2nm0IWH5whTnO+IMKvUkv6kiVTvhLN2HJPcZRduuGocj 5rXaW5d8xIjYiSCcP+cPtZC+h3mN2D83lIqgbGupn5PCMWJlb9DtZiPU3lw9XhEblFD/ gaWxgJcAorDcUR76g4VtnmVhLWTYrGWVpoTcZhTbOFl+/5aeJbQ8uC70jpMXUBW0GvG1 HmxGOWa4oQjiijjeABUG3eFPWJTdPf5g5Y8SBWIvOFeBoH2mWfcHFNnCnZJ1GDQSg16N e3dA== X-Gm-Message-State: AOAM532qz6/6b+hb03DAGPvuXcF8Slgcu3jQL4EegYJqSZh4ySl+pBxg 2DO0RiCpNvTciBgj5FkLVbdyN8bW27GVf8aGkos= X-Google-Smtp-Source: ABdhPJwPQuU1umbzHs0AJtjSZtlKt3cKEhS0AjOuobmEY6ysunNkpvrb+zdwqw/9Gv8yOZQu0gTllxVLx8C+clsD3c0= X-Received: by 2002:a1c:f414:: with SMTP id z20mr398052wma.94.1628532187414; Mon, 09 Aug 2021 11:03:07 -0700 (PDT) MIME-Version: 1.0 References: <20210728140052.GB22887@mms-0441> <8b2742c8891abe4fec3664730717a089@codeaurora.org> <20210802105544.GA27657@willie-the-truck> <20210802151409.GE28735@willie-the-truck> <20210809145651.GC1458@willie-the-truck> <20210809170508.GB1589@willie-the-truck> <20210809174022.GA1840@willie-the-truck> <76bfd0b4248148dfbf9d174ddcb4c2a2@codeaurora.org> In-Reply-To: <76bfd0b4248148dfbf9d174ddcb4c2a2@codeaurora.org> From: Rob Clark Date: Mon, 9 Aug 2021 11:07:22 -0700 Message-ID: Subject: Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache To: Sai Prakash Ranjan Cc: "Isaac J. Manjarres" , freedreno , Jordan Crouse , David Airlie , Sean Paul , Akhil P Oommen , dri-devel , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Kristian H Kristensen , Daniel Vetter , linux-arm-msm , Will Deacon , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Robin Murphy X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Aug 9, 2021 at 10:47 AM Sai Prakash Ranjan wrote: > > On 2021-08-09 23:10, Will Deacon wrote: > > On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob Clark wrote: > >> On Mon, Aug 9, 2021 at 10:05 AM Will Deacon wrote: > >> > > >> > On Mon, Aug 09, 2021 at 09:57:08AM -0700, Rob Clark wrote: > >> > > On Mon, Aug 9, 2021 at 7:56 AM Will Deacon wrote: > >> > > > On Mon, Aug 02, 2021 at 06:36:04PM -0700, Rob Clark wrote: > >> > > > > On Mon, Aug 2, 2021 at 8:14 AM Will Deacon wrote: > >> > > > > > On Mon, Aug 02, 2021 at 08:08:07AM -0700, Rob Clark wrote: > >> > > > > > > On Mon, Aug 2, 2021 at 3:55 AM Will Deacon wrote: > >> > > > > > > > On Thu, Jul 29, 2021 at 10:08:22AM +0530, Sai Prakash Ranjan wrote: > >> > > > > > > > > On 2021-07-28 19:30, Georgi Djakov wrote: > >> > > > > > > > > > On Mon, Jan 11, 2021 at 07:45:02PM +0530, Sai Prakash Ranjan wrote: > >> > > > > > > > > > > commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") > >> > > > > > > > > > > removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went > >> > > > > > > > > > > the memory type setting required for the non-coherent masters to use > >> > > > > > > > > > > system cache. Now that system cache support for GPU is added, we will > >> > > > > > > > > > > need to set the right PTE attribute for GPU buffers to be sys cached. > >> > > > > > > > > > > Without this, the system cache lines are not allocated for GPU. > >> > > > > > > > > > > > >> > > > > > > > > > > So the patches in this series introduces a new prot flag IOMMU_LLC, > >> > > > > > > > > > > renames IO_PGTABLE_QUIRK_ARM_OUTER_WBWA to IO_PGTABLE_QUIRK_PTW_LLC > >> > > > > > > > > > > and makes GPU the user of this protection flag. > >> > > > > > > > > > > >> > > > > > > > > > Thank you for the patchset! Are you planning to refresh it, as it does > >> > > > > > > > > > not apply anymore? > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > I was waiting on Will's reply [1]. If there are no changes needed, then > >> > > > > > > > > I can repost the patch. > >> > > > > > > > > >> > > > > > > > I still think you need to handle the mismatched alias, no? You're adding > >> > > > > > > > a new memory type to the SMMU which doesn't exist on the CPU side. That > >> > > > > > > > can't be right. > >> > > > > > > > > >> > > > > > > > >> > > > > > > Just curious, and maybe this is a dumb question, but what is your > >> > > > > > > concern about mismatched aliases? I mean the cache hierarchy on the > >> > > > > > > GPU device side (anything beyond the LLC) is pretty different and > >> > > > > > > doesn't really care about the smmu pgtable attributes.. > >> > > > > > > >> > > > > > If the CPU accesses a shared buffer with different attributes to those which > >> > > > > > the device is using then you fall into the "mismatched memory attributes" > >> > > > > > part of the Arm architecture. It's reasonably unforgiving (you should go and > >> > > > > > read it) and in some cases can apply to speculative accesses as well, but > >> > > > > > the end result is typically loss of coherency. > >> > > > > > >> > > > > Ok, I might have a few other sections to read first to decipher the > >> > > > > terminology.. > >> > > > > > >> > > > > But my understanding of LLC is that it looks just like system memory > >> > > > > to the CPU and GPU (I think that would make it "the point of > >> > > > > coherence" between the GPU and CPU?) If that is true, shouldn't it be > >> > > > > invisible from the point of view of different CPU mapping options? > >> > > > > >> > > > You could certainly build a system where mismatched attributes don't cause > >> > > > loss of coherence, but as it's not guaranteed by the architecture and the > >> > > > changes proposed here affect APIs which are exposed across SoCs, then I > >> > > > don't think it helps much. > >> > > > > >> > > > >> > > Hmm, the description of the new mapping flag is that it applies only > >> > > to transparent outer level cache: > >> > > > >> > > +/* > >> > > + * Non-coherent masters can use this page protection flag to set cacheable > >> > > + * memory attributes for only a transparent outer level of cache, also known as > >> > > + * the last-level or system cache. > >> > > + */ > >> > > +#define IOMMU_LLC (1 << 6) > >> > > > >> > > But I suppose we could call it instead IOMMU_QCOM_LLC or something > >> > > like that to make it more clear that it is not necessarily something > >> > > that would work with a different outer level cache implementation? > >> > > >> > ... or we could just deal with the problem so that other people can reuse > >> > the code. I haven't really understood the reluctance to solve this properly. > >> > > >> > Am I missing some reason this isn't solvable? > >> > >> Oh, was there another way to solve it (other than foregoing setting > >> INC_OCACHE in the pgtables)? Maybe I misunderstood, is there a > >> corresponding setting on the MMU pgtables side of things? > > > > Right -- we just need to program the CPU's MMU with the matching memory > > attributes! It's a bit more fiddly if you're just using ioremap_wc() > > though, as it's usually the DMA API which handles the attributes under > > the > > hood. > > > > Anyway, sorry, I should've said that explicitly earlier on. We've done > > this > > sort of thing in the Android tree so I assumed Sai knew what needed to > > be > > done and then I didn't think to explain to you :( > > > > Right I was aware of that but even in the android tree there is no user > :) > I think we can't have a new memory type without any user right in > upstream > like android tree? > > @Rob, I think you already tried adding a new MT and used > pgprot_syscached() > in GPU driver but it was crashing? Correct, but IIRC there were some differences in the code for memory types compared to the android tree.. I couldn't figure out the necessary patches to cherry-pick to get the android patch to apply cleanly, so I tried re-implementing it without having much of a clue about how that code works (which was probably the issue) ;-) BR, -R _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA48C4338F for ; Mon, 9 Aug 2021 18:04:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09FB4601FC for ; Mon, 9 Aug 2021 18:04:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 09FB4601FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gaCOdsteIVJ2Js29CMvm7L3O55t6CksLqjtd+tTMi/o=; b=E6iYKW16CWxsh7 KrpaajAKhcbroEmsHC6dn21elXNsrvXY01rBpo2N5Iknu84RU6PstWcZMdsVW+HM2rJnye/2e+KFQ nRYX8c0L7ktjxApVLJf2kkS9/Ifyj7T0gwlo+BrDzgsIVC6BAW2BuJZW/gRe3TbUC99dbVZjcvadY 3luWj5gkpPMTRZim2ewCbzN43epMu3vIx39/AMtJb8FgkOJFRXZDGi73xxt2zGUxagGU6ZaU/dBhn Oqtnr+RfSrzFJ6yFrQvbGqg9nLERh+UcA+g7ypLe8ouoG5yxKps7n0JjVr/Il/fwNfj34aakXgucV tn8RQXPkJXAwwu0wMJUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD9cI-001dTf-4r; Mon, 09 Aug 2021 18:03:14 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD9cE-001dSX-63 for linux-arm-kernel@lists.infradead.org; Mon, 09 Aug 2021 18:03:11 +0000 Received: by mail-wm1-x32c.google.com with SMTP id b128so11178968wmb.4 for ; Mon, 09 Aug 2021 11:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AottaItdNpwEGaBVEcs2HSf4MSRq1/DJ2ThJuxRDL0Y=; b=t3NjC6Wc6R/U+WyQTTgjVH/rdU4MqhTP0Ldt3iBZ+QpVu9bL/uGwFDnkHE9hVifDCw 3IHL95I8zaBeiaRjAM8US5bFNnCjxRac/VGFA+Geg17X9YiMzbnumQpHDImztVOSJ7zm pyRaYK6D8iHhJZyQf177eCA5HEiqiDgZx1cwGEq3jiyTFf0a3HaF4WT3h2XDMC9JveI8 25FJk7rWKgpQTmPm+7RSUs+LWiOVzjwOm6CljybSU6PCzUweeQn5O2mir8+//cpT9hE3 jh0ItWDJiXwm4P60mG+2u9z+n9u2Ajd1YDkL5rO3eq0Xr1w8yOfy8tu3aDGGz69D8y9B sZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AottaItdNpwEGaBVEcs2HSf4MSRq1/DJ2ThJuxRDL0Y=; b=UNwHjbo/e0JDMdbyd/WBvEuy+G3uBDPzw2cfhqSBwjDiXzkVGpJoX1rfExieb0Bpu3 clRiilXNnmLSV6BaU7YD2sHCj9QCn6WwjrmEkGlwsOzu0G0Qhdw0Cr2A+nPyaRaX4i5c K2qnGxgJAFd01QqKtFdg6tdJxsNm/qOvTJLLeUUY5AvwCAYt3ctIwfwKX4hiV5vFQP2E n3ufYHqxMjlKs7sEsqxflDNNSjoSc3OcT0n2klgwIpAVdZdLnF/amDWtpW9EQ8on8xRX qmkbaVVt2MeBG4Fs+LJkLD2WgY2Hiq5IEeSNuvinqARaMDDofu7hS37Y8Z1vbrP3yh9/ jXdA== X-Gm-Message-State: AOAM531ApLaedrCXchQBEIqxMDnZKGjLGfUJVBfq0u34S6KrxnPcx0AA WTh8mBR1JfAboM2RN3EOg8VuIf2r/EWACOzewq8= X-Google-Smtp-Source: ABdhPJwPQuU1umbzHs0AJtjSZtlKt3cKEhS0AjOuobmEY6ysunNkpvrb+zdwqw/9Gv8yOZQu0gTllxVLx8C+clsD3c0= X-Received: by 2002:a1c:f414:: with SMTP id z20mr398052wma.94.1628532187414; Mon, 09 Aug 2021 11:03:07 -0700 (PDT) MIME-Version: 1.0 References: <20210728140052.GB22887@mms-0441> <8b2742c8891abe4fec3664730717a089@codeaurora.org> <20210802105544.GA27657@willie-the-truck> <20210802151409.GE28735@willie-the-truck> <20210809145651.GC1458@willie-the-truck> <20210809170508.GB1589@willie-the-truck> <20210809174022.GA1840@willie-the-truck> <76bfd0b4248148dfbf9d174ddcb4c2a2@codeaurora.org> In-Reply-To: <76bfd0b4248148dfbf9d174ddcb4c2a2@codeaurora.org> From: Rob Clark Date: Mon, 9 Aug 2021 11:07:22 -0700 Message-ID: Subject: Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache To: Sai Prakash Ranjan Cc: Will Deacon , Georgi Djakov , "Isaac J. Manjarres" , David Airlie , Akhil P Oommen , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Kernel Mailing List , Sean Paul , Jordan Crouse , Kristian H Kristensen , dri-devel , Daniel Vetter , linux-arm-msm , freedreno , Robin Murphy , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210809_110310_280031_B8060EE8 X-CRM114-Status: GOOD ( 61.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 9, 2021 at 10:47 AM Sai Prakash Ranjan wrote: > > On 2021-08-09 23:10, Will Deacon wrote: > > On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob Clark wrote: > >> On Mon, Aug 9, 2021 at 10:05 AM Will Deacon wrote: > >> > > >> > On Mon, Aug 09, 2021 at 09:57:08AM -0700, Rob Clark wrote: > >> > > On Mon, Aug 9, 2021 at 7:56 AM Will Deacon wrote: > >> > > > On Mon, Aug 02, 2021 at 06:36:04PM -0700, Rob Clark wrote: > >> > > > > On Mon, Aug 2, 2021 at 8:14 AM Will Deacon wrote: > >> > > > > > On Mon, Aug 02, 2021 at 08:08:07AM -0700, Rob Clark wrote: > >> > > > > > > On Mon, Aug 2, 2021 at 3:55 AM Will Deacon wrote: > >> > > > > > > > On Thu, Jul 29, 2021 at 10:08:22AM +0530, Sai Prakash Ranjan wrote: > >> > > > > > > > > On 2021-07-28 19:30, Georgi Djakov wrote: > >> > > > > > > > > > On Mon, Jan 11, 2021 at 07:45:02PM +0530, Sai Prakash Ranjan wrote: > >> > > > > > > > > > > commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") > >> > > > > > > > > > > removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went > >> > > > > > > > > > > the memory type setting required for the non-coherent masters to use > >> > > > > > > > > > > system cache. Now that system cache support for GPU is added, we will > >> > > > > > > > > > > need to set the right PTE attribute for GPU buffers to be sys cached. > >> > > > > > > > > > > Without this, the system cache lines are not allocated for GPU. > >> > > > > > > > > > > > >> > > > > > > > > > > So the patches in this series introduces a new prot flag IOMMU_LLC, > >> > > > > > > > > > > renames IO_PGTABLE_QUIRK_ARM_OUTER_WBWA to IO_PGTABLE_QUIRK_PTW_LLC > >> > > > > > > > > > > and makes GPU the user of this protection flag. > >> > > > > > > > > > > >> > > > > > > > > > Thank you for the patchset! Are you planning to refresh it, as it does > >> > > > > > > > > > not apply anymore? > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > I was waiting on Will's reply [1]. If there are no changes needed, then > >> > > > > > > > > I can repost the patch. > >> > > > > > > > > >> > > > > > > > I still think you need to handle the mismatched alias, no? You're adding > >> > > > > > > > a new memory type to the SMMU which doesn't exist on the CPU side. That > >> > > > > > > > can't be right. > >> > > > > > > > > >> > > > > > > > >> > > > > > > Just curious, and maybe this is a dumb question, but what is your > >> > > > > > > concern about mismatched aliases? I mean the cache hierarchy on the > >> > > > > > > GPU device side (anything beyond the LLC) is pretty different and > >> > > > > > > doesn't really care about the smmu pgtable attributes.. > >> > > > > > > >> > > > > > If the CPU accesses a shared buffer with different attributes to those which > >> > > > > > the device is using then you fall into the "mismatched memory attributes" > >> > > > > > part of the Arm architecture. It's reasonably unforgiving (you should go and > >> > > > > > read it) and in some cases can apply to speculative accesses as well, but > >> > > > > > the end result is typically loss of coherency. > >> > > > > > >> > > > > Ok, I might have a few other sections to read first to decipher the > >> > > > > terminology.. > >> > > > > > >> > > > > But my understanding of LLC is that it looks just like system memory > >> > > > > to the CPU and GPU (I think that would make it "the point of > >> > > > > coherence" between the GPU and CPU?) If that is true, shouldn't it be > >> > > > > invisible from the point of view of different CPU mapping options? > >> > > > > >> > > > You could certainly build a system where mismatched attributes don't cause > >> > > > loss of coherence, but as it's not guaranteed by the architecture and the > >> > > > changes proposed here affect APIs which are exposed across SoCs, then I > >> > > > don't think it helps much. > >> > > > > >> > > > >> > > Hmm, the description of the new mapping flag is that it applies only > >> > > to transparent outer level cache: > >> > > > >> > > +/* > >> > > + * Non-coherent masters can use this page protection flag to set cacheable > >> > > + * memory attributes for only a transparent outer level of cache, also known as > >> > > + * the last-level or system cache. > >> > > + */ > >> > > +#define IOMMU_LLC (1 << 6) > >> > > > >> > > But I suppose we could call it instead IOMMU_QCOM_LLC or something > >> > > like that to make it more clear that it is not necessarily something > >> > > that would work with a different outer level cache implementation? > >> > > >> > ... or we could just deal with the problem so that other people can reuse > >> > the code. I haven't really understood the reluctance to solve this properly. > >> > > >> > Am I missing some reason this isn't solvable? > >> > >> Oh, was there another way to solve it (other than foregoing setting > >> INC_OCACHE in the pgtables)? Maybe I misunderstood, is there a > >> corresponding setting on the MMU pgtables side of things? > > > > Right -- we just need to program the CPU's MMU with the matching memory > > attributes! It's a bit more fiddly if you're just using ioremap_wc() > > though, as it's usually the DMA API which handles the attributes under > > the > > hood. > > > > Anyway, sorry, I should've said that explicitly earlier on. We've done > > this > > sort of thing in the Android tree so I assumed Sai knew what needed to > > be > > done and then I didn't think to explain to you :( > > > > Right I was aware of that but even in the android tree there is no user > :) > I think we can't have a new memory type without any user right in > upstream > like android tree? > > @Rob, I think you already tried adding a new MT and used > pgprot_syscached() > in GPU driver but it was crashing? Correct, but IIRC there were some differences in the code for memory types compared to the android tree.. I couldn't figure out the necessary patches to cherry-pick to get the android patch to apply cleanly, so I tried re-implementing it without having much of a clue about how that code works (which was probably the issue) ;-) BR, -R _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80D7BC4338F for ; Mon, 9 Aug 2021 18:03:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 27890601FC for ; Mon, 9 Aug 2021 18:03:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 27890601FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 632F289C53; Mon, 9 Aug 2021 18:03:10 +0000 (UTC) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3253A89C53; Mon, 9 Aug 2021 18:03:09 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id n11so11183358wmd.2; Mon, 09 Aug 2021 11:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AottaItdNpwEGaBVEcs2HSf4MSRq1/DJ2ThJuxRDL0Y=; b=t3NjC6Wc6R/U+WyQTTgjVH/rdU4MqhTP0Ldt3iBZ+QpVu9bL/uGwFDnkHE9hVifDCw 3IHL95I8zaBeiaRjAM8US5bFNnCjxRac/VGFA+Geg17X9YiMzbnumQpHDImztVOSJ7zm pyRaYK6D8iHhJZyQf177eCA5HEiqiDgZx1cwGEq3jiyTFf0a3HaF4WT3h2XDMC9JveI8 25FJk7rWKgpQTmPm+7RSUs+LWiOVzjwOm6CljybSU6PCzUweeQn5O2mir8+//cpT9hE3 jh0ItWDJiXwm4P60mG+2u9z+n9u2Ajd1YDkL5rO3eq0Xr1w8yOfy8tu3aDGGz69D8y9B sZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AottaItdNpwEGaBVEcs2HSf4MSRq1/DJ2ThJuxRDL0Y=; b=HB8/yWMPZss6bb144EXbgS6Lv8/enew4dq+hQj2j/EnBjmV4H7xAZz5D/7RgxEfrO0 pGwosVbLYf/m+cxbP2ijV3UkN8y7nF79FsY4s/LRPuX4K+LQqREMJC0vYLZ47VaX5oVR wg22Iz3fkgCyYB1Sr0re0R2lU8gKzwxaaDE4j/XCERqdtO8JBOrPuepzgx9hCjCNVEJe 7+/yJBqZhxvkwcMix3yIqudW9D5hrc0Jqc1/b2n4d+lO2+RRKlz7TiJe8lqhpSlIs/pA /zCl8D2ZRY303CRsVSKzJkQ1AKErqzfs7vADW+ZvBztS7+FOOx+IiEhJargd0leUlqPE J2xQ== X-Gm-Message-State: AOAM532MgQVOGNlSNNGizz2JlyZCYDRBXokJZmTNbs6aTjDQJ9xtaxLJ rxgh+YrOL/55TT1+B6xquODVCZxdbzXu56oc8kM= X-Google-Smtp-Source: ABdhPJwPQuU1umbzHs0AJtjSZtlKt3cKEhS0AjOuobmEY6ysunNkpvrb+zdwqw/9Gv8yOZQu0gTllxVLx8C+clsD3c0= X-Received: by 2002:a1c:f414:: with SMTP id z20mr398052wma.94.1628532187414; Mon, 09 Aug 2021 11:03:07 -0700 (PDT) MIME-Version: 1.0 References: <20210728140052.GB22887@mms-0441> <8b2742c8891abe4fec3664730717a089@codeaurora.org> <20210802105544.GA27657@willie-the-truck> <20210802151409.GE28735@willie-the-truck> <20210809145651.GC1458@willie-the-truck> <20210809170508.GB1589@willie-the-truck> <20210809174022.GA1840@willie-the-truck> <76bfd0b4248148dfbf9d174ddcb4c2a2@codeaurora.org> In-Reply-To: <76bfd0b4248148dfbf9d174ddcb4c2a2@codeaurora.org> From: Rob Clark Date: Mon, 9 Aug 2021 11:07:22 -0700 Message-ID: Subject: Re: [Freedreno] [PATCH 0/3] iommu/drm/msm: Allow non-coherent masters to use system cache To: Sai Prakash Ranjan Cc: Will Deacon , Georgi Djakov , "Isaac J. Manjarres" , David Airlie , Akhil P Oommen , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Kernel Mailing List , Sean Paul , Jordan Crouse , Kristian H Kristensen , dri-devel , Daniel Vetter , linux-arm-msm , freedreno , Robin Murphy , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Aug 9, 2021 at 10:47 AM Sai Prakash Ranjan wrote: > > On 2021-08-09 23:10, Will Deacon wrote: > > On Mon, Aug 09, 2021 at 10:18:21AM -0700, Rob Clark wrote: > >> On Mon, Aug 9, 2021 at 10:05 AM Will Deacon wrote: > >> > > >> > On Mon, Aug 09, 2021 at 09:57:08AM -0700, Rob Clark wrote: > >> > > On Mon, Aug 9, 2021 at 7:56 AM Will Deacon wrote: > >> > > > On Mon, Aug 02, 2021 at 06:36:04PM -0700, Rob Clark wrote: > >> > > > > On Mon, Aug 2, 2021 at 8:14 AM Will Deacon wrote: > >> > > > > > On Mon, Aug 02, 2021 at 08:08:07AM -0700, Rob Clark wrote: > >> > > > > > > On Mon, Aug 2, 2021 at 3:55 AM Will Deacon wrote: > >> > > > > > > > On Thu, Jul 29, 2021 at 10:08:22AM +0530, Sai Prakash Ranjan wrote: > >> > > > > > > > > On 2021-07-28 19:30, Georgi Djakov wrote: > >> > > > > > > > > > On Mon, Jan 11, 2021 at 07:45:02PM +0530, Sai Prakash Ranjan wrote: > >> > > > > > > > > > > commit ecd7274fb4cd ("iommu: Remove unused IOMMU_SYS_CACHE_ONLY flag") > >> > > > > > > > > > > removed unused IOMMU_SYS_CACHE_ONLY prot flag and along with it went > >> > > > > > > > > > > the memory type setting required for the non-coherent masters to use > >> > > > > > > > > > > system cache. Now that system cache support for GPU is added, we will > >> > > > > > > > > > > need to set the right PTE attribute for GPU buffers to be sys cached. > >> > > > > > > > > > > Without this, the system cache lines are not allocated for GPU. > >> > > > > > > > > > > > >> > > > > > > > > > > So the patches in this series introduces a new prot flag IOMMU_LLC, > >> > > > > > > > > > > renames IO_PGTABLE_QUIRK_ARM_OUTER_WBWA to IO_PGTABLE_QUIRK_PTW_LLC > >> > > > > > > > > > > and makes GPU the user of this protection flag. > >> > > > > > > > > > > >> > > > > > > > > > Thank you for the patchset! Are you planning to refresh it, as it does > >> > > > > > > > > > not apply anymore? > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > I was waiting on Will's reply [1]. If there are no changes needed, then > >> > > > > > > > > I can repost the patch. > >> > > > > > > > > >> > > > > > > > I still think you need to handle the mismatched alias, no? You're adding > >> > > > > > > > a new memory type to the SMMU which doesn't exist on the CPU side. That > >> > > > > > > > can't be right. > >> > > > > > > > > >> > > > > > > > >> > > > > > > Just curious, and maybe this is a dumb question, but what is your > >> > > > > > > concern about mismatched aliases? I mean the cache hierarchy on the > >> > > > > > > GPU device side (anything beyond the LLC) is pretty different and > >> > > > > > > doesn't really care about the smmu pgtable attributes.. > >> > > > > > > >> > > > > > If the CPU accesses a shared buffer with different attributes to those which > >> > > > > > the device is using then you fall into the "mismatched memory attributes" > >> > > > > > part of the Arm architecture. It's reasonably unforgiving (you should go and > >> > > > > > read it) and in some cases can apply to speculative accesses as well, but > >> > > > > > the end result is typically loss of coherency. > >> > > > > > >> > > > > Ok, I might have a few other sections to read first to decipher the > >> > > > > terminology.. > >> > > > > > >> > > > > But my understanding of LLC is that it looks just like system memory > >> > > > > to the CPU and GPU (I think that would make it "the point of > >> > > > > coherence" between the GPU and CPU?) If that is true, shouldn't it be > >> > > > > invisible from the point of view of different CPU mapping options? > >> > > > > >> > > > You could certainly build a system where mismatched attributes don't cause > >> > > > loss of coherence, but as it's not guaranteed by the architecture and the > >> > > > changes proposed here affect APIs which are exposed across SoCs, then I > >> > > > don't think it helps much. > >> > > > > >> > > > >> > > Hmm, the description of the new mapping flag is that it applies only > >> > > to transparent outer level cache: > >> > > > >> > > +/* > >> > > + * Non-coherent masters can use this page protection flag to set cacheable > >> > > + * memory attributes for only a transparent outer level of cache, also known as > >> > > + * the last-level or system cache. > >> > > + */ > >> > > +#define IOMMU_LLC (1 << 6) > >> > > > >> > > But I suppose we could call it instead IOMMU_QCOM_LLC or something > >> > > like that to make it more clear that it is not necessarily something > >> > > that would work with a different outer level cache implementation? > >> > > >> > ... or we could just deal with the problem so that other people can reuse > >> > the code. I haven't really understood the reluctance to solve this properly. > >> > > >> > Am I missing some reason this isn't solvable? > >> > >> Oh, was there another way to solve it (other than foregoing setting > >> INC_OCACHE in the pgtables)? Maybe I misunderstood, is there a > >> corresponding setting on the MMU pgtables side of things? > > > > Right -- we just need to program the CPU's MMU with the matching memory > > attributes! It's a bit more fiddly if you're just using ioremap_wc() > > though, as it's usually the DMA API which handles the attributes under > > the > > hood. > > > > Anyway, sorry, I should've said that explicitly earlier on. We've done > > this > > sort of thing in the Android tree so I assumed Sai knew what needed to > > be > > done and then I didn't think to explain to you :( > > > > Right I was aware of that but even in the android tree there is no user > :) > I think we can't have a new memory type without any user right in > upstream > like android tree? > > @Rob, I think you already tried adding a new MT and used > pgprot_syscached() > in GPU driver but it was crashing? Correct, but IIRC there were some differences in the code for memory types compared to the android tree.. I couldn't figure out the necessary patches to cherry-pick to get the android patch to apply cleanly, so I tried re-implementing it without having much of a clue about how that code works (which was probably the issue) ;-) BR, -R