From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96317C433DB for ; Tue, 23 Mar 2021 01:55:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EC7E619AE for ; Tue, 23 Mar 2021 01:55:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229897AbhCWBzX (ORCPT ); Mon, 22 Mar 2021 21:55:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbhCWByv (ORCPT ); Mon, 22 Mar 2021 21:54:51 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEA60C061574; Mon, 22 Mar 2021 18:54:50 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id e9so19110681wrw.10; Mon, 22 Mar 2021 18:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y6kHhDqex1SsXfv+a9vGItXQc8cTJtK09N7Ycugrx0A=; b=AGnsZG7v8ZQN4wrf+x88MnVVF27VSEBSsTbTyz9kRn9dkyDbY252e9aOnIEyhgcshO 1mS6WaoW6Y8GFgyvxfBnm0G6rZCJhzhfw44+Fm4gCPH07So2oKhMMT7PC9lAHPT3s6C0 fpRdCfgK9+YZedOaGXRWhyIFo+IQKpRjUXrsWY7m8jwFhIMT0O8od097BQ0Ir3FsZyMp cdP6epLhx88/YsFVfridrXTncgfGl2mUgx73Um8qtnWFFlR3I9A1BYz5KWREkzsfz3Id 2GVLSJHGiQticjF2DNf0HmPqN+zqLuj/kKBLoFDYYT4xZ6UU7Os5GYqWUu/gRREpuRiu AOJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y6kHhDqex1SsXfv+a9vGItXQc8cTJtK09N7Ycugrx0A=; b=tvSfAt7AHf3XROmr51pi8MfH0CavqvLrCWP2d1W+NIh3Gvw3fQP8B4N0il9c3loXrS P/X3vDKWZCKyjz3OBpuW2PHlbIbIR8Sfm+I7KlYAEqeuUOilxdZkPd9xwmkRfMqkHBr4 U5KITMUsghxqagFQbrAsqpj1VU76Ct+IZ/jpgFiLIPayMD5JweVaQ3CcpK7u00kQ0hcr 5HFruHzNkEslUeZ9NxVUW4cQ+4CpgZdyuUWGHhblnXDPmlErp0ARgD42UWsx01CxvOQ5 yPy+dMUthLaqoBpLsQiqM5qCcV+foxTfeRt6qewQfKqk3Ah1GLQ3BQtwzJTAN1utXXBQ 4zlA== X-Gm-Message-State: AOAM532cx5sd4sDbuwL35Ti2vSUqKn8GtB+vpVqF8omtrQJXra9xvGZG ARUWKOKBwk+BoGPzZUXOGllUZ/gm6DO9awAMuMY= X-Google-Smtp-Source: ABdhPJw4B2u3R2fdqQZBeZ0j8MaOwUzUX6lJF7RGtQiYESsOZ3iClSdFOM/g/oIrWV9NpPoO6xUEEzrgTo0pF8/EEb4= X-Received: by 2002:adf:f587:: with SMTP id f7mr1304735wro.147.1616464489599; Mon, 22 Mar 2021 18:54:49 -0700 (PDT) MIME-Version: 1.0 References: <1616404632-13693-1-git-send-email-kalyan_t@codeaurora.org> In-Reply-To: From: Rob Clark Date: Mon, 22 Mar 2021 18:58:01 -0700 Message-ID: Subject: Re: [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume To: Matthias Kaehlcke Cc: Kalyan Thota , y@qualcomm.com, dri-devel , linux-arm-msm , freedreno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Kalyan Thota , Linux Kernel Mailing List , Douglas Anderson , Krishna Manikandan , hywu@google.com, midean@google.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Mar 22, 2021 at 5:44 PM Matthias Kaehlcke wrote: > > On Mon, Mar 22, 2021 at 02:17:12AM -0700, Kalyan Thota wrote: > > From: Kalyan Thota > > > > DPU runtime resume will request for a min vote on the AXI bus as > > it is a necessary step before turning ON the AXI clock. > > > > The change does below > > 1) Move the icc path set before requesting runtime get_sync. > > 2) remove the dependency of hw catalog for min ib vote > > as it is initialized at a later point. > > > > Signed-off-by: Kalyan Thota > > Confirmed that this fixes a bunch of warnings at boot on SC7180 when > (out-of-tree) camera support is enabled: > > [ 1.832228] gcc_disp_hf_axi_clk status stuck at 'off' > [ 2.118292] gcc_disp_hf_axi_clk status stuck at 'off' > [ 2.442383] gcc_disp_hf_axi_clk already disabled > [ 2.750054] gcc_disp_hf_axi_clk already unprepared > [ 3.154835] gcc_disp_hf_axi_clk already disabled > [ 3.421835] gcc_disp_hf_axi_clk already unprepared > > Tested-by: Matthias Kaehlcke thanks for testing on the setup which had this issue.. I've pushed to msm-next BR, -R From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B07F4C433E0 for ; Tue, 23 Mar 2021 01:54:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39C5B619A8 for ; Tue, 23 Mar 2021 01:54:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39C5B619A8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A34A6E829; Tue, 23 Mar 2021 01:54:52 +0000 (UTC) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB3406E822; Tue, 23 Mar 2021 01:54:50 +0000 (UTC) Received: by mail-wr1-x42e.google.com with SMTP id o16so19133470wrn.0; Mon, 22 Mar 2021 18:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y6kHhDqex1SsXfv+a9vGItXQc8cTJtK09N7Ycugrx0A=; b=AGnsZG7v8ZQN4wrf+x88MnVVF27VSEBSsTbTyz9kRn9dkyDbY252e9aOnIEyhgcshO 1mS6WaoW6Y8GFgyvxfBnm0G6rZCJhzhfw44+Fm4gCPH07So2oKhMMT7PC9lAHPT3s6C0 fpRdCfgK9+YZedOaGXRWhyIFo+IQKpRjUXrsWY7m8jwFhIMT0O8od097BQ0Ir3FsZyMp cdP6epLhx88/YsFVfridrXTncgfGl2mUgx73Um8qtnWFFlR3I9A1BYz5KWREkzsfz3Id 2GVLSJHGiQticjF2DNf0HmPqN+zqLuj/kKBLoFDYYT4xZ6UU7Os5GYqWUu/gRREpuRiu AOJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y6kHhDqex1SsXfv+a9vGItXQc8cTJtK09N7Ycugrx0A=; b=YH0bUcUldY0fnv+893IaHHlZ3XzHnI/GKtxrDgRpIb0P+LsFkxulojRhlP92SKRBbA RNBzU1Qwm9hLtuvwdv6Ijba3I0SKgsvKK/tf8X95H+obifY97LpCfk9Ct6isOrdnxdxV LqDYNttv7mNhExnqIL+Hh6lVk/dMd7HF+2qCV+TbykKTokkKz7uGIXPjf54qPJoJn78w nkQyfAvQCH0Fngtjw0l7I9Z2btZWhcKcERcjc1EfCYEgsFBd3uINpF8WKIL5S0AH0MHD FelLybU9K1d0cYAa6xkT3XaK8qUHE0fwl8o4OUWhOFSfIsNrmlOG80EhYtfCCPAcr3Z9 ttNw== X-Gm-Message-State: AOAM530NBsVsT4oZjsOs0AmEC7r93HjEUpo/qNblWv7yx6nzWKvUWApx c9GhGD0GpAPioOA75NW6EdtgNoVKysHjoUlkHMg= X-Google-Smtp-Source: ABdhPJw4B2u3R2fdqQZBeZ0j8MaOwUzUX6lJF7RGtQiYESsOZ3iClSdFOM/g/oIrWV9NpPoO6xUEEzrgTo0pF8/EEb4= X-Received: by 2002:adf:f587:: with SMTP id f7mr1304735wro.147.1616464489599; Mon, 22 Mar 2021 18:54:49 -0700 (PDT) MIME-Version: 1.0 References: <1616404632-13693-1-git-send-email-kalyan_t@codeaurora.org> In-Reply-To: From: Rob Clark Date: Mon, 22 Mar 2021 18:58:01 -0700 Message-ID: Subject: Re: [v1] drm/msm/disp/dpu1: icc path needs to be set before dpu runtime resume To: Matthias Kaehlcke X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Douglas Anderson , Krishna Manikandan , linux-arm-msm , hywu@google.com, Linux Kernel Mailing List , dri-devel , Kalyan Thota , midean@google.com, Kalyan Thota , freedreno , y@qualcomm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 22, 2021 at 5:44 PM Matthias Kaehlcke wrote: > > On Mon, Mar 22, 2021 at 02:17:12AM -0700, Kalyan Thota wrote: > > From: Kalyan Thota > > > > DPU runtime resume will request for a min vote on the AXI bus as > > it is a necessary step before turning ON the AXI clock. > > > > The change does below > > 1) Move the icc path set before requesting runtime get_sync. > > 2) remove the dependency of hw catalog for min ib vote > > as it is initialized at a later point. > > > > Signed-off-by: Kalyan Thota > > Confirmed that this fixes a bunch of warnings at boot on SC7180 when > (out-of-tree) camera support is enabled: > > [ 1.832228] gcc_disp_hf_axi_clk status stuck at 'off' > [ 2.118292] gcc_disp_hf_axi_clk status stuck at 'off' > [ 2.442383] gcc_disp_hf_axi_clk already disabled > [ 2.750054] gcc_disp_hf_axi_clk already unprepared > [ 3.154835] gcc_disp_hf_axi_clk already disabled > [ 3.421835] gcc_disp_hf_axi_clk already unprepared > > Tested-by: Matthias Kaehlcke thanks for testing on the setup which had this issue.. I've pushed to msm-next BR, -R _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel