From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BD94C35247 for ; Tue, 4 Feb 2020 00:40:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3C6220732 for ; Tue, 4 Feb 2020 00:40:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OMhFkOfW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726834AbgBDAkz (ORCPT ); Mon, 3 Feb 2020 19:40:55 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:37023 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726872AbgBDAky (ORCPT ); Mon, 3 Feb 2020 19:40:54 -0500 Received: by mail-ed1-f65.google.com with SMTP id cy15so18078361edb.4; Mon, 03 Feb 2020 16:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Dj1hr3nC99JuvkU09XV7ayB0+YSPBYgoXgElkOJgmzg=; b=OMhFkOfWAK0jlVydiXMohJVXTPAHEPDPkHJ1c6tFod2BMXKyBEkqSsiZmNK7hdp2ji hjvvzsv+zfuvHAvV1IGMHpcWwzdQllCn5Q56ibwE1N4L7kkL6c+3Q/y5p+WE5FFcSQNY aw1xsgtt7Dysn69u9irzrCJcxh31dOeUWw5vj6raP8DsnnqT3fjhYYOYO45wlmnsVfsK 4wl3SJV5LAfPBX6E1HhLC5vn8q8tiGC6QSoyEgieQh1bnnJFTc5FNYsxdLsenT6W7vXu SfT2R2XmOAhLg/RSVkWJhKGpez+yifBE0Rf79xuBE6Pp8fx5kEFFSfXeVdyKpEqzLA1i VU1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Dj1hr3nC99JuvkU09XV7ayB0+YSPBYgoXgElkOJgmzg=; b=hm69oxuM97wrkcZ1vfrbZJIlh8Aiu143O5HlPNxVZpHZwdOmKs5hb8fj+dYbGTpF5y 2DINgy+j4P9C9EELBa6x0P0ZnlKkYk8kSEZrzIW3vVYSTZzJWqU+A4iHqsAFN7FLx7QS GBgTPJ2U2XImnhPD6MmyuEBITIxXsJzvN3rmyw3tMc0isqB0TGk7rQAsBA9QO2IXHiYc xoLmYI/Gs6GCguXsrQJjByylhz64D+54zTunwKCti0udqyjAYMuDZWRy8WBrZsnUn//V NeWoicdSp1xijSdUoGl95dWjZ/nRB8LrFfvHgj/KKgJGfrY9HVWsgipJ2kXRvOdemIOy fE6w== X-Gm-Message-State: APjAAAWnH7tYCZW7I8boGjwxxF+ocwJRfXUPAULbbAAc1nHAksSzXbVY TlgOJf3oTS+XXZL30GNkRx1yb8ZIJ8OOUGK9Ek4= X-Google-Smtp-Source: APXvYqyFsuijb4pxN+FCPFBZGR03YAhbbzg8McEI+im+HEHIvWPDusNo46gAIuLArQP5FgrOxgPNDog46maRiViYDNY= X-Received: by 2002:a17:906:19d8:: with SMTP id h24mr22838316ejd.166.1580776851956; Mon, 03 Feb 2020 16:40:51 -0800 (PST) MIME-Version: 1.0 References: <1579763945-10478-1-git-send-email-smasetty@codeaurora.org> <1579763945-10478-2-git-send-email-smasetty@codeaurora.org> In-Reply-To: From: Rob Clark Date: Mon, 3 Feb 2020 16:40:40 -0800 Message-ID: Subject: Re: [Freedreno] [PATCH v2 2/3] drm: msm: a6xx: Add support for A618 To: John Stultz Cc: Sharat Masetty , Amit Pundir , linux-arm-msm , lkml , Bjorn Andersson , dri-devel@freedesktop.org, freedreno , Sumit Semwal Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Feb 3, 2020 at 4:21 PM John Stultz wrote: > > On Wed, Jan 22, 2020 at 11:19 PM Sharat Masetty wrote: > > > > This patch adds support for enabling Graphics Bus Interface(GBIF) > > used in multiple A6xx series chipets. Also makes changes to the > > PDC/RSC sequencing specifically required for A618. This is needed > > for proper interfacing with RPMH. > > > > Signed-off-by: Sharat Masetty > > --- > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > > index dc8ec2c..2ac9a51 100644 > > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > > @@ -378,6 +378,18 @@ static int a6xx_hw_init(struct msm_gpu *gpu) > > struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu); > > int ret; > > > > + /* > > + * During a previous slumber, GBIF halt is asserted to ensure > > + * no further transaction can go through GPU before GPU > > + * headswitch is turned off. > > + * > > + * This halt is deasserted once headswitch goes off but > > + * incase headswitch doesn't goes off clear GBIF halt > > + * here to ensure GPU wake-up doesn't fail because of > > + * halted GPU transactions. > > + */ > > + gpu_write(gpu, REG_A6XX_GBIF_HALT, 0x0); > > + > > /* Make sure the GMU keeps the GPU on while we set it up */ > > a6xx_gmu_set_oob(&a6xx_gpu->gmu, GMU_OOB_GPU_SET); > > > > So I already brought this up on #freedreno but figured I'd follow up > on the list. > > With linus/master, I'm seeing hard crashes (into usb crash mode) with > the db845c, which I isolated down to this patch, and then to the chunk > above. (repeating my speculation from #freedreno for benefit of those not on IRC) I'm suspecting, that like the registers to take the GPU out of secure mode, this register is being blocked on LA devices (like db845c), which is why we didn't see this on cheza. Maybe we can make this write conditional on whether we have a zap shader? BR, -R > Dropping the gpu_write line above gets things booting again for me. > > Let me know if there are any follow on patches I can help validate. > > thanks > -john > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B878BC35247 for ; Tue, 4 Feb 2020 00:40:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 903F820732 for ; Tue, 4 Feb 2020 00:40:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OMhFkOfW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 903F820732 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0127A6E4F4; Tue, 4 Feb 2020 00:40:55 +0000 (UTC) Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6324E6E4F4 for ; Tue, 4 Feb 2020 00:40:53 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id dc19so18000297edb.10 for ; Mon, 03 Feb 2020 16:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Dj1hr3nC99JuvkU09XV7ayB0+YSPBYgoXgElkOJgmzg=; b=OMhFkOfWAK0jlVydiXMohJVXTPAHEPDPkHJ1c6tFod2BMXKyBEkqSsiZmNK7hdp2ji hjvvzsv+zfuvHAvV1IGMHpcWwzdQllCn5Q56ibwE1N4L7kkL6c+3Q/y5p+WE5FFcSQNY aw1xsgtt7Dysn69u9irzrCJcxh31dOeUWw5vj6raP8DsnnqT3fjhYYOYO45wlmnsVfsK 4wl3SJV5LAfPBX6E1HhLC5vn8q8tiGC6QSoyEgieQh1bnnJFTc5FNYsxdLsenT6W7vXu SfT2R2XmOAhLg/RSVkWJhKGpez+yifBE0Rf79xuBE6Pp8fx5kEFFSfXeVdyKpEqzLA1i VU1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Dj1hr3nC99JuvkU09XV7ayB0+YSPBYgoXgElkOJgmzg=; b=CL8tLeDRA5Ktbwxu3MiCusxdik0f+lxowVHi57kyaCSmUgOjFCqB+aMG66WxZRdTRs v5k7xtmcHiLZyJFU4z+Ma4abFIJs9vPPsbI3C0Tuek3EAmvc7taVJ1Z7Lh+tT+hasjHc 52X0knAcOIBBXNevH2i3a3iLNM5VohIe0NUzG5Ti0USBelnsRCJmf4ZCkIYW3nQJt0YF 08NEwDrtGlX0ok1CAs4Oq1JNcVT4Wln1ng4Ou67fnNx/YKOJOYzeowr3bXnxRGLQz0v9 LgCYRRsD6Ii1kN+c8rMuoP8XvUywXUfnmQf+gc78Y74PadRODhA9b1tS9sPNJMY+p7cE BsiA== X-Gm-Message-State: APjAAAU5fDttUwO45hLx/jWQ7KvAQOKfauW14e18xYMIY2EfREx6CQsO Bv7CJ3FDvOhjWSuDialvTw5D/4jIP0JYbYqQ5+E= X-Google-Smtp-Source: APXvYqyFsuijb4pxN+FCPFBZGR03YAhbbzg8McEI+im+HEHIvWPDusNo46gAIuLArQP5FgrOxgPNDog46maRiViYDNY= X-Received: by 2002:a17:906:19d8:: with SMTP id h24mr22838316ejd.166.1580776851956; Mon, 03 Feb 2020 16:40:51 -0800 (PST) MIME-Version: 1.0 References: <1579763945-10478-1-git-send-email-smasetty@codeaurora.org> <1579763945-10478-2-git-send-email-smasetty@codeaurora.org> In-Reply-To: From: Rob Clark Date: Mon, 3 Feb 2020 16:40:40 -0800 Message-ID: Subject: Re: [Freedreno] [PATCH v2 2/3] drm: msm: a6xx: Add support for A618 To: John Stultz X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amit Pundir , linux-arm-msm , Sharat Masetty , lkml , Bjorn Andersson , dri-devel@freedesktop.org, freedreno Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 3, 2020 at 4:21 PM John Stultz wrote: > > On Wed, Jan 22, 2020 at 11:19 PM Sharat Masetty wrote: > > > > This patch adds support for enabling Graphics Bus Interface(GBIF) > > used in multiple A6xx series chipets. Also makes changes to the > > PDC/RSC sequencing specifically required for A618. This is needed > > for proper interfacing with RPMH. > > > > Signed-off-by: Sharat Masetty > > --- > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > > index dc8ec2c..2ac9a51 100644 > > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > > @@ -378,6 +378,18 @@ static int a6xx_hw_init(struct msm_gpu *gpu) > > struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu); > > int ret; > > > > + /* > > + * During a previous slumber, GBIF halt is asserted to ensure > > + * no further transaction can go through GPU before GPU > > + * headswitch is turned off. > > + * > > + * This halt is deasserted once headswitch goes off but > > + * incase headswitch doesn't goes off clear GBIF halt > > + * here to ensure GPU wake-up doesn't fail because of > > + * halted GPU transactions. > > + */ > > + gpu_write(gpu, REG_A6XX_GBIF_HALT, 0x0); > > + > > /* Make sure the GMU keeps the GPU on while we set it up */ > > a6xx_gmu_set_oob(&a6xx_gpu->gmu, GMU_OOB_GPU_SET); > > > > So I already brought this up on #freedreno but figured I'd follow up > on the list. > > With linus/master, I'm seeing hard crashes (into usb crash mode) with > the db845c, which I isolated down to this patch, and then to the chunk > above. (repeating my speculation from #freedreno for benefit of those not on IRC) I'm suspecting, that like the registers to take the GPU out of secure mode, this register is being blocked on LA devices (like db845c), which is why we didn't see this on cheza. Maybe we can make this write conditional on whether we have a zap shader? BR, -R > Dropping the gpu_write line above gets things booting again for me. > > Let me know if there are any follow on patches I can help validate. > > thanks > -john > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel