From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E23BEC5DF63 for ; Wed, 6 Nov 2019 16:29:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F0182067B for ; Wed, 6 Nov 2019 16:29:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MzMKRFbA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727312AbfKFQ37 (ORCPT ); Wed, 6 Nov 2019 11:29:59 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:35684 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727285AbfKFQ37 (ORCPT ); Wed, 6 Nov 2019 11:29:59 -0500 Received: by mail-ed1-f65.google.com with SMTP id r16so5108806edq.2; Wed, 06 Nov 2019 08:29:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZhOsGIzKwcmxV2i84iILMrkYIWM1itj56Bt1iGZX5zw=; b=MzMKRFbA10485jRuvz3tQ8DotJq2PCUsghpbhte/Dk3wiY5LOKVP8lLRnN4m5XzIp8 QSZ9gq/8jxUyRt9w8OTuPnkZbt+0ljMNlwM4C4eqgN+a/fzZ7/XFNzw07DZfMtOP4rIN NMEWnluBhCErVvZc9nS0hJgIWDXrj00FZ7mVGZbIoXiCykoQgemNiJNBse2nr6i1Hmz4 6/k3YLY6fA/GX44TB0cuRoilpgTPtvWVLJIzTpd7woqc3MyZj97/L8Fpv0VKcz3VwNgj bLJNctQizj9a7s53SHWDp6+3SyrC52ukl9X848YIrNjxc+QP001fR6fPEDq05sRScI5i XDOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZhOsGIzKwcmxV2i84iILMrkYIWM1itj56Bt1iGZX5zw=; b=BGHZGdI3QFfKS0B/kJGmhJwGwm0XXOhmd7SvJZbLlrTUKCs4B9MyO0PVpv9mXFK3fm l2/x33Iku07IcHQzv7LGBpX6VB6l2g+xi0XgtCPO4WETPzUcgdZPR5BPwznOu2Fgwqrc M/A2BZw+h5UBVPBV8hE79vENR4PxRUZjSC4hPHw58O9c7dTwHMwskZ4pNd3SkvKzJOWz rdVYH9Lrz+iYegMWI3vUNxolHxe4btHlWYjHiPzzZHH96EoSC0ep50xSg/YQ9sCwUU/q emVK2mPrqqS79NTfesLoqhMlxoyxM4ZIslmKf6wGXiXF/rX6Vh9gkPeq6rNyKS4K0Wp1 q3Bg== X-Gm-Message-State: APjAAAUsQZx/AjdfRb8xo3qLtf6rOs/3RAJxbdKFxptLiO9BKiKoonLC uR8I1mWXu3sfi/Ge5NgOzmrsGbe8N9e5LmLXBqM= X-Google-Smtp-Source: APXvYqw5qpUIPzBJKpJK5MaBBx+BRYa25bDNiZ8H29i7NfGOsBmfuP4o+ssZcJrSFjkMMP3trAu4GRpadedH4teLkVA= X-Received: by 2002:a50:a697:: with SMTP id e23mr3704006edc.264.1573057796426; Wed, 06 Nov 2019 08:29:56 -0800 (PST) MIME-Version: 1.0 References: <20191105000129.GA6536@onstation.org> <20191105100804.GA9492@onstation.org> <20191106091335.GA16729@onstation.org> In-Reply-To: <20191106091335.GA16729@onstation.org> From: Rob Clark Date: Wed, 6 Nov 2019 08:29:45 -0800 Message-ID: Subject: Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes To: Brian Masney Cc: Rob Clark , freedreno , Sean Paul , Linux Kernel Mailing List , dri-devel , linux-arm-msm Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Nov 6, 2019 at 1:13 AM Brian Masney wrote: > > On Tue, Nov 05, 2019 at 08:23:27AM -0800, Rob Clark wrote: > > On Tue, Nov 5, 2019 at 2:08 AM Brian Masney wrote: > > > The 'pp done time out' errors go away if I revert the following three > > > commits: > > > > > > cd6d923167b1 ("drm/msm/dpu: async commit support") > > > d934a712c5e6 ("drm/msm: add atomic traces") > > > 2d99ced787e3 ("drm/msm: async commit support") > > > > > > I reverted the first one to fix a compiler error, and the second one so > > > that the last patch can be reverted without any merge conflicts. > > > > > > I see that crtc_flush() calls mdp5_ctl_commit(). I tried to use > > > crtc_flush_all() in mdp5_flush_commit() and the contents of the frame > > > buffer dance around the screen like its out of sync. I renamed > > > crtc_flush_all() to mdp5_crtc_flush_all() and removed the static > > > declaration. Here's the relevant part of what I tried: > > > > > > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > > > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > > > @@ -171,7 +171,15 @@ static void mdp5_prepare_commit(struct msm_kms *kms, struct drm_atomic_state *st > > > > > > static void mdp5_flush_commit(struct msm_kms *kms, unsigned crtc_mask) > > > { > > > - /* TODO */ > > > + struct mdp5_kms *mdp5_kms = to_mdp5_kms(to_mdp_kms(kms)); > > > + struct drm_crtc *crtc; > > > + > > > + for_each_crtc_mask(mdp5_kms->dev, crtc, crtc_mask) { > > > + if (!crtc->state->active) > > > + continue; > > > + > > > + mdp5_crtc_flush_all(crtc); > > > + } > > > } > > > > > > Any tips would be appreciated. > > > > > > I think this is along the lines of what we need to enable async commit > > for mdp5 (but also removing the flush from the atomic-commit path).. > > the principle behind the async commit is to do all the atomic state > > commit normally, but defer writing the flush bits. This way, if you > > get another async update before the next vblank, you just apply it > > immediately instead of waiting for vblank. > > > > But I guess you are on a command mode panel, if I remember? Which is > > a case I didn't have a way to test. And I'm not entirely about how > > kms_funcs->vsync_time() should be implemented for cmd mode panels. > > Yes, this is a command-mode panel and there's no hardware frame counter > available. The key to getting the display working on this phone was this > patch: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2bab52af6fe68c43b327a57e5ce5fc10eefdfadf > > > That all said, I think we should first fix what is broken, before > > worrying about extending async commit support to mdp5.. which > > shouldn't hit the async==true path, due to not implementing > > kms_funcs->vsync_time(). > > > > What I think is going on is that, in the cmd mode case, > > mdp5_wait_flush() (indirectly) calls mdp5_crtc_wait_for_pp_done(), > > which waits for a pp-done irq regardless of whether there is a flush > > in progress. Since there is no flush pending, the irq never comes. > > But the expectation is that kms_funcs->wait_flush() returns > > immediately if there is nothing to wait for. > > I don't think that's happening in this case. I added some pr_info() > statements to request_pp_done_pending() and mdp5_crtc_pp_done_irq(). > Here's the first two sets of messages that appear in dmesg: > > [ 14.018907] msm fd900000.mdss: pp done time out, lm=0 > [ 14.018993] request_pp_done_pending: HERE > [ 14.074208] mdp5_crtc_pp_done_irq: HERE > [ 14.074368] Console: switching to colour frame buffer device 135x120 > [ 14.138938] msm fd900000.mdss: pp done time out, lm=0 > [ 14.139021] request_pp_done_pending: HERE > [ 14.158097] mdp5_crtc_pp_done_irq: HERE > > The messages go on like this with the same pattern. > > I tried two different changes: > > 1) I moved the request_pp_done_pending() and corresponding if statement > from mdp5_crtc_atomic_flush() and into mdp5_crtc_atomic_begin(). > > 2) I increased the timeout in wait_for_completion_timeout() by several > increments; all the way to 5 seconds. increasing the timeout won't help, because the pp-done irq has already come at the point where we wait for it.. maybe the easy thing is just add mdp5_crtc->needs_pp, set to true before requesting, and false when we get the irq.. and then mdp5_crtc_wait_for_pp_done() just returns if needs_pp==false.. BR, -R > I haven't dug into the new code anymore. > > Brian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: drm/msm: 'pp done time out' errors after async commit changes Date: Wed, 6 Nov 2019 08:29:45 -0800 Message-ID: References: <20191105000129.GA6536@onstation.org> <20191105100804.GA9492@onstation.org> <20191106091335.GA16729@onstation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191106091335.GA16729-1iNe0GrtECGEi8DpZVb4nw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Brian Masney Cc: Rob Clark , freedreno , Linux Kernel Mailing List , dri-devel , linux-arm-msm , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgNiwgMjAxOSBhdCAxOjEzIEFNIEJyaWFuIE1hc25leSA8bWFzbmV5YkBvbnN0 YXRpb24ub3JnPiB3cm90ZToKPgo+IE9uIFR1ZSwgTm92IDA1LCAyMDE5IGF0IDA4OjIzOjI3QU0g LTA4MDAsIFJvYiBDbGFyayB3cm90ZToKPiA+IE9uIFR1ZSwgTm92IDUsIDIwMTkgYXQgMjowOCBB TSBCcmlhbiBNYXNuZXkgPG1hc25leWJAb25zdGF0aW9uLm9yZz4gd3JvdGU6Cj4gPiA+IFRoZSAn cHAgZG9uZSB0aW1lIG91dCcgZXJyb3JzIGdvIGF3YXkgaWYgSSByZXZlcnQgdGhlIGZvbGxvd2lu ZyB0aHJlZQo+ID4gPiBjb21taXRzOgo+ID4gPgo+ID4gPiBjZDZkOTIzMTY3YjEgKCJkcm0vbXNt L2RwdTogYXN5bmMgY29tbWl0IHN1cHBvcnQiKQo+ID4gPiBkOTM0YTcxMmM1ZTYgKCJkcm0vbXNt OiBhZGQgYXRvbWljIHRyYWNlcyIpCj4gPiA+IDJkOTljZWQ3ODdlMyAoImRybS9tc206IGFzeW5j IGNvbW1pdCBzdXBwb3J0IikKPiA+ID4KPiA+ID4gSSByZXZlcnRlZCB0aGUgZmlyc3Qgb25lIHRv IGZpeCBhIGNvbXBpbGVyIGVycm9yLCBhbmQgdGhlIHNlY29uZCBvbmUgc28KPiA+ID4gdGhhdCB0 aGUgbGFzdCBwYXRjaCBjYW4gYmUgcmV2ZXJ0ZWQgd2l0aG91dCBhbnkgbWVyZ2UgY29uZmxpY3Rz Lgo+ID4gPgo+ID4gPiBJIHNlZSB0aGF0IGNydGNfZmx1c2goKSBjYWxscyBtZHA1X2N0bF9jb21t aXQoKS4gSSB0cmllZCB0byB1c2UKPiA+ID4gY3J0Y19mbHVzaF9hbGwoKSBpbiBtZHA1X2ZsdXNo X2NvbW1pdCgpIGFuZCB0aGUgY29udGVudHMgb2YgdGhlIGZyYW1lCj4gPiA+IGJ1ZmZlciBkYW5j ZSBhcm91bmQgdGhlIHNjcmVlbiBsaWtlIGl0cyBvdXQgb2Ygc3luYy4gSSByZW5hbWVkCj4gPiA+ IGNydGNfZmx1c2hfYWxsKCkgdG8gbWRwNV9jcnRjX2ZsdXNoX2FsbCgpIGFuZCByZW1vdmVkIHRo ZSBzdGF0aWMKPiA+ID4gZGVjbGFyYXRpb24uIEhlcmUncyB0aGUgcmVsZXZhbnQgcGFydCBvZiB3 aGF0IEkgdHJpZWQ6Cj4gPiA+Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9t ZHA1L21kcDVfa21zLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL21kcDUv bWRwNV9rbXMuYwo+ID4gPiBAQCAtMTcxLDcgKzE3MSwxNSBAQCBzdGF0aWMgdm9pZCBtZHA1X3By ZXBhcmVfY29tbWl0KHN0cnVjdCBtc21fa21zICprbXMsIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRl ICpzdAo+ID4gPgo+ID4gPiAgc3RhdGljIHZvaWQgbWRwNV9mbHVzaF9jb21taXQoc3RydWN0IG1z bV9rbXMgKmttcywgdW5zaWduZWQgY3J0Y19tYXNrKQo+ID4gPiAgewo+ID4gPiAtICAgICAgIC8q IFRPRE8gKi8KPiA+ID4gKyAgICAgICBzdHJ1Y3QgbWRwNV9rbXMgKm1kcDVfa21zID0gdG9fbWRw NV9rbXModG9fbWRwX2ttcyhrbXMpKTsKPiA+ID4gKyAgICAgICBzdHJ1Y3QgZHJtX2NydGMgKmNy dGM7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICBmb3JfZWFjaF9jcnRjX21hc2sobWRwNV9rbXMtPmRl diwgY3J0YywgY3J0Y19tYXNrKSB7Cj4gPiA+ICsgICAgICAgICAgICAgICBpZiAoIWNydGMtPnN0 YXRlLT5hY3RpdmUpCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+ID4g PiArCj4gPiA+ICsgICAgICAgICAgICAgICBtZHA1X2NydGNfZmx1c2hfYWxsKGNydGMpOwo+ID4g PiArICAgICAgIH0KPiA+ID4gIH0KPiA+ID4KPiA+ID4gQW55IHRpcHMgd291bGQgYmUgYXBwcmVj aWF0ZWQuCj4gPgo+ID4KPiA+IEkgdGhpbmsgdGhpcyBpcyBhbG9uZyB0aGUgbGluZXMgb2Ygd2hh dCB3ZSBuZWVkIHRvIGVuYWJsZSBhc3luYyBjb21taXQKPiA+IGZvciBtZHA1IChidXQgYWxzbyBy ZW1vdmluZyB0aGUgZmx1c2ggZnJvbSB0aGUgYXRvbWljLWNvbW1pdCBwYXRoKS4uCj4gPiB0aGUg cHJpbmNpcGxlIGJlaGluZCB0aGUgYXN5bmMgY29tbWl0IGlzIHRvIGRvIGFsbCB0aGUgYXRvbWlj IHN0YXRlCj4gPiBjb21taXQgbm9ybWFsbHksIGJ1dCBkZWZlciB3cml0aW5nIHRoZSBmbHVzaCBi aXRzLiAgVGhpcyB3YXksIGlmIHlvdQo+ID4gZ2V0IGFub3RoZXIgYXN5bmMgdXBkYXRlIGJlZm9y ZSB0aGUgbmV4dCB2YmxhbmssIHlvdSBqdXN0IGFwcGx5IGl0Cj4gPiBpbW1lZGlhdGVseSBpbnN0 ZWFkIG9mIHdhaXRpbmcgZm9yIHZibGFuay4KPiA+Cj4gPiBCdXQgSSBndWVzcyB5b3UgYXJlIG9u IGEgY29tbWFuZCBtb2RlIHBhbmVsLCBpZiBJIHJlbWVtYmVyPyAgV2hpY2ggaXMKPiA+IGEgY2Fz ZSBJIGRpZG4ndCBoYXZlIGEgd2F5IHRvIHRlc3QuICBBbmQgSSdtIG5vdCBlbnRpcmVseSBhYm91 dCBob3cKPiA+IGttc19mdW5jcy0+dnN5bmNfdGltZSgpIHNob3VsZCBiZSBpbXBsZW1lbnRlZCBm b3IgY21kIG1vZGUgcGFuZWxzLgo+Cj4gWWVzLCB0aGlzIGlzIGEgY29tbWFuZC1tb2RlIHBhbmVs IGFuZCB0aGVyZSdzIG5vIGhhcmR3YXJlIGZyYW1lIGNvdW50ZXIKPiBhdmFpbGFibGUuIFRoZSBr ZXkgdG8gZ2V0dGluZyB0aGUgZGlzcGxheSB3b3JraW5nIG9uIHRoaXMgcGhvbmUgd2FzIHRoaXMK PiBwYXRjaDoKPiBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dp dC90b3J2YWxkcy9saW51eC5naXQvY29tbWl0Lz9pZD0yYmFiNTJhZjZmZTY4YzQzYjMyN2E1N2U1 Y2U1ZmMxMGVlZmRmYWRmCj4KPiA+IFRoYXQgYWxsIHNhaWQsIEkgdGhpbmsgd2Ugc2hvdWxkIGZp cnN0IGZpeCB3aGF0IGlzIGJyb2tlbiwgYmVmb3JlCj4gPiB3b3JyeWluZyBhYm91dCBleHRlbmRp bmcgYXN5bmMgY29tbWl0IHN1cHBvcnQgdG8gbWRwNS4uIHdoaWNoCj4gPiBzaG91bGRuJ3QgaGl0 IHRoZSBhc3luYz09dHJ1ZSBwYXRoLCBkdWUgdG8gbm90IGltcGxlbWVudGluZwo+ID4ga21zX2Z1 bmNzLT52c3luY190aW1lKCkuCj4gPgo+ID4gV2hhdCBJIHRoaW5rIGlzIGdvaW5nIG9uIGlzIHRo YXQsIGluIHRoZSBjbWQgbW9kZSBjYXNlLAo+ID4gbWRwNV93YWl0X2ZsdXNoKCkgKGluZGlyZWN0 bHkpIGNhbGxzIG1kcDVfY3J0Y193YWl0X2Zvcl9wcF9kb25lKCksCj4gPiB3aGljaCB3YWl0cyBm b3IgYSBwcC1kb25lIGlycSByZWdhcmRsZXNzIG9mIHdoZXRoZXIgdGhlcmUgaXMgYSBmbHVzaAo+ ID4gaW4gcHJvZ3Jlc3MuICBTaW5jZSB0aGVyZSBpcyBubyBmbHVzaCBwZW5kaW5nLCB0aGUgaXJx IG5ldmVyIGNvbWVzLgo+ID4gQnV0IHRoZSBleHBlY3RhdGlvbiBpcyB0aGF0IGttc19mdW5jcy0+ d2FpdF9mbHVzaCgpIHJldHVybnMKPiA+IGltbWVkaWF0ZWx5IGlmIHRoZXJlIGlzIG5vdGhpbmcg dG8gd2FpdCBmb3IuCj4KPiBJIGRvbid0IHRoaW5rIHRoYXQncyBoYXBwZW5pbmcgaW4gdGhpcyBj YXNlLiBJIGFkZGVkIHNvbWUgcHJfaW5mbygpCj4gc3RhdGVtZW50cyB0byByZXF1ZXN0X3BwX2Rv bmVfcGVuZGluZygpIGFuZCBtZHA1X2NydGNfcHBfZG9uZV9pcnEoKS4KPiBIZXJlJ3MgdGhlIGZp cnN0IHR3byBzZXRzIG9mIG1lc3NhZ2VzIHRoYXQgYXBwZWFyIGluIGRtZXNnOgo+Cj4gWyAgIDE0 LjAxODkwN10gbXNtIGZkOTAwMDAwLm1kc3M6IHBwIGRvbmUgdGltZSBvdXQsIGxtPTAKPiBbICAg MTQuMDE4OTkzXSByZXF1ZXN0X3BwX2RvbmVfcGVuZGluZzogSEVSRQo+IFsgICAxNC4wNzQyMDhd IG1kcDVfY3J0Y19wcF9kb25lX2lycTogSEVSRQo+IFsgICAxNC4wNzQzNjhdIENvbnNvbGU6IHN3 aXRjaGluZyB0byBjb2xvdXIgZnJhbWUgYnVmZmVyIGRldmljZSAxMzV4MTIwCj4gWyAgIDE0LjEz ODkzOF0gbXNtIGZkOTAwMDAwLm1kc3M6IHBwIGRvbmUgdGltZSBvdXQsIGxtPTAKPiBbICAgMTQu MTM5MDIxXSByZXF1ZXN0X3BwX2RvbmVfcGVuZGluZzogSEVSRQo+IFsgICAxNC4xNTgwOTddIG1k cDVfY3J0Y19wcF9kb25lX2lycTogSEVSRQo+Cj4gVGhlIG1lc3NhZ2VzIGdvIG9uIGxpa2UgdGhp cyB3aXRoIHRoZSBzYW1lIHBhdHRlcm4uCj4KPiBJIHRyaWVkIHR3byBkaWZmZXJlbnQgY2hhbmdl czoKPgo+IDEpIEkgbW92ZWQgdGhlIHJlcXVlc3RfcHBfZG9uZV9wZW5kaW5nKCkgYW5kIGNvcnJl c3BvbmRpbmcgaWYgc3RhdGVtZW50Cj4gICAgZnJvbSBtZHA1X2NydGNfYXRvbWljX2ZsdXNoKCkg YW5kIGludG8gbWRwNV9jcnRjX2F0b21pY19iZWdpbigpLgo+Cj4gMikgSSBpbmNyZWFzZWQgdGhl IHRpbWVvdXQgaW4gd2FpdF9mb3JfY29tcGxldGlvbl90aW1lb3V0KCkgYnkgc2V2ZXJhbAo+ICAg IGluY3JlbWVudHM7IGFsbCB0aGUgd2F5IHRvIDUgc2Vjb25kcy4KCmluY3JlYXNpbmcgdGhlIHRp bWVvdXQgd29uJ3QgaGVscCwgYmVjYXVzZSB0aGUgcHAtZG9uZSBpcnEgaGFzIGFscmVhZHkKY29t ZSBhdCB0aGUgcG9pbnQgd2hlcmUgd2Ugd2FpdCBmb3IgaXQuLgoKbWF5YmUgdGhlIGVhc3kgdGhp bmcgaXMganVzdCBhZGQgbWRwNV9jcnRjLT5uZWVkc19wcCwgc2V0IHRvIHRydWUKYmVmb3JlIHJl cXVlc3RpbmcsIGFuZCBmYWxzZSB3aGVuIHdlIGdldCB0aGUgaXJxLi4gYW5kIHRoZW4KbWRwNV9j cnRjX3dhaXRfZm9yX3BwX2RvbmUoKSBqdXN0IHJldHVybnMgaWYgbmVlZHNfcHA9PWZhbHNlLi4K CkJSLAotUgoKPiBJIGhhdmVuJ3QgZHVnIGludG8gdGhlIG5ldyBjb2RlIGFueW1vcmUuCj4KPiBC cmlhbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVl ZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF9EC5DF64 for ; Wed, 6 Nov 2019 16:30:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49BA22067B for ; Wed, 6 Nov 2019 16:30:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49BA22067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 470516E02E; Wed, 6 Nov 2019 16:29:59 +0000 (UTC) Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02E376E02E; Wed, 6 Nov 2019 16:29:57 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id c4so19902205edl.0; Wed, 06 Nov 2019 08:29:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZhOsGIzKwcmxV2i84iILMrkYIWM1itj56Bt1iGZX5zw=; b=nvvtqGeRcRgiu77T435cnD2lMnWFLqLWl6E3fKovQrt5VFql3jBEuOBQ1jabqhWT2q CLuv/UBPvbNepx0cgTWeraJC06on/nsWf5Ongi3SohR/4peHhJh7EDyrSsDIMytZ/CbH FkRuNvWKhy+YTr2BzDKsSh8+TeHNkKzVfYbcbBRceUjXS2djddQeSwW+7TFqYRmOp4C6 BEfixDBwP4mDH5McMo5AeJwP473/DUh5SJowxkJyh8/lsjbWbLq2tcQ0VZmimC2y4wYm +u8iLEj1obyL/1Hu1ljVpsScXEDbPJ/Q8Kuu8L8jKpERx35SeoaJZwk0kgB8vW3kl8Rw OlXA== X-Gm-Message-State: APjAAAXNwYObVhyZmKZfM+B1wuikAiDa8h8CNjIfbG/8Y5Bgt8tfG9gD 61RZoa2n6Rk29qaTPcOaKf5lLpTwsSgArFUApkZGPQ== X-Google-Smtp-Source: APXvYqw5qpUIPzBJKpJK5MaBBx+BRYa25bDNiZ8H29i7NfGOsBmfuP4o+ssZcJrSFjkMMP3trAu4GRpadedH4teLkVA= X-Received: by 2002:a50:a697:: with SMTP id e23mr3704006edc.264.1573057796426; Wed, 06 Nov 2019 08:29:56 -0800 (PST) MIME-Version: 1.0 References: <20191105000129.GA6536@onstation.org> <20191105100804.GA9492@onstation.org> <20191106091335.GA16729@onstation.org> In-Reply-To: <20191106091335.GA16729@onstation.org> From: Rob Clark Date: Wed, 6 Nov 2019 08:29:45 -0800 Message-ID: Subject: Re: [Freedreno] drm/msm: 'pp done time out' errors after async commit changes To: Brian Masney X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZhOsGIzKwcmxV2i84iILMrkYIWM1itj56Bt1iGZX5zw=; b=MzMKRFbA10485jRuvz3tQ8DotJq2PCUsghpbhte/Dk3wiY5LOKVP8lLRnN4m5XzIp8 QSZ9gq/8jxUyRt9w8OTuPnkZbt+0ljMNlwM4C4eqgN+a/fzZ7/XFNzw07DZfMtOP4rIN NMEWnluBhCErVvZc9nS0hJgIWDXrj00FZ7mVGZbIoXiCykoQgemNiJNBse2nr6i1Hmz4 6/k3YLY6fA/GX44TB0cuRoilpgTPtvWVLJIzTpd7woqc3MyZj97/L8Fpv0VKcz3VwNgj bLJNctQizj9a7s53SHWDp6+3SyrC52ukl9X848YIrNjxc+QP001fR6fPEDq05sRScI5i XDOw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , freedreno , Linux Kernel Mailing List , dri-devel , linux-arm-msm , Sean Paul Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191106162945.oiZGlxPDgqp84zDjeP16RUeU2ujcw047OqKtU2boawE@z> T24gV2VkLCBOb3YgNiwgMjAxOSBhdCAxOjEzIEFNIEJyaWFuIE1hc25leSA8bWFzbmV5YkBvbnN0 YXRpb24ub3JnPiB3cm90ZToKPgo+IE9uIFR1ZSwgTm92IDA1LCAyMDE5IGF0IDA4OjIzOjI3QU0g LTA4MDAsIFJvYiBDbGFyayB3cm90ZToKPiA+IE9uIFR1ZSwgTm92IDUsIDIwMTkgYXQgMjowOCBB TSBCcmlhbiBNYXNuZXkgPG1hc25leWJAb25zdGF0aW9uLm9yZz4gd3JvdGU6Cj4gPiA+IFRoZSAn cHAgZG9uZSB0aW1lIG91dCcgZXJyb3JzIGdvIGF3YXkgaWYgSSByZXZlcnQgdGhlIGZvbGxvd2lu ZyB0aHJlZQo+ID4gPiBjb21taXRzOgo+ID4gPgo+ID4gPiBjZDZkOTIzMTY3YjEgKCJkcm0vbXNt L2RwdTogYXN5bmMgY29tbWl0IHN1cHBvcnQiKQo+ID4gPiBkOTM0YTcxMmM1ZTYgKCJkcm0vbXNt OiBhZGQgYXRvbWljIHRyYWNlcyIpCj4gPiA+IDJkOTljZWQ3ODdlMyAoImRybS9tc206IGFzeW5j IGNvbW1pdCBzdXBwb3J0IikKPiA+ID4KPiA+ID4gSSByZXZlcnRlZCB0aGUgZmlyc3Qgb25lIHRv IGZpeCBhIGNvbXBpbGVyIGVycm9yLCBhbmQgdGhlIHNlY29uZCBvbmUgc28KPiA+ID4gdGhhdCB0 aGUgbGFzdCBwYXRjaCBjYW4gYmUgcmV2ZXJ0ZWQgd2l0aG91dCBhbnkgbWVyZ2UgY29uZmxpY3Rz Lgo+ID4gPgo+ID4gPiBJIHNlZSB0aGF0IGNydGNfZmx1c2goKSBjYWxscyBtZHA1X2N0bF9jb21t aXQoKS4gSSB0cmllZCB0byB1c2UKPiA+ID4gY3J0Y19mbHVzaF9hbGwoKSBpbiBtZHA1X2ZsdXNo X2NvbW1pdCgpIGFuZCB0aGUgY29udGVudHMgb2YgdGhlIGZyYW1lCj4gPiA+IGJ1ZmZlciBkYW5j ZSBhcm91bmQgdGhlIHNjcmVlbiBsaWtlIGl0cyBvdXQgb2Ygc3luYy4gSSByZW5hbWVkCj4gPiA+ IGNydGNfZmx1c2hfYWxsKCkgdG8gbWRwNV9jcnRjX2ZsdXNoX2FsbCgpIGFuZCByZW1vdmVkIHRo ZSBzdGF0aWMKPiA+ID4gZGVjbGFyYXRpb24uIEhlcmUncyB0aGUgcmVsZXZhbnQgcGFydCBvZiB3 aGF0IEkgdHJpZWQ6Cj4gPiA+Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZGlzcC9t ZHA1L21kcDVfa21zLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9kaXNwL21kcDUv bWRwNV9rbXMuYwo+ID4gPiBAQCAtMTcxLDcgKzE3MSwxNSBAQCBzdGF0aWMgdm9pZCBtZHA1X3By ZXBhcmVfY29tbWl0KHN0cnVjdCBtc21fa21zICprbXMsIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRl ICpzdAo+ID4gPgo+ID4gPiAgc3RhdGljIHZvaWQgbWRwNV9mbHVzaF9jb21taXQoc3RydWN0IG1z bV9rbXMgKmttcywgdW5zaWduZWQgY3J0Y19tYXNrKQo+ID4gPiAgewo+ID4gPiAtICAgICAgIC8q IFRPRE8gKi8KPiA+ID4gKyAgICAgICBzdHJ1Y3QgbWRwNV9rbXMgKm1kcDVfa21zID0gdG9fbWRw NV9rbXModG9fbWRwX2ttcyhrbXMpKTsKPiA+ID4gKyAgICAgICBzdHJ1Y3QgZHJtX2NydGMgKmNy dGM7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICBmb3JfZWFjaF9jcnRjX21hc2sobWRwNV9rbXMtPmRl diwgY3J0YywgY3J0Y19tYXNrKSB7Cj4gPiA+ICsgICAgICAgICAgICAgICBpZiAoIWNydGMtPnN0 YXRlLT5hY3RpdmUpCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+ID4g PiArCj4gPiA+ICsgICAgICAgICAgICAgICBtZHA1X2NydGNfZmx1c2hfYWxsKGNydGMpOwo+ID4g PiArICAgICAgIH0KPiA+ID4gIH0KPiA+ID4KPiA+ID4gQW55IHRpcHMgd291bGQgYmUgYXBwcmVj aWF0ZWQuCj4gPgo+ID4KPiA+IEkgdGhpbmsgdGhpcyBpcyBhbG9uZyB0aGUgbGluZXMgb2Ygd2hh dCB3ZSBuZWVkIHRvIGVuYWJsZSBhc3luYyBjb21taXQKPiA+IGZvciBtZHA1IChidXQgYWxzbyBy ZW1vdmluZyB0aGUgZmx1c2ggZnJvbSB0aGUgYXRvbWljLWNvbW1pdCBwYXRoKS4uCj4gPiB0aGUg cHJpbmNpcGxlIGJlaGluZCB0aGUgYXN5bmMgY29tbWl0IGlzIHRvIGRvIGFsbCB0aGUgYXRvbWlj IHN0YXRlCj4gPiBjb21taXQgbm9ybWFsbHksIGJ1dCBkZWZlciB3cml0aW5nIHRoZSBmbHVzaCBi aXRzLiAgVGhpcyB3YXksIGlmIHlvdQo+ID4gZ2V0IGFub3RoZXIgYXN5bmMgdXBkYXRlIGJlZm9y ZSB0aGUgbmV4dCB2YmxhbmssIHlvdSBqdXN0IGFwcGx5IGl0Cj4gPiBpbW1lZGlhdGVseSBpbnN0 ZWFkIG9mIHdhaXRpbmcgZm9yIHZibGFuay4KPiA+Cj4gPiBCdXQgSSBndWVzcyB5b3UgYXJlIG9u IGEgY29tbWFuZCBtb2RlIHBhbmVsLCBpZiBJIHJlbWVtYmVyPyAgV2hpY2ggaXMKPiA+IGEgY2Fz ZSBJIGRpZG4ndCBoYXZlIGEgd2F5IHRvIHRlc3QuICBBbmQgSSdtIG5vdCBlbnRpcmVseSBhYm91 dCBob3cKPiA+IGttc19mdW5jcy0+dnN5bmNfdGltZSgpIHNob3VsZCBiZSBpbXBsZW1lbnRlZCBm b3IgY21kIG1vZGUgcGFuZWxzLgo+Cj4gWWVzLCB0aGlzIGlzIGEgY29tbWFuZC1tb2RlIHBhbmVs IGFuZCB0aGVyZSdzIG5vIGhhcmR3YXJlIGZyYW1lIGNvdW50ZXIKPiBhdmFpbGFibGUuIFRoZSBr ZXkgdG8gZ2V0dGluZyB0aGUgZGlzcGxheSB3b3JraW5nIG9uIHRoaXMgcGhvbmUgd2FzIHRoaXMK PiBwYXRjaDoKPiBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dp dC90b3J2YWxkcy9saW51eC5naXQvY29tbWl0Lz9pZD0yYmFiNTJhZjZmZTY4YzQzYjMyN2E1N2U1 Y2U1ZmMxMGVlZmRmYWRmCj4KPiA+IFRoYXQgYWxsIHNhaWQsIEkgdGhpbmsgd2Ugc2hvdWxkIGZp cnN0IGZpeCB3aGF0IGlzIGJyb2tlbiwgYmVmb3JlCj4gPiB3b3JyeWluZyBhYm91dCBleHRlbmRp bmcgYXN5bmMgY29tbWl0IHN1cHBvcnQgdG8gbWRwNS4uIHdoaWNoCj4gPiBzaG91bGRuJ3QgaGl0 IHRoZSBhc3luYz09dHJ1ZSBwYXRoLCBkdWUgdG8gbm90IGltcGxlbWVudGluZwo+ID4ga21zX2Z1 bmNzLT52c3luY190aW1lKCkuCj4gPgo+ID4gV2hhdCBJIHRoaW5rIGlzIGdvaW5nIG9uIGlzIHRo YXQsIGluIHRoZSBjbWQgbW9kZSBjYXNlLAo+ID4gbWRwNV93YWl0X2ZsdXNoKCkgKGluZGlyZWN0 bHkpIGNhbGxzIG1kcDVfY3J0Y193YWl0X2Zvcl9wcF9kb25lKCksCj4gPiB3aGljaCB3YWl0cyBm b3IgYSBwcC1kb25lIGlycSByZWdhcmRsZXNzIG9mIHdoZXRoZXIgdGhlcmUgaXMgYSBmbHVzaAo+ ID4gaW4gcHJvZ3Jlc3MuICBTaW5jZSB0aGVyZSBpcyBubyBmbHVzaCBwZW5kaW5nLCB0aGUgaXJx IG5ldmVyIGNvbWVzLgo+ID4gQnV0IHRoZSBleHBlY3RhdGlvbiBpcyB0aGF0IGttc19mdW5jcy0+ d2FpdF9mbHVzaCgpIHJldHVybnMKPiA+IGltbWVkaWF0ZWx5IGlmIHRoZXJlIGlzIG5vdGhpbmcg dG8gd2FpdCBmb3IuCj4KPiBJIGRvbid0IHRoaW5rIHRoYXQncyBoYXBwZW5pbmcgaW4gdGhpcyBj YXNlLiBJIGFkZGVkIHNvbWUgcHJfaW5mbygpCj4gc3RhdGVtZW50cyB0byByZXF1ZXN0X3BwX2Rv bmVfcGVuZGluZygpIGFuZCBtZHA1X2NydGNfcHBfZG9uZV9pcnEoKS4KPiBIZXJlJ3MgdGhlIGZp cnN0IHR3byBzZXRzIG9mIG1lc3NhZ2VzIHRoYXQgYXBwZWFyIGluIGRtZXNnOgo+Cj4gWyAgIDE0 LjAxODkwN10gbXNtIGZkOTAwMDAwLm1kc3M6IHBwIGRvbmUgdGltZSBvdXQsIGxtPTAKPiBbICAg MTQuMDE4OTkzXSByZXF1ZXN0X3BwX2RvbmVfcGVuZGluZzogSEVSRQo+IFsgICAxNC4wNzQyMDhd IG1kcDVfY3J0Y19wcF9kb25lX2lycTogSEVSRQo+IFsgICAxNC4wNzQzNjhdIENvbnNvbGU6IHN3 aXRjaGluZyB0byBjb2xvdXIgZnJhbWUgYnVmZmVyIGRldmljZSAxMzV4MTIwCj4gWyAgIDE0LjEz ODkzOF0gbXNtIGZkOTAwMDAwLm1kc3M6IHBwIGRvbmUgdGltZSBvdXQsIGxtPTAKPiBbICAgMTQu MTM5MDIxXSByZXF1ZXN0X3BwX2RvbmVfcGVuZGluZzogSEVSRQo+IFsgICAxNC4xNTgwOTddIG1k cDVfY3J0Y19wcF9kb25lX2lycTogSEVSRQo+Cj4gVGhlIG1lc3NhZ2VzIGdvIG9uIGxpa2UgdGhp cyB3aXRoIHRoZSBzYW1lIHBhdHRlcm4uCj4KPiBJIHRyaWVkIHR3byBkaWZmZXJlbnQgY2hhbmdl czoKPgo+IDEpIEkgbW92ZWQgdGhlIHJlcXVlc3RfcHBfZG9uZV9wZW5kaW5nKCkgYW5kIGNvcnJl c3BvbmRpbmcgaWYgc3RhdGVtZW50Cj4gICAgZnJvbSBtZHA1X2NydGNfYXRvbWljX2ZsdXNoKCkg YW5kIGludG8gbWRwNV9jcnRjX2F0b21pY19iZWdpbigpLgo+Cj4gMikgSSBpbmNyZWFzZWQgdGhl IHRpbWVvdXQgaW4gd2FpdF9mb3JfY29tcGxldGlvbl90aW1lb3V0KCkgYnkgc2V2ZXJhbAo+ICAg IGluY3JlbWVudHM7IGFsbCB0aGUgd2F5IHRvIDUgc2Vjb25kcy4KCmluY3JlYXNpbmcgdGhlIHRp bWVvdXQgd29uJ3QgaGVscCwgYmVjYXVzZSB0aGUgcHAtZG9uZSBpcnEgaGFzIGFscmVhZHkKY29t ZSBhdCB0aGUgcG9pbnQgd2hlcmUgd2Ugd2FpdCBmb3IgaXQuLgoKbWF5YmUgdGhlIGVhc3kgdGhp bmcgaXMganVzdCBhZGQgbWRwNV9jcnRjLT5uZWVkc19wcCwgc2V0IHRvIHRydWUKYmVmb3JlIHJl cXVlc3RpbmcsIGFuZCBmYWxzZSB3aGVuIHdlIGdldCB0aGUgaXJxLi4gYW5kIHRoZW4KbWRwNV9j cnRjX3dhaXRfZm9yX3BwX2RvbmUoKSBqdXN0IHJldHVybnMgaWYgbmVlZHNfcHA9PWZhbHNlLi4K CkJSLAotUgoKPiBJIGhhdmVuJ3QgZHVnIGludG8gdGhlIG5ldyBjb2RlIGFueW1vcmUuCj4KPiBC cmlhbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=