From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95988C4161F for ; Tue, 19 Jan 2021 18:29:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E60722AAA for ; Tue, 19 Jan 2021 18:29:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E60722AAA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D7DB989BD5; Tue, 19 Jan 2021 16:35:00 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6756A89BD5; Tue, 19 Jan 2021 16:34:59 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id g10so1977770wrx.1; Tue, 19 Jan 2021 08:34:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K8CPP2LxVCRfQvw6Mvjys75AeJM/eD3BKflYmxoWy0Y=; b=o1yKY9vqL6lFysCAxbW+xr3OKTjSrN23zZNZQGQmNyYbKZLPk8YFBfDeLqPv26DiXr 2VF6UVwFeLFe4FapelSdLdb+NHLIKGOL+xkosdRkeMWtKB0HyGTIJAPIoety7SncPydT 1GcBMv4NY+lCmT1syZQzGopFwsEji7sLL70imchf5o27JB5r7Vc3lFj/23oFPYJxidNo YXRN9Kx877+qX6/hvvUFxhJMxzoVUd2f642bkirLANEreHDMS+T8KzQBHKabs1ghUYiE cB1jpGPPVdIN4XzGNOZpo9rYCEB6EWV+VsplMOrjE6vivFRc0lpSlOIl0hGX8mkWLzxh 9dCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K8CPP2LxVCRfQvw6Mvjys75AeJM/eD3BKflYmxoWy0Y=; b=Vhl5baiOZGNQ3NMpb0vIcof0Egg2ngIIqfa6Cxjanu9KJbB+GLoaTaAxhBIvPdOJzO n3v4C7fAkuZSP3K0HR8ws9tL9ckKR9NrS7rvOlnE/4Bcrl5ZoZj1znQbZgzlzJf9aSmZ gTEVIMho5LSazBcQM9xGA8fStAOWW59gwxdFrp2kxnD4nXlBjhh2pdcslGsxomrQ0A3t LkEcADPiQlXSckVpkMOM+gT6FIV4oIh635+9kMIZGAmrwe2YNJEQObCtK+TWkGFo5m2w 6jpW8IOzSabGKQMJxfdTyhIaAoDzSSzA1CcBY+cld1p7sqzCPns0tlp4ubcsIff2xjsq XDMg== X-Gm-Message-State: AOAM530lLZLz0RM7LlOm9ttiv0/rQR2BMw1GgLjhmvUtsMzA3gEsYN7v 9mgcyQ+7scdNENSSQkwnRsowbtDs+Tv+WLkHakc= X-Google-Smtp-Source: ABdhPJwlH+KuLj1j8ERMqIwHoWH5x4ZSIo4tLJR/GfYt0+5JVb5lagtVPPAe7FqFO7LhiKHxCUkzcDq5sfNgwRNhEFQ= X-Received: by 2002:a5d:688d:: with SMTP id h13mr5464908wru.28.1611074098001; Tue, 19 Jan 2021 08:34:58 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Rob Clark Date: Tue, 19 Jan 2021 08:34:44 -0800 Message-ID: Subject: Re: Reboot crash at msm_atomic_commit_tail To: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sascha Hauer , Jonathan Marek , "open list:DRM DRIVER FOR MSM ADRENO GPU" , DRI mailing list , Bjorn Andersson , Sean Paul Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jan 18, 2021 at 11:00 PM Daniel Vetter wrote: > > On Mon, Jan 18, 2021 at 11:00 PM Fabio Estevam wrote: > > > > On Mon, Jan 18, 2021 at 6:44 PM Fabio Estevam wrote: > > > > > > Adding some more folks in case anyone has any suggestions to fix this > > > reboot hang. > > > > Not sure if this is a valid fix, but the change below makes reboot > > works correctly. > > > > kmscube still works. > > > > --- a/drivers/gpu/drm/msm/msm_atomic.c > > +++ b/drivers/gpu/drm/msm/msm_atomic.c > > @@ -207,8 +207,12 @@ void msm_atomic_commit_tail(struct drm_atomic_state *state) > > struct msm_kms *kms = priv->kms; > > struct drm_crtc *async_crtc = NULL; > > unsigned crtc_mask = get_crtc_mask(state); > > - bool async = kms->funcs->vsync_time && > > - can_do_async(state, &async_crtc); > > + bool async; > > + > > + if (!kms) > > + return; > > That looks a bit like a hack papering over the real issue. > > From your report it sounds like earlier kernels worked, did you > attempt bisecting? Also for regressions put regressions into the > subject, it's the magic work that gets much more attention. the root issue is how are we doing KMS stuff on imx (where drm/msm is only used for gpu).. which I think is this commit: ---------- commit 9d5cbf5fe46e350715389d89d0c350d83289a102 Author: Krishna Manikandan AuthorDate: Mon Jun 1 16:33:22 2020 +0530 Commit: Rob Clark CommitDate: Tue Aug 18 08:09:01 2020 -0700 drm/msm: add shutdown support for display platform_driver Define shutdown callback for display drm driver, so as to disable all the CRTCS when shutdown notification is received by the driver. This change will turn off the timing engine so that no display transactions are requested while mmu translations are getting disabled during reboot sequence. Signed-off-by: Krishna Manikandan Changes in v2: - Remove NULL check from msm_pdev_shutdown (Stephen Boyd) - Change commit text to reflect when this issue was uncovered (Sai Prakash Ranjan) Signed-off-by: Rob Clark ---------- I suppose we should do the drm_atomic_helper_shutdown() conditionally? Or the helper should bail if there is no kms? BR, -R > -Daniel > > > + > > + async = kms->funcs->vsync_time && can_do_async(state, &async_crtc); > > > > trace_msm_atomic_commit_tail_start(async, crtc_mask); > > > > Any comments? > > > > Thanks > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel