From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C72C433F5 for ; Wed, 12 Jan 2022 21:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229604AbiALVTM (ORCPT ); Wed, 12 Jan 2022 16:19:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbiALVTM (ORCPT ); Wed, 12 Jan 2022 16:19:12 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0197C06173F; Wed, 12 Jan 2022 13:19:11 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id r28so6577768wrc.3; Wed, 12 Jan 2022 13:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6TxiOntNhsCrtTXgbXmjcIfphc43hOl3QDBs0NNaLFY=; b=KFiMw3MPBADupNQlBvuHMx9S77BKhdF50zxz77/j9FbgxZiOW10JkOCDEu4tDtTIUZ AF2ne5pOpFtLLh0J/9OVlZ3Xk8elbrON8BeE8eBJFFtdl+rcmCx6FlCLn1TGlLjOGU1U MbEepFp7jfyJPApV+rIYxxpUAJzQ5eydRVetMrqCpxYELcUkPYCWoTUG1/frTgYsvUGJ ZiTlzH1EJEC+Ki3ORSUcCKfj0/d1Le+p8V28PtIAlySvlQOqa+hdOESzqWF4D3jzjQSP 3LTRiZFk53hsfrs+MASoRHQUwhCVAtsh7bisLyz3COXkFx2eHCyN6mzF2beFQqpPV5MI 6hXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6TxiOntNhsCrtTXgbXmjcIfphc43hOl3QDBs0NNaLFY=; b=AhCHq7KkOBj8cb3yqwx2hxb4C5O1Y47uNXu8Q4DJ8YcKxNTl8ScG4l1lfR++qJaOXg jlBI6b5Xz3oVQ4puaQTTJfogXA1Y6WVCWh7jwnds5GgRNPBZtYs1mGa7Q9sMppW5/Ch9 rDsOa/HPI+s4hahrPtCBjEh+s1bifAPKk6CxihkodLWGv+INl3GMtCNPlPTMKUgD49pk NvqJLGc42b0EKnuTPNvBGga+CTGK74I9QQnXzejjvd5D4prVRWYCIgvPvPeZfhOl4EgE yw4uKQwojRebBitb/ozp8DlpL4xAL58fpDbztS6Vm7H94zlBDsvAAJZnjXFYryAYB22A sVmw== X-Gm-Message-State: AOAM533w+L5sRr9qrUpYclC6VRjs/yZv0JrAVVCcaK1iDk8HoZTjay6+ TXdqGR6DyyW1jU5zBgP+UpOgj4osSFVAhPNZieE= X-Google-Smtp-Source: ABdhPJzFEuWp7Wsk8JdHQYZwsj1tBXEicac30GClml/cPixPa0nmwZPRG1lrU1uj5FLFPmz34phbSV+YiJmWRQFzecY= X-Received: by 2002:a5d:6488:: with SMTP id o8mr1369457wri.93.1642022349685; Wed, 12 Jan 2022 13:19:09 -0800 (PST) MIME-Version: 1.0 References: <20220112030115.1.Ibac66e1e0e565313bc28f192e6c94cb508f205eb@changeid> <20220112030115.3.I86c32730e08cba9e5c83f02ec17885124d45fa56@changeid> In-Reply-To: <20220112030115.3.I86c32730e08cba9e5c83f02ec17885124d45fa56@changeid> From: Rob Clark Date: Wed, 12 Jan 2022 13:19:07 -0800 Message-ID: Subject: Re: [PATCH 3/4] drm/msm/adreno: Expose speedbin to userspace To: Akhil P Oommen Cc: freedreno , dri-devel , linux-arm-msm , OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Abhinav Kumar , =?UTF-8?Q?Christian_K=C3=B6nig?= , Daniel Vetter , David Airlie , Jonathan Marek , Jordan Crouse , Sai Prakash Ranjan , Sean Paul , Stephen Boyd , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jan 11, 2022 at 1:31 PM Akhil P Oommen wrote: > > Expose speedbin through MSM_PARAM_CHIP_ID parameter to help userspace > identify the sku. > > Signed-off-by: Akhil P Oommen > --- > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index f33cfa4..e970e6a 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -242,10 +242,11 @@ int adreno_get_param(struct msm_gpu *gpu, uint32_t param, uint64_t *value) > *value = !adreno_is_a650_family(adreno_gpu) ? 0x100000 : 0; > return 0; > case MSM_PARAM_CHIP_ID: > - *value = adreno_gpu->rev.patchid | > - (adreno_gpu->rev.minor << 8) | > - (adreno_gpu->rev.major << 16) | > - (adreno_gpu->rev.core << 24); > + *value = (uint64_t) adreno_gpu->rev.patchid | > + (uint64_t) (adreno_gpu->rev.minor << 8) | > + (uint64_t) (adreno_gpu->rev.major << 16) | > + (uint64_t) (adreno_gpu->rev.core << 24) | > + (((uint64_t) adreno_gpu->rev.sku) << 32); How about this instead, so we are only changing the behavior for new/unreleased devices: *value = adreno_gpu->rev.patchid | (adreno_gpu->rev.minor << 8) | (adreno_gpu->rev.major << 16) | (adreno_gpu->rev.core << 24); if (!adreno_gpu->info->revn) *value |= (((uint64_t) adreno_gpu->rev.sku) << 32); (sorry about the butchered indentation.. somehow gmail has become antagonistic about pasting code) BR, -R > return 0; > case MSM_PARAM_MAX_FREQ: > *value = adreno_gpu->base.fast_rate; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E67A2C433FE for ; Wed, 12 Jan 2022 21:19:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D9E6D10EA17; Wed, 12 Jan 2022 21:19:12 +0000 (UTC) Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 497DF10E8A3; Wed, 12 Jan 2022 21:19:11 +0000 (UTC) Received: by mail-wr1-x42c.google.com with SMTP id q8so6483703wra.12; Wed, 12 Jan 2022 13:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6TxiOntNhsCrtTXgbXmjcIfphc43hOl3QDBs0NNaLFY=; b=KFiMw3MPBADupNQlBvuHMx9S77BKhdF50zxz77/j9FbgxZiOW10JkOCDEu4tDtTIUZ AF2ne5pOpFtLLh0J/9OVlZ3Xk8elbrON8BeE8eBJFFtdl+rcmCx6FlCLn1TGlLjOGU1U MbEepFp7jfyJPApV+rIYxxpUAJzQ5eydRVetMrqCpxYELcUkPYCWoTUG1/frTgYsvUGJ ZiTlzH1EJEC+Ki3ORSUcCKfj0/d1Le+p8V28PtIAlySvlQOqa+hdOESzqWF4D3jzjQSP 3LTRiZFk53hsfrs+MASoRHQUwhCVAtsh7bisLyz3COXkFx2eHCyN6mzF2beFQqpPV5MI 6hXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6TxiOntNhsCrtTXgbXmjcIfphc43hOl3QDBs0NNaLFY=; b=sQMkM6DKv/29MIN3moVMDvVXG3a5F2PW2vmWs0Kq8ZhPnsGgAi1CQKhqZnMlygk6tx 3xrSIqaWKyJtU/7Eszq3MCTc2cifzjKtAELMAOddftUSgAm9ZXkw2LfTnroW7OBqIw4/ RsWOerUb5gNVvnRqGCngvrvx2xsr8sHPF3id2r+8F16mX+Y4vO+Nys7XqQu2YKVlU7mn CPdJeqVchJZK9Tj5ar1wgz9WBjXrtBpmMhb7jDi3A6tbI1wi6S8Pn+ePRJbmhLEtFXrr hYgTDM6Cv57yvRX0JvD7euH2nLyFQINsXnqJ+jwiv8w+ZNgV8jHnszl+Tzber3KVIc7l Kp8g== X-Gm-Message-State: AOAM533pteNqRqF8VnTPepoQJP59duS27Gi2APs4Mbzz2obSB0IdOPG8 iWkdI639Duvfg3/gNsr3LfUP4IGfalyo7G4lFmM= X-Google-Smtp-Source: ABdhPJzFEuWp7Wsk8JdHQYZwsj1tBXEicac30GClml/cPixPa0nmwZPRG1lrU1uj5FLFPmz34phbSV+YiJmWRQFzecY= X-Received: by 2002:a5d:6488:: with SMTP id o8mr1369457wri.93.1642022349685; Wed, 12 Jan 2022 13:19:09 -0800 (PST) MIME-Version: 1.0 References: <20220112030115.1.Ibac66e1e0e565313bc28f192e6c94cb508f205eb@changeid> <20220112030115.3.I86c32730e08cba9e5c83f02ec17885124d45fa56@changeid> In-Reply-To: <20220112030115.3.I86c32730e08cba9e5c83f02ec17885124d45fa56@changeid> From: Rob Clark Date: Wed, 12 Jan 2022 13:19:07 -0800 Message-ID: Subject: Re: [PATCH 3/4] drm/msm/adreno: Expose speedbin to userspace To: Akhil P Oommen Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Sai Prakash Ranjan , Jonathan Marek , David Airlie , linux-arm-msm , Abhinav Kumar , dri-devel , Jordan Crouse , Stephen Boyd , freedreno , =?UTF-8?Q?Christian_K=C3=B6nig?= , Linux Kernel Mailing List Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 11, 2022 at 1:31 PM Akhil P Oommen wrote: > > Expose speedbin through MSM_PARAM_CHIP_ID parameter to help userspace > identify the sku. > > Signed-off-by: Akhil P Oommen > --- > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index f33cfa4..e970e6a 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -242,10 +242,11 @@ int adreno_get_param(struct msm_gpu *gpu, uint32_t param, uint64_t *value) > *value = !adreno_is_a650_family(adreno_gpu) ? 0x100000 : 0; > return 0; > case MSM_PARAM_CHIP_ID: > - *value = adreno_gpu->rev.patchid | > - (adreno_gpu->rev.minor << 8) | > - (adreno_gpu->rev.major << 16) | > - (adreno_gpu->rev.core << 24); > + *value = (uint64_t) adreno_gpu->rev.patchid | > + (uint64_t) (adreno_gpu->rev.minor << 8) | > + (uint64_t) (adreno_gpu->rev.major << 16) | > + (uint64_t) (adreno_gpu->rev.core << 24) | > + (((uint64_t) adreno_gpu->rev.sku) << 32); How about this instead, so we are only changing the behavior for new/unreleased devices: *value = adreno_gpu->rev.patchid | (adreno_gpu->rev.minor << 8) | (adreno_gpu->rev.major << 16) | (adreno_gpu->rev.core << 24); if (!adreno_gpu->info->revn) *value |= (((uint64_t) adreno_gpu->rev.sku) << 32); (sorry about the butchered indentation.. somehow gmail has become antagonistic about pasting code) BR, -R > return 0; > case MSM_PARAM_MAX_FREQ: > *value = adreno_gpu->base.fast_rate; > -- > 2.7.4 >