From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Clark Subject: Re: [PATCH 06/20] drm/gem: inline drm_gem_object_handle_reference Date: Tue, 23 Jul 2013 08:07:47 -0400 Message-ID: References: <1373958731-4132-1-git-send-email-daniel.vetter@ffwll.ch> <1373958731-4132-7-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ob0-f175.google.com (mail-ob0-f175.google.com [209.85.214.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 3EDC5E5C72 for ; Tue, 23 Jul 2013 05:07:49 -0700 (PDT) Received: by mail-ob0-f175.google.com with SMTP id tb18so740169obb.6 for ; Tue, 23 Jul 2013 05:07:48 -0700 (PDT) In-Reply-To: <1373958731-4132-7-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org On Tue, Jul 16, 2013 at 3:11 AM, Daniel Vetter wrote: > Only one callsite and since ->handle_count is not a simple reference > count (it can resurrect) it's imo better to be explicit about things > than hide the refcount dance. I'm not really sure I like this one.. I guess it could be that I'm just used to the handle-ref stuff, so it doesn't seem odd not-inlined. And it does seem kinda odd / unsymmetric to have an unref w/out a ref. I guess I kinda like the bikeshed's current color in this case. BR, -R > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_gem.c | 3 ++- > include/drm/drmP.h | 7 ------- > 2 files changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c > index 603f256..7bcd851 100644 > --- a/drivers/gpu/drm/drm_gem.c > +++ b/drivers/gpu/drm/drm_gem.c > @@ -280,7 +280,8 @@ drm_gem_handle_create(struct drm_file *file_priv, > return ret; > *handlep = ret; > > - drm_gem_object_handle_reference(obj); > + drm_gem_object_reference(obj); > + atomic_inc(&obj->handle_count); > > if (dev->driver->gem_open_object) { > ret = dev->driver->gem_open_object(obj, file_priv); > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > index f949cb2..114db57 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -1664,13 +1664,6 @@ int drm_gem_handle_create(struct drm_file *file_priv, > int drm_gem_handle_delete(struct drm_file *filp, u32 handle); > > static inline void > -drm_gem_object_handle_reference(struct drm_gem_object *obj) > -{ > - drm_gem_object_reference(obj); > - atomic_inc(&obj->handle_count); > -} > - > -static inline void > drm_gem_object_handle_unreference_unlocked(struct drm_gem_object *obj) > { > if (obj == NULL) > -- > 1.8.3.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel