From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19867C43465 for ; Mon, 21 Sep 2020 15:20:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACBD1207C3 for ; Mon, 21 Sep 2020 15:20:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XVPz4n/z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726830AbgIUPU4 (ORCPT ); Mon, 21 Sep 2020 11:20:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726537AbgIUPU4 (ORCPT ); Mon, 21 Sep 2020 11:20:56 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A425C061755; Mon, 21 Sep 2020 08:20:56 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id a9so13179017wmm.2; Mon, 21 Sep 2020 08:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=L4bLRGp7fGx2MknkK1rcPvRD/2kcqQUQu2s4wMlqMkw=; b=XVPz4n/zlQcN4jyMyrNIZ2vLXHT266ErcWI8LLrSqHrsI9fkXIxDApXK6WCh6ZpquF e4/4l/xm6ito5hkBhvL5/m1L3I/IkyNOmF+ueb8PdfAnMHN0vIA1qXxPUH3DVOR5BJYh bJo6zmTNC5ciKMfl7d/TzqyXhNeBcRYzTDToW356D6JdzjYUS0Vvv2NdYm12ev3WpUI/ g81slmjWQt54Aw15o+lEyaKQOZzFy39qX2eJ/DC1J4rVPcggWAuVRHqzQwUFz+PK6xeZ tLa5pt8SJWKXjIJrL0z92rR8ElLZx/j6YjsBBp6apetbjE280+NdIf0R2RaXTVj/whvH /UgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=L4bLRGp7fGx2MknkK1rcPvRD/2kcqQUQu2s4wMlqMkw=; b=bcW6eCtcwKupVqPcWr0UNCXxgM5h5eE6tdoUPZY+eEWTNzXpGGczqNf4Cj2h45u0kM Uf4Bsb961sD7LiZsi0/fwCMYrhVxM6s+1icBK4lHR6Q9KN4ya8i8hWgUpD624kLaRL1c C9nbsy6vpXit4JUzL/WJN9ZW5bfV+10IHKAwiS4+6aoj0TH+sQNspkhOAkSueJHO/8hB OG7ZyKkS5M4+T2RG+P/IfgZERx1pv4xcsvOiO2x3ngXGTzO5eypdjtcNT0bzAQev/PHg ktwe/iYBoe+QPeCzFiqN3blqnjv/qGd8obusDut9WlJYI0eSBzv6/qoanMNZRYyoo29e ZXig== X-Gm-Message-State: AOAM531TwkVHG3xu1TY5Lw2EB1F2YZ4YDTzO+ZH/8riRmrEmwQO7Hl7A vhvt4iR5E+LrwdlfopvdjpYmK2BWVjo0v5DbR40= X-Google-Smtp-Source: ABdhPJwvf88sXA+M0lx6styzoy1Nw4TB6P0u+sDQBGKctBcgrrcjZszU4+Hn1o8vU4wH9LKVhuwRjN1qFEbb+uscRpw= X-Received: by 2002:a1c:b388:: with SMTP id c130mr115189wmf.175.1600701654573; Mon, 21 Sep 2020 08:20:54 -0700 (PDT) MIME-Version: 1.0 References: <20200919193727.2093945-1-robdclark@gmail.com> <20200921092154.GJ438822@phenom.ffwll.local> In-Reply-To: From: Rob Clark Date: Mon, 21 Sep 2020 08:20:42 -0700 Message-ID: Subject: Re: [PATCH 0/3] drm: commit_work scheduling To: Rob Clark , dri-devel , Rob Clark , Peter Zijlstra , linux-arm-msm , open list , Tim Murray , Tejun Heo Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Sep 21, 2020 at 8:16 AM Rob Clark wrote: > > On Mon, Sep 21, 2020 at 2:21 AM Daniel Vetter wrote: > > > > On Sat, Sep 19, 2020 at 12:37:23PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > The android userspace treats the display pipeline as a realtime problem. > > > And arguably, if your goal is to not miss frame deadlines (ie. vblank), > > > it is. (See https://lwn.net/Articles/809545/ for the best explaination > > > that I found.) > > > > > > But this presents a problem with using workqueues for non-blocking > > > atomic commit_work(), because the SCHED_FIFO userspace thread(s) can > > > preempt the worker. Which is not really the outcome you want.. once > > > the required fences are scheduled, you want to push the atomic commit > > > down to hw ASAP. > > > > > > But the decision of whether commit_work should be RT or not really > > > depends on what userspace is doing. For a pure CFS userspace display > > > pipeline, commit_work() should remain SCHED_NORMAL. > > > > > > To handle this, convert non-blocking commit_work() to use per-CRTC > > > kthread workers, instead of system_unbound_wq. Per-CRTC workers are > > > used to avoid serializing commits when userspace is using a per-CRTC > > > update loop. > > > > > > A client-cap is introduced so that userspace can opt-in to SCHED_FIFO > > > priority commit work. > > > > > > A potential issue is that since 616d91b68cd ("sched: Remove > > > sched_setscheduler*() EXPORTs") we have limited RT priority levels, > > > meaning that commit_work() ends up running at the same priority level > > > as vblank-work. This shouldn't be a big problem *yet*, due to limited > > > use of vblank-work at this point. And if it could be arranged that > > > vblank-work is scheduled before signaling out-fences and/or sending > > > pageflip events, it could probably work ok to use a single priority > > > level for both commit-work and vblank-work. > > > > The part I don't like about this is that it all feels rather hacked > > together, and if we add more stuff (or there's some different thing in the > > system that also needs rt scheduling) then it doesn't compose. > > The ideal thing would be that userspace is in control of the > priorities.. the setclientcap approach seemed like a reasonable way to > give the drm-master a way to opt in. > > I suppose instead userspace could use sched_setscheduler().. but that > would require userspace to be root, and would require some way to find > the tid. > > Is there some way we could arrange for the per-crtc kthread's to be > owned by the drm master? That would solve the "must be root" issue. > And since the target audience is an atomic userspace, I suppose we > could expose the tid as a read-only property on the crtc? Side-note, we have the same issue with work scheduled when GPU completes a batch/submit.. I'm less sure what to do with that, so figured I'd start with the commit_work because that was the "easy" part ;-) The retire_work tends to complete quickly, so maybe sched_set_fifo() is sufficient. (That plus these days things that run android tend to have 8 cores so you can kinda get away with multiple things at the same RT priority level to some degree..) > BR, > -R > > > So question to rt/worker folks: What's the best way to let userspace set > > the scheduling mode and priorities of things the kernel does on its > > behalf? Surely we're not the first ones where if userspace runs with some > > rt priority it'll starve out the kernel workers that it needs. Hardcoding > > something behind a subsystem ioctl (which just means every time userspace > > changes what it does, we need a new such flag or mode) can't be the right > > thing. > > > > Peter, Tejun? > > > > Thanks, Daniel > > > > > > > > Rob Clark (3): > > > drm/crtc: Introduce per-crtc kworker > > > drm/atomic: Use kthread worker for nonblocking commits > > > drm: Add a client-cap to set scheduling mode > > > > > > drivers/gpu/drm/drm_atomic_helper.c | 13 ++++++---- > > > drivers/gpu/drm/drm_auth.c | 4 ++++ > > > drivers/gpu/drm/drm_crtc.c | 37 +++++++++++++++++++++++++++++ > > > drivers/gpu/drm/drm_ioctl.c | 13 ++++++++++ > > > include/drm/drm_atomic.h | 31 ++++++++++++++++++++++++ > > > include/drm/drm_crtc.h | 10 ++++++++ > > > include/uapi/drm/drm.h | 13 ++++++++++ > > > 7 files changed, 117 insertions(+), 4 deletions(-) > > > > > > -- > > > 2.26.2 > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F052BC43465 for ; Mon, 21 Sep 2020 15:21:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70FD420756 for ; Mon, 21 Sep 2020 15:21:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XVPz4n/z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70FD420756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B651880C6; Mon, 21 Sep 2020 15:20:58 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 14DBF6E4E6 for ; Mon, 21 Sep 2020 15:20:56 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id k18so13147499wmj.5 for ; Mon, 21 Sep 2020 08:20:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=L4bLRGp7fGx2MknkK1rcPvRD/2kcqQUQu2s4wMlqMkw=; b=XVPz4n/zlQcN4jyMyrNIZ2vLXHT266ErcWI8LLrSqHrsI9fkXIxDApXK6WCh6ZpquF e4/4l/xm6ito5hkBhvL5/m1L3I/IkyNOmF+ueb8PdfAnMHN0vIA1qXxPUH3DVOR5BJYh bJo6zmTNC5ciKMfl7d/TzqyXhNeBcRYzTDToW356D6JdzjYUS0Vvv2NdYm12ev3WpUI/ g81slmjWQt54Aw15o+lEyaKQOZzFy39qX2eJ/DC1J4rVPcggWAuVRHqzQwUFz+PK6xeZ tLa5pt8SJWKXjIJrL0z92rR8ElLZx/j6YjsBBp6apetbjE280+NdIf0R2RaXTVj/whvH /UgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=L4bLRGp7fGx2MknkK1rcPvRD/2kcqQUQu2s4wMlqMkw=; b=fBtq+CrRp1AmgtBgUHGEiFjsG+TSzareb6kwwvU2JrPBJU7UE95TP3CzmTvf+71tF+ sJuczBm0C6TcJEN+fFW9EB6qLgrX6pd2zNPm2BAw5/3Z4m4Bzu+D2VW/ZCNXokMx1tMs l2EJm43/Nb8NC5o/FROJAFRXr9J+om3j+8ewKgUKX3r/bDxWolbyuIQjT5/8wnWcqJ9v 9OXgwdAliooo27t+f9fnzGZ0b/uYQpVSCaDsM69wI0puene2RtgQ1xlV37oZ3uluPHgl CYZpukMxLQPD+r9Yn8tFj4GyCDLnSroUCu8gR3piHQnHHgHwbmsB5X+y3W0dcmBQl1OG MK9w== X-Gm-Message-State: AOAM5309oD6SMAetUHdE4/KXl2hYYscVs5eOClG1sKoZF6AD1VN0YCJV 4/QuQTEk+Yao+anbnX01Pi5hWPcpQv7D+sjrwXU= X-Google-Smtp-Source: ABdhPJwvf88sXA+M0lx6styzoy1Nw4TB6P0u+sDQBGKctBcgrrcjZszU4+Hn1o8vU4wH9LKVhuwRjN1qFEbb+uscRpw= X-Received: by 2002:a1c:b388:: with SMTP id c130mr115189wmf.175.1600701654573; Mon, 21 Sep 2020 08:20:54 -0700 (PDT) MIME-Version: 1.0 References: <20200919193727.2093945-1-robdclark@gmail.com> <20200921092154.GJ438822@phenom.ffwll.local> In-Reply-To: From: Rob Clark Date: Mon, 21 Sep 2020 08:20:42 -0700 Message-ID: Subject: Re: [PATCH 0/3] drm: commit_work scheduling To: Rob Clark , dri-devel , Rob Clark , Peter Zijlstra , linux-arm-msm , open list , Tim Murray , Tejun Heo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Sep 21, 2020 at 8:16 AM Rob Clark wrote: > > On Mon, Sep 21, 2020 at 2:21 AM Daniel Vetter wrote: > > > > On Sat, Sep 19, 2020 at 12:37:23PM -0700, Rob Clark wrote: > > > From: Rob Clark > > > > > > The android userspace treats the display pipeline as a realtime problem. > > > And arguably, if your goal is to not miss frame deadlines (ie. vblank), > > > it is. (See https://lwn.net/Articles/809545/ for the best explaination > > > that I found.) > > > > > > But this presents a problem with using workqueues for non-blocking > > > atomic commit_work(), because the SCHED_FIFO userspace thread(s) can > > > preempt the worker. Which is not really the outcome you want.. once > > > the required fences are scheduled, you want to push the atomic commit > > > down to hw ASAP. > > > > > > But the decision of whether commit_work should be RT or not really > > > depends on what userspace is doing. For a pure CFS userspace display > > > pipeline, commit_work() should remain SCHED_NORMAL. > > > > > > To handle this, convert non-blocking commit_work() to use per-CRTC > > > kthread workers, instead of system_unbound_wq. Per-CRTC workers are > > > used to avoid serializing commits when userspace is using a per-CRTC > > > update loop. > > > > > > A client-cap is introduced so that userspace can opt-in to SCHED_FIFO > > > priority commit work. > > > > > > A potential issue is that since 616d91b68cd ("sched: Remove > > > sched_setscheduler*() EXPORTs") we have limited RT priority levels, > > > meaning that commit_work() ends up running at the same priority level > > > as vblank-work. This shouldn't be a big problem *yet*, due to limited > > > use of vblank-work at this point. And if it could be arranged that > > > vblank-work is scheduled before signaling out-fences and/or sending > > > pageflip events, it could probably work ok to use a single priority > > > level for both commit-work and vblank-work. > > > > The part I don't like about this is that it all feels rather hacked > > together, and if we add more stuff (or there's some different thing in the > > system that also needs rt scheduling) then it doesn't compose. > > The ideal thing would be that userspace is in control of the > priorities.. the setclientcap approach seemed like a reasonable way to > give the drm-master a way to opt in. > > I suppose instead userspace could use sched_setscheduler().. but that > would require userspace to be root, and would require some way to find > the tid. > > Is there some way we could arrange for the per-crtc kthread's to be > owned by the drm master? That would solve the "must be root" issue. > And since the target audience is an atomic userspace, I suppose we > could expose the tid as a read-only property on the crtc? Side-note, we have the same issue with work scheduled when GPU completes a batch/submit.. I'm less sure what to do with that, so figured I'd start with the commit_work because that was the "easy" part ;-) The retire_work tends to complete quickly, so maybe sched_set_fifo() is sufficient. (That plus these days things that run android tend to have 8 cores so you can kinda get away with multiple things at the same RT priority level to some degree..) > BR, > -R > > > So question to rt/worker folks: What's the best way to let userspace set > > the scheduling mode and priorities of things the kernel does on its > > behalf? Surely we're not the first ones where if userspace runs with some > > rt priority it'll starve out the kernel workers that it needs. Hardcoding > > something behind a subsystem ioctl (which just means every time userspace > > changes what it does, we need a new such flag or mode) can't be the right > > thing. > > > > Peter, Tejun? > > > > Thanks, Daniel > > > > > > > > Rob Clark (3): > > > drm/crtc: Introduce per-crtc kworker > > > drm/atomic: Use kthread worker for nonblocking commits > > > drm: Add a client-cap to set scheduling mode > > > > > > drivers/gpu/drm/drm_atomic_helper.c | 13 ++++++---- > > > drivers/gpu/drm/drm_auth.c | 4 ++++ > > > drivers/gpu/drm/drm_crtc.c | 37 +++++++++++++++++++++++++++++ > > > drivers/gpu/drm/drm_ioctl.c | 13 ++++++++++ > > > include/drm/drm_atomic.h | 31 ++++++++++++++++++++++++ > > > include/drm/drm_crtc.h | 10 ++++++++ > > > include/uapi/drm/drm.h | 13 ++++++++++ > > > 7 files changed, 117 insertions(+), 4 deletions(-) > > > > > > -- > > > 2.26.2 > > > > > > _______________________________________________ > > > dri-devel mailing list > > > dri-devel@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel